Rails core - Apr 2012 - Issue 5688: Mapping to a redirect route with a param can result in URI::InvalidURIError

Hi everyone,

I was looking into https://github.com/rails/rails/issues/5688 while
doing some weekend hacking.

I think I''ve got it fixed but can''t figure out how to write a
test for
this, since any attempt to create a mock request with an invalid url
like /foo/view/1234> is inadvertently caught by calls to URI.parse in
test helpers. I''ve added a workaround for the calls to URI in
ActionDispatch''s integration.rb, but something similar happens again
in rack-test''s test.rb. Not being able to test drive this leaves me
very uncomfortable.

I''m looking at the Rails codebase after a couple of years now, and
much of it is new to me - any help would be appreciated. My fix as it
stands is at
https://github.com/c42engineering/rails/commit/95aad8f0da3cb940cff9ade4053e96fd14af0627

Thanks!
Sidu Ponnappa.
http://c42.in
http://twitter.com/ponnappa

-- 
You received this message because you are subscribed to the Google Groups
"Ruby on Rails: Core" group.
To post to this group, send email to rubyonrails-core@googlegroups.com.
To unsubscribe from this group, send email to
rubyonrails-core+unsubscribe@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/rubyonrails-core?hl=en.