I''m going to add deprecation to String#encoding_aware? method and remove all of its usage from rails code as Rails 4.0 supports only ruby 1.9. Is it reasonable? Thanks. -- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com. To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com. For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en.
On Wed, Dec 21, 2011 at 1:56 AM, Sergey Nartimov <just.lest@gmail.com>wrote:> I''m going to add deprecation to String#encoding_aware? method and > remove all of its usage from rails code as Rails 4.0 supports only > ruby 1.9. >Not quite yet: it''s unclear how we''ll be working JRuby, Rubinius, and others, so this check may be needed a while longer. Jeremy -- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com. To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com. For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en.
What do you mean? Yehuda Katz (ph) 718.877.1325 On Wed, Dec 21, 2011 at 6:17 AM, Jeremy Kemper <jeremykemper@gmail.com>wrote:> On Wed, Dec 21, 2011 at 1:56 AM, Sergey Nartimov <just.lest@gmail.com>wrote: > >> I''m going to add deprecation to String#encoding_aware? method and >> remove all of its usage from rails code as Rails 4.0 supports only >> ruby 1.9. >> > > Not quite yet: it''s unclear how we''ll be working JRuby, Rubinius, and > others, so this check may be needed a while longer. > > Jeremy > > -- > You received this message because you are subscribed to the Google Groups > "Ruby on Rails: Core" group. > To post to this group, send email to rubyonrails-core@googlegroups.com. > To unsubscribe from this group, send email to > rubyonrails-core+unsubscribe@googlegroups.com. > For more options, visit this group at > http://groups.google.com/group/rubyonrails-core?hl=en. >-- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com. To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com. For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en.
Encoding support is under active development in Rubinius. So it''d worth PDIing whether we have 1.9-capable Ruby engines with not-fully-baked encoding support before removing encoding_aware? checks. (I''m not sure about JRuby''s support, either.) On Thu, Dec 22, 2011 at 2:25 AM, Yehuda Katz <wycats@gmail.com> wrote:> What do you mean? > > Yehuda Katz > (ph) 718.877.1325 > > > On Wed, Dec 21, 2011 at 6:17 AM, Jeremy Kemper <jeremykemper@gmail.com>wrote: > >> On Wed, Dec 21, 2011 at 1:56 AM, Sergey Nartimov <just.lest@gmail.com>wrote: >> >>> I''m going to add deprecation to String#encoding_aware? method and >>> remove all of its usage from rails code as Rails 4.0 supports only >>> ruby 1.9. >>> >> >> Not quite yet: it''s unclear how we''ll be working JRuby, Rubinius, and >> others, so this check may be needed a while longer. >> >> Jeremy >> >> -- >> You received this message because you are subscribed to the Google Groups >> "Ruby on Rails: Core" group. >> To post to this group, send email to rubyonrails-core@googlegroups.com. >> To unsubscribe from this group, send email to >> rubyonrails-core+unsubscribe@googlegroups.com. >> For more options, visit this group at >> http://groups.google.com/group/rubyonrails-core?hl=en. >> > > -- > You received this message because you are subscribed to the Google Groups > "Ruby on Rails: Core" group. > To post to this group, send email to rubyonrails-core@googlegroups.com. > To unsubscribe from this group, send email to > rubyonrails-core+unsubscribe@googlegroups.com. > For more options, visit this group at > http://groups.google.com/group/rubyonrails-core?hl=en. >-- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com. To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com. For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en.
If there are Ruby engines with only partial 1.9 support, and we want to support them, we should probably PDI whether we are in a position to drop 1.8 support at this time. Yehuda Katz (ph) 718.877.1325 On Thu, Dec 22, 2011 at 8:12 AM, Jeremy Kemper <jeremykemper@gmail.com>wrote:> Encoding support is under active development in Rubinius. > > So it''d worth PDIing whether we have 1.9-capable Ruby engines with > not-fully-baked encoding support before removing encoding_aware? checks. > > (I''m not sure about JRuby''s support, either.) > > > On Thu, Dec 22, 2011 at 2:25 AM, Yehuda Katz <wycats@gmail.com> wrote: > >> What do you mean? >> >> Yehuda Katz >> (ph) 718.877.1325 >> >> >> On Wed, Dec 21, 2011 at 6:17 AM, Jeremy Kemper <jeremykemper@gmail.com>wrote: >> >>> On Wed, Dec 21, 2011 at 1:56 AM, Sergey Nartimov <just.lest@gmail.com>wrote: >>> >>>> I''m going to add deprecation to String#encoding_aware? method and >>>> remove all of its usage from rails code as Rails 4.0 supports only >>>> ruby 1.9. >>>> >>> >>> Not quite yet: it''s unclear how we''ll be working JRuby, Rubinius, and >>> others, so this check may be needed a while longer. >>> >>> Jeremy >>> >>> -- >>> You received this message because you are subscribed to the Google >>> Groups "Ruby on Rails: Core" group. >>> To post to this group, send email to rubyonrails-core@googlegroups.com. >>> To unsubscribe from this group, send email to >>> rubyonrails-core+unsubscribe@googlegroups.com. >>> For more options, visit this group at >>> http://groups.google.com/group/rubyonrails-core?hl=en. >>> >> >> -- >> You received this message because you are subscribed to the Google Groups >> "Ruby on Rails: Core" group. >> To post to this group, send email to rubyonrails-core@googlegroups.com. >> To unsubscribe from this group, send email to >> rubyonrails-core+unsubscribe@googlegroups.com. >> For more options, visit this group at >> http://groups.google.com/group/rubyonrails-core?hl=en. >> > > -- > You received this message because you are subscribed to the Google Groups > "Ruby on Rails: Core" group. > To post to this group, send email to rubyonrails-core@googlegroups.com. > To unsubscribe from this group, send email to > rubyonrails-core+unsubscribe@googlegroups.com. > For more options, visit this group at > http://groups.google.com/group/rubyonrails-core?hl=en. >-- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com. To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com. For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en.
PDIed. JRuby and Rubinius are sufficiently syntax- and API-ready. Encoding support is under active dev in Rubinius, so any gaps or bugs we flush out will be good pressure. So +1 to remove `#encoding_aware?` On Thu, Dec 22, 2011 at 6:23 PM, Yehuda Katz <wycats@gmail.com> wrote:> If there are Ruby engines with only partial 1.9 support, and we want to > support them, we should probably PDI whether we are in a position to drop > 1.8 support at this time. > > Yehuda Katz > (ph) 718.877.1325 > > > > On Thu, Dec 22, 2011 at 8:12 AM, Jeremy Kemper <jeremykemper@gmail.com>wrote: > >> Encoding support is under active development in Rubinius. >> >> So it''d worth PDIing whether we have 1.9-capable Ruby engines with >> not-fully-baked encoding support before removing encoding_aware? checks. >> >> (I''m not sure about JRuby''s support, either.) >> >> >> On Thu, Dec 22, 2011 at 2:25 AM, Yehuda Katz <wycats@gmail.com> wrote: >> >>> What do you mean? >>> >>> Yehuda Katz >>> (ph) 718.877.1325 >>> >>> >>> On Wed, Dec 21, 2011 at 6:17 AM, Jeremy Kemper <jeremykemper@gmail.com>wrote: >>> >>>> On Wed, Dec 21, 2011 at 1:56 AM, Sergey Nartimov <just.lest@gmail.com>wrote: >>>> >>>>> I''m going to add deprecation to String#encoding_aware? method and >>>>> remove all of its usage from rails code as Rails 4.0 supports only >>>>> ruby 1.9. >>>>> >>>> >>>> Not quite yet: it''s unclear how we''ll be working JRuby, Rubinius, and >>>> others, so this check may be needed a while longer. >>>> >>>> Jeremy >>>> >>>> -- >>>> You received this message because you are subscribed to the Google >>>> Groups "Ruby on Rails: Core" group. >>>> To post to this group, send email to rubyonrails-core@googlegroups.com. >>>> To unsubscribe from this group, send email to >>>> rubyonrails-core+unsubscribe@googlegroups.com. >>>> For more options, visit this group at >>>> http://groups.google.com/group/rubyonrails-core?hl=en. >>>> >>> >>> -- >>> You received this message because you are subscribed to the Google >>> Groups "Ruby on Rails: Core" group. >>> To post to this group, send email to rubyonrails-core@googlegroups.com. >>> To unsubscribe from this group, send email to >>> rubyonrails-core+unsubscribe@googlegroups.com. >>> For more options, visit this group at >>> http://groups.google.com/group/rubyonrails-core?hl=en. >>> >> >> -- >> You received this message because you are subscribed to the Google Groups >> "Ruby on Rails: Core" group. >> To post to this group, send email to rubyonrails-core@googlegroups.com. >> To unsubscribe from this group, send email to >> rubyonrails-core+unsubscribe@googlegroups.com. >> For more options, visit this group at >> http://groups.google.com/group/rubyonrails-core?hl=en. >> > > -- > You received this message because you are subscribed to the Google Groups > "Ruby on Rails: Core" group. > To post to this group, send email to rubyonrails-core@googlegroups.com. > To unsubscribe from this group, send email to > rubyonrails-core+unsubscribe@googlegroups.com. > For more options, visit this group at > http://groups.google.com/group/rubyonrails-core?hl=en. >-- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com. To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com. For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en.
Than I''ll start work on it, will prepare PR in couple of days. On Fri, Dec 23, 2011 at 10:47 PM, Jeremy Kemper <jeremykemper@gmail.com> wrote:> PDIed. JRuby and Rubinius are sufficiently syntax- and API-ready. Encoding > support is under active dev in Rubinius, so any gaps or bugs we flush out > will be good pressure. So +1 to remove `#encoding_aware?`-- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com. To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com. For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en.