James MacAulay
2010-May-18 19:47 UTC
[BUG] [PATCH] AS::MB::Chars concatenation with + (plus) method should not alter the original
Small but nasty bug, tested and fixed: https://rails.lighthouseapp.com/projects/8994-ruby-on-rails/tickets/4646-bug-activesupportmultibytechars-concatenation-with-plus-method-should-not-alter-the-original Would love someone to review this. -James -- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com. To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com. For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en.
Norman Clarke
2010-May-19 13:53 UTC
Re: [BUG] [PATCH] AS::MB::Chars concatenation with + (plus) method should not alter the original
On Tue, May 18, 2010 at 16:47, James MacAulay <jmacaulay@gmail.com> wrote:> Small but nasty bug, tested and fixed: > > https://rails.lighthouseapp.com/projects/8994-ruby-on-rails/tickets/4646-bug-activesupportmultibytechars-concatenation-with-plus-method-should-not-alter-the-original > > Would love someone to review this.Looks good to me, nice catch. Regards, Norman -- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com. To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com. For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en.
Allen Madsen
2010-May-19 14:05 UTC
Re: [BUG] [PATCH] AS::MB::Chars concatenation with + (plus) method should not alter the original
+1 Allen Madsen http://www.allenmadsen.com On Wed, May 19, 2010 at 9:53 AM, Norman Clarke <norman@njclarke.com> wrote:> On Tue, May 18, 2010 at 16:47, James MacAulay <jmacaulay@gmail.com> wrote: >> Small but nasty bug, tested and fixed: >> >> https://rails.lighthouseapp.com/projects/8994-ruby-on-rails/tickets/4646-bug-activesupportmultibytechars-concatenation-with-plus-method-should-not-alter-the-original >> >> Would love someone to review this. > > Looks good to me, nice catch. > > Regards, > > Norman > > -- > You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. > To post to this group, send email to rubyonrails-core@googlegroups.com. > To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com. > For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en. > >-- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com. To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com. For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en.
tommy xiao
2010-May-20 03:45 UTC
Re: [BUG] [PATCH] AS::MB::Chars concatenation with + (plus) method should not alter the original
good patch! 2010/5/19 Allen Madsen <allen.c.madsen@gmail.com>> +1 > > Allen Madsen > http://www.allenmadsen.com > > > > On Wed, May 19, 2010 at 9:53 AM, Norman Clarke <norman@njclarke.com> > wrote: > > On Tue, May 18, 2010 at 16:47, James MacAulay <jmacaulay@gmail.com> > wrote: > >> Small but nasty bug, tested and fixed: > >> > >> > https://rails.lighthouseapp.com/projects/8994-ruby-on-rails/tickets/4646-bug-activesupportmultibytechars-concatenation-with-plus-method-should-not-alter-the-original > >> > >> Would love someone to review this. > > > > Looks good to me, nice catch. > > > > Regards, > > > > Norman > > > > -- > > You received this message because you are subscribed to the Google Groups > "Ruby on Rails: Core" group. > > To post to this group, send email to rubyonrails-core@googlegroups.com. > > To unsubscribe from this group, send email to > rubyonrails-core+unsubscribe@googlegroups.com<rubyonrails-core%2Bunsubscribe@googlegroups.com> > . > > For more options, visit this group at > http://groups.google.com/group/rubyonrails-core?hl=en. > > > > > > -- > You received this message because you are subscribed to the Google Groups > "Ruby on Rails: Core" group. > To post to this group, send email to rubyonrails-core@googlegroups.com. > To unsubscribe from this group, send email to > rubyonrails-core+unsubscribe@googlegroups.com<rubyonrails-core%2Bunsubscribe@googlegroups.com> > . > For more options, visit this group at > http://groups.google.com/group/rubyonrails-core?hl=en. > >-- tommy xiao E-mail: xiaods(AT)gmail.com -- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com. To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com. For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en.