Hi all, I just submitted a small patch for the parameterize helper method. It currently allows + signs, which are (when used in URL''s) interpreted as spaces, resulting in the following error; ArgumentError: illegal character in key Please check out the patch in lighthouse (for the 2-3-stable branch and the master branch) at; https://rails.lighthouseapp.com/projects/8994-ruby-on-rails/tickets/4080-rails-inflector-parameterize-vs-signs Hoping to get the patch in, Stijn -- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com. To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com. For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en.
Teng Siong Ong
2010-Mar-05 07:20 UTC
Re: please checkout my patch for the parameterize function
Why is your patch for 2.3-stable so huge? Are you on the edge for that particular branch? On Fri, Mar 5, 2010 at 1:09 AM, Stijnster <s.mathysen@telenet.be> wrote:> Hi all, > > > I just submitted a small patch for the parameterize helper method. It > currently allows + signs, which are (when used in URL''s) interpreted > as spaces, resulting in the following error; > > ArgumentError: illegal character in key > > > Please check out the patch in lighthouse (for the 2-3-stable branch > and the master branch) at; > > > https://rails.lighthouseapp.com/projects/8994-ruby-on-rails/tickets/4080-rails-inflector-parameterize-vs-signs > > > > Hoping to get the patch in, > > > Stijn > > -- > You received this message because you are subscribed to the Google Groups > "Ruby on Rails: Core" group. > To post to this group, send email to rubyonrails-core@googlegroups.com. > To unsubscribe from this group, send email to > rubyonrails-core+unsubscribe@googlegroups.com<rubyonrails-core%2Bunsubscribe@googlegroups.com> > . > For more options, visit this group at > http://groups.google.com/group/rubyonrails-core?hl=en. > >-- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com. To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com. For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en.
Stijnster
2010-Mar-05 11:43 UTC
Re: please checkout my patch for the parameterize function
Aaah, I was already afraid I did something wrong because the patch of the master branch is just a few k (see also my concerns in the last ticket post). I did a checkout of the 2-3-stable branch and continued from there. Can you explain me how do I take it to the edge, then I can rewrite and resubmit the patch? Thanks! Stijn On Mar 5, 8:20 am, Teng Siong Ong <siong1...@gmail.com> wrote:> Why is your patch for 2.3-stable so huge? Are you on the edge for that > particular branch? > > > > On Fri, Mar 5, 2010 at 1:09 AM, Stijnster <s.mathy...@telenet.be> wrote: > > Hi all, > > > I just submitted a small patch for the parameterize helper method. It > > currently allows + signs, which are (when used in URL''s) interpreted > > as spaces, resulting in the following error; > > > ArgumentError: illegal character in key > > > Please check out the patch in lighthouse (for the 2-3-stable branch > > and the master branch) at; > > >https://rails.lighthouseapp.com/projects/8994-ruby-on-rails/tickets/4... > > > Hoping to get the patch in, > > > Stijn > > > -- > > You received this message because you are subscribed to the Google Groups > > "Ruby on Rails: Core" group. > > To post to this group, send email to rubyonrails-core@googlegroups.com. > > To unsubscribe from this group, send email to > > rubyonrails-core+unsubscribe@googlegroups.com<rubyonrails-core%2Bunsubscrib e@googlegroups.com> > > . > > For more options, visit this group at > >http://groups.google.com/group/rubyonrails-core?hl=en.-- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com. To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com. For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en.
Teng Siong Ong
2010-Mar-06 08:33 UTC
Re: Re: please checkout my patch for the parameterize function
it''s already committed to rails. congrats. On Fri, Mar 5, 2010 at 5:43 AM, Stijnster <s.mathysen@telenet.be> wrote:> Aaah, I was already afraid I did something wrong because the patch of > the master branch is just a few k (see also my concerns in the last > ticket post). > > I did a checkout of the 2-3-stable branch and continued from there. > Can you explain me how do I take it to the edge, then I can rewrite > and resubmit the patch? > > Thanks! > > Stijn > > On Mar 5, 8:20 am, Teng Siong Ong <siong1...@gmail.com> wrote: > > Why is your patch for 2.3-stable so huge? Are you on the edge for that > > particular branch? > > > > > > > > On Fri, Mar 5, 2010 at 1:09 AM, Stijnster <s.mathy...@telenet.be> wrote: > > > Hi all, > > > > > I just submitted a small patch for the parameterize helper method. It > > > currently allows + signs, which are (when used in URL''s) interpreted > > > as spaces, resulting in the following error; > > > > > ArgumentError: illegal character in key > > > > > Please check out the patch in lighthouse (for the 2-3-stable branch > > > and the master branch) at; > > > > >https://rails.lighthouseapp.com/projects/8994-ruby-on-rails/tickets/4. > .. > > > > > Hoping to get the patch in, > > > > > Stijn > > > > > -- > > > You received this message because you are subscribed to the Google > Groups > > > "Ruby on Rails: Core" group. > > > To post to this group, send email to rubyonrails-core@googlegroups.com > . > > > To unsubscribe from this group, send email to > > > rubyonrails-core+unsubscribe@googlegroups.com<rubyonrails-core%2Bunsubscribe@googlegroups.com><rubyonrails-core%2Bunsubscrib > e@googlegroups.com> > > > . > > > For more options, visit this group at > > >http://groups.google.com/group/rubyonrails-core?hl=en. > > -- > You received this message because you are subscribed to the Google Groups > "Ruby on Rails: Core" group. > To post to this group, send email to rubyonrails-core@googlegroups.com. > To unsubscribe from this group, send email to > rubyonrails-core+unsubscribe@googlegroups.com<rubyonrails-core%2Bunsubscribe@googlegroups.com> > . > For more options, visit this group at > http://groups.google.com/group/rubyonrails-core?hl=en. > >-- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com. To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com. For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en.