alexey.verkhovsky@gmail.com
2008-Feb-15 20:29 UTC
[CruiseControl] RubyOnRails build 8873 failed
The build failed.
CHANGES
-------
Revision 8873 committed by bitsweat on 2008-02-15 20:12:45
Fix typo in migration test. Closes #11105 [h-lame]
M /trunk/activerecord/test/cases/migration_test.rb
TEST FAILURES AND ERRORS
-----------------------
Name:
test_rendering_partial_with_has_many_association(RenderPartialWithRecordIdentificationTest)
Type: Failure
Message: expecting <"topics/_topic"> but rendering with
<nil>
./test/activerecord/render_partial_with_record_identification_test.rb:58:in
`test_rendering_partial_with_has_many_association''
./test/../lib/../../activesupport/lib/active_support/testing/setup_and_teardown.rb:59:in
`__send__''
./test/../lib/../../activesupport/lib/active_support/testing/setup_and_teardown.rb:59:in
`run''
./test/active_record_unit.rb:99:in `run''
See http://cruisecontrolrb.thoughtworks.com/builds/RubyOnRails/8873 for details.
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Ruby on Rails: Core" group.
To post to this group, send email to rubyonrails-core@googlegroups.com
To unsubscribe from this group, send email to
rubyonrails-core-unsubscribe@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/rubyonrails-core?hl=en
-~----------~----~----~----~------~----~------~--~---
On Fri, Feb 15, 2008 at 12:29 PM, <alexey.verkhovsky@gmail.com> wrote:> The build failed. > > CHANGES > ------- > Revision 8873 committed by bitsweat on 2008-02-15 20:12:45 > Fix typo in migration test. Closes #11105 [h-lame] > > M /trunk/activerecord/test/cases/migration_test.rbThis started with http://cruisecontrolrb.thoughtworks.com/builds/RubyOnRails/8865 How is this failure at all related to that changeset? jeremy --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core-unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
I actually just patched it. Problem was that
has_many_through_association didn''t have any? defined, which caused it
to call super(:any?) { stuff }, but if stuff was empty, it would call
array.any? {}, which returns null. Patch can be found here:
http://dev.rubyonrails.org/ticket/11130
Regards,
Jan De Poorter
On 15 Feb 2008, at 22:04, Jeremy Kemper wrote:
>
> On Fri, Feb 15, 2008 at 12:29 PM, <alexey.verkhovsky@gmail.com>
> wrote:
>> The build failed.
>>
>> CHANGES
>> -------
>> Revision 8873 committed by bitsweat on 2008-02-15 20:12:45
>> Fix typo in migration test. Closes #11105 [h-lame]
>>
>> M /trunk/activerecord/test/cases/migration_test.rb
>
> This started with
> http://cruisecontrolrb.thoughtworks.com/builds/RubyOnRails/8865
>
> How is this failure at all related to that changeset?
>
> jeremy
>
> >
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Ruby on Rails: Core" group.
To post to this group, send email to rubyonrails-core@googlegroups.com
To unsubscribe from this group, send email to
rubyonrails-core-unsubscribe@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/rubyonrails-core?hl=en
-~----------~----~----~----~------~----~------~--~---
On Feb 15, 2008 2:13 PM, Jan De Poorter <jan@openminds.be> wrote:> I actually just patched it. Problem was that > has_many_through_association didn''t have any? defined, which caused it > to call super(:any?) { stuff }, but if stuff was empty, it would call > array.any? {}, which returns null. Patch can be found here: > > http://dev.rubyonrails.org/ticket/11130Thanks Jan. I already rolled back. Let''s re-evaluate and add a bit of test coverage. Best, jeremy --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core-unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
On Saturday 16 February 2008 00:47:48 Jeremy Kemper wrote:> On Feb 15, 2008 2:13 PM, Jan De Poorter <jan@openminds.be> wrote: > > I actually just patched it. Problem was that > > has_many_through_association didn''t have any? defined, which caused it > > to call super(:any?) { stuff }, but if stuff was empty, it would call > > array.any? {}, which returns null. Patch can be found here: > Let''s re-evaluate and add a bit of test coverage.Ok, I know why my "no named block arguments" patch was wrong. See my last comment for http://dev.rubyonrails.org/ticket/11109 for details. I also added a very simple test that definitely breaks with my last patch and which passes with my new patch. Please take a look. Is the new patch ok? Do you want me to add more tests? --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core-unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---