Anthony Eden
2007-Aug-20 12:16 UTC
Adapters in Rails Core (Was: Refactoring AR::Base.find)
On 8/20/07, Piyush Ranjan <piyush.pr@gmail.com> wrote:> > > > > This reminds me to ask, are we gonna get rid of most of the adapters > > from core for 2.0 ? I guess, only mysql and postgres and may be sqlite > > deserves to be in core. Other adapter might be better off as external > > libs. > > Shouldn''t we also have Oracle adapter in the core? > > With an ever increasing popularity of Rails a lot of big companies are now > using it for their production quality apps and most of these run on oracle. > I do agree that it won''t much of a difference whether Rails has oracle libs > in built or are provided as external libs. > However it would be a little easy to convince the CTOs to tip the favour > towards Rails if it oracle support is provided out of the box.Which then leads one to ask the same thing about SQL Server. If some adapters are removed from the core then there are some things which need to happen to make sure that non-core adapters do not become stale: 1.) Each adapter needs a CI environment and it somehow needs to be synced to changes in the core. 2.) There needs to be an easy way to install adapters. Personally I''d like to see the entire adapter code be moved into its own project. Having a common database layer that provides more beyond DBI is a good thing, IMO, and usable in its own right. V/r Anthony -- Cell: 808 782-5046 Current Location: Melbourne, FL --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core-unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
If you open these adapter files, you''ll find : Oracel Adapter : # Current maintainer: Michael Schoen <schoenm@earthlink.net> SQLServer Adapter : # Current maintainer: Tom Ward <tom@popdog.net> No point in keeping them in core, as that''ll just prolong the devlopment cycle and bug fixing process. So these stuff can probably go under the same roof that we discussed for ex-rails plugins. On 8/20/07, Anthony Eden <anthonyeden@gmail.com> wrote:> > On 8/20/07, Piyush Ranjan <piyush.pr@gmail.com> wrote: > > > > > > > > This reminds me to ask, are we gonna get rid of most of the adapters > > > from core for 2.0 ? I guess, only mysql and postgres and may be sqlite > > > deserves to be in core. Other adapter might be better off as external > > > libs. > > > > Shouldn''t we also have Oracle adapter in the core? > > > > With an ever increasing popularity of Rails a lot of big companies are now > > using it for their production quality apps and most of these run on oracle. > > I do agree that it won''t much of a difference whether Rails has oracle libs > > in built or are provided as external libs. > > However it would be a little easy to convince the CTOs to tip the favour > > towards Rails if it oracle support is provided out of the box. > > Which then leads one to ask the same thing about SQL Server. > > If some adapters are removed from the core then there are some things > which need to happen to make sure that non-core adapters do not become > stale: > > 1.) Each adapter needs a CI environment and it somehow needs to be > synced to changes in the core. > 2.) There needs to be an easy way to install adapters. > > Personally I''d like to see the entire adapter code be moved into its > own project. Having a common database layer that provides more beyond > DBI is a good thing, IMO, and usable in its own right. > > V/r > Anthony > > -- > Cell: 808 782-5046 > Current Location: Melbourne, FL > > > >-- Cheers! - Pratik http://m.onkey.org --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core-unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
Michael A. Schoen
2007-Aug-20 22:06 UTC
Re: Adapters in Rails Core (Was: Refactoring AR::Base.find)
Pratik wrote:> Oracel Adapter : > # Current maintainer: Michael Schoen <schoenm@earthlink.net> > > No point in keeping them in core, as that''ll just prolong the > devlopment cycle and bug fixing process. > > So these stuff can probably go under the same roof that we discussed > for ex-rails plugins.Speaking only for myself, I''d still need svn and Trac hosting. As long as that can be maintained, core vs. non-core doesn''t matter as much. Though I guess I''d still be a bit concerned about an under-informed sense that "standard Rails" wouldn''t have Oracle compatibility. --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core-unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
Michael Koziarski
2007-Aug-21 09:02 UTC
Re: Adapters in Rails Core (Was: Refactoring AR::Base.find)
> Speaking only for myself, I''d still need svn and Trac hosting. As long > as that can be maintained, core vs. non-core doesn''t matter as much. > Though I guess I''d still be a bit concerned about an under-informed > sense that "standard Rails" wouldn''t have Oracle compatibility.Well, as it stands adapters basically can''t work properly in plugins. So before we looked into extracting the commercial adapters, we''d need to investigate that first :). Hopefully someone implementing a new adapter will take a look at what''s required, then we can start thinking about what we do with the less-used adapters. However with an active, hard-working, long-term maintainer, I can''t see any downside to keeping oracle around :) -- Cheers Koz --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core-unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---