Hi, As a part of weekend exercise, I put together a tiny app for sanity checking rails core patches. It''s in infancy stages as it was done very quickly. What it does : - Takes url of the patch - Asks which test suites to run - Patch latest edge with the patch supplied, runs the tests, and give you the results * Always applies patch from top level ( -p0 ) * Gives failure even if patch couldn''t be applied cleanly ( no hunks success allowed ) This should be quite handy to cleanup old patches and can save some time. It''s accessible at http://rails.corefun.org/ Due to the nature of the app, I''ll have to create the account before you can use it ( email me or catch me in irc (lifo) ). I''ll make the source public once I make some more internal changes and my friend(rsl) gives me a good design. Meanwhile, if you fancy checking it out or helping with the app or may be suggest a feature or two, that''ll be great. -- Cheers! - Pratik http://m.onkey.org --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core-unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
On E, 2007-07-23 at 03:18 +0100, Pratik wrote:> * Always applies patch from top level ( -p0 )Why not try to either find the files referenced in the patch and then apply the patch at the correct directory or at least try to apply the patch at a specific component directory? http://rails.corefun.org/tasks/14 is a nice example of the problem, if the patch had been applied at the correct component level then it should have applied correctly. Also it shouldn''t hurt to try to apply the patch with -p1 after -p0 fails with files not found. -- Tarmo Tänav <tarmo@itech.ee> --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core-unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
Well, I''m just going to add a dropdown box to select from where to apply the patch. -Pratik On 7/23/07, Tarmo Tänav <tarmo@itech.ee> wrote:> > On E, 2007-07-23 at 03:18 +0100, Pratik wrote: > > * Always applies patch from top level ( -p0 ) > > Why not try to either find the files referenced in the > patch and then apply the patch at the correct directory > or at least try to apply the patch at a specific > component directory? > > http://rails.corefun.org/tasks/14 is a nice example of > the problem, if the patch had been applied at the correct > component level then it should have applied correctly. > > Also it shouldn''t hurt to try to apply the patch with > -p1 after -p0 fails with files not found. > > > -- > Tarmo Tänav <tarmo@itech.ee> > > > > >-- Cheers! - Pratik http://m.onkey.org --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core-unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---