Hi, Can someone from Core apply this patch for SQL Server? http://dev.rubyonrails.org/ticket/8886 I''ve tested it, and it works fine. Thanks, Rich C. --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core-unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
On Wed, Jul 18, 2007 at 02:46:53AM -0000, Rich C wrote:> Hi, Can someone from Core apply this patch for SQL Server? > > http://dev.rubyonrails.org/ticket/8886 > > I''ve tested it, and it works fine.According to http://wiki.rubyonrails.org/rails/pages/PatchRequirements, you want to put that comment in the ticket and get two other people to look at the patch and comment. Once you''ve got three votes, set the ''approved'' tag on the ticket. - Matt -- MySQL seems to be the Windows of the database world. Broken, underspecced, and mainly only popular due to inertia and people who don''t really know what they''re doing. -- Peter Corlett, in the Monastery --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core-unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
On Jul 17, 2007, at 8:27 PM, Matthew Palmer wrote:> According to http://wiki.rubyonrails.org/rails/pages/ > PatchRequirements, you > want to put that comment in the ticket and get two other people to > look at > the patch and comment. Once you''ve got three votes, set the > ''approved'' tag > on the ticket.Actually, the keyword to use is "verified", not "approved". The verified patches report will only find [PATCH] tickets with the keyword "verified". -- Josh Susser http://blog.hasmanythrough.com --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core-unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
On Thu, Jul 19, 2007 at 09:04:49AM -0700, Josh Susser wrote:> > > On Jul 17, 2007, at 8:27 PM, Matthew Palmer wrote: > > According to http://wiki.rubyonrails.org/rails/pages/ > > PatchRequirements, you > > want to put that comment in the ticket and get two other people to > > look at > > the patch and comment. Once you''ve got three votes, set the > > ''approved'' tag > > on the ticket. > > Actually, the keyword to use is "verified", not "approved". TheOops.> verified patches report will only find [PATCH] tickets with the > keyword "verified".Except the report''s broken at the moment... <grin> - Matt -- Just because we work at a University doesn''t mean we''re surrounded by smart people. -- Brian Kantor, in the monastery --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core-unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
> Except the report''s broken at the moment... <grin>Really? What''s not showing up that should be? Trac''s reports are just sql queries, and it ''looks'' right to me. -- Cheers Koz --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core-unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
Koz, Check http://dev.rubyonrails.org/ticket/8894 - it doesn''t show up in report#12. Thanks -Pratik On 7/19/07, Michael Koziarski <michael@koziarski.com> wrote:> > > Except the report''s broken at the moment... <grin> > > Really? What''s not showing up that should be? > > Trac''s reports are just sql queries, and it ''looks'' right to me. > > -- > Cheers > > Koz > > > >-- http://m.onkey.org --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core-unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
Fixed... If I never have to edit a trac report again, it''ll be too soon :). Ok, there''s a bunch of tickets now with the verified keyword which don''t have the required three review comments. Could you guys please take some time to go through those patches and either: 1) Review them, or 2) remove the verified keyword. All the best. On 7/20/07, Pratik <pratiknaik@gmail.com> wrote:> > Koz, Check http://dev.rubyonrails.org/ticket/8894 - it doesn''t show up > in report#12. > > Thanks > -Pratik > > On 7/19/07, Michael Koziarski <michael@koziarski.com> wrote: > > > > > Except the report''s broken at the moment... <grin> > > > > Really? What''s not showing up that should be? > > > > Trac''s reports are just sql queries, and it ''looks'' right to me. > > > > -- > > Cheers > > > > Koz > > > > > > > > > > -- > http://m.onkey.org > > > >-- Cheers Koz --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core-unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
On 7/19/07, Michael Koziarski <michael@koziarski.com> wrote:> > Fixed... If I never have to edit a trac report again, it''ll be too soon :). >Heh. Well, looks like you''re successfully fetching all tickets with "unverified" keyword as well :-) Example : http://dev.rubyonrails.org/ticket/8532 -- Cheers! - Pratik http://m.onkey.org --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core-unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
Matthew Palmer
2007-Jul-19 22:57 UTC
Re: Verified tickets report resuscitated [was: http://dev.rubyonrails.org/ticket/8886]
On Fri, Jul 20, 2007 at 10:35:32AM +1200, Michael Koziarski wrote:> Fixed... If I never have to edit a trac report again, it''ll be too soon :).That good, huh?> Ok, there''s a bunch of tickets now with the verified keyword which > don''t have the required three review comments.Holy lordy heckfire! 97 tickets!> Could you guys please > take some time to go through those patches and either:I''ll do a quick pass over them all to remove the keyword, I can''t guarantee I''ll comment on them all, but I''ll see how I go... Thanks for fixing the report. - Matt -- When I was a kid I used to pray every night for a new bicycle. Then I realised that the Lord doesn''t work that way so I stole one and asked Him to forgive me. -- Emo Philips. --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core-unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
On 7/20/07, Pratik <pratiknaik@gmail.com> wrote:> > > Well, looks like you''re successfully fetching all tickets with > "unverified" keyword as well :-)WHERE status IN (''new'', ''assigned'', ''reopened'') and keywords LIKE ''%verified%'' --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core-unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
WHERE status IN ('new', 'assigned', 'reopened') and
keywords LIKE ' verified '
On 7/19/07, Mislav Marohnić <mislav.marohnic@gmail.com>
wrote:> On 7/20/07, Pratik <pratiknaik@gmail.com> wrote:
> >
> > Well, looks like you're successfully fetching all tickets with
> > "unverified" keyword as well :-)
>
> WHERE status IN ('new', 'assigned', 'reopened') and
keywords LIKE
> '%verified%'
>
>
>
> >
>
--
Cheers!
- Pratik
http://m.onkey.org
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Ruby on Rails: Core" group.
To post to this group, send email to rubyonrails-core@googlegroups.com
To unsubscribe from this group, send email to
rubyonrails-core-unsubscribe@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/rubyonrails-core?hl=en
-~----------~----~----~----~------~----~------~--~---
On 7/20/07, Pratik <pratiknaik@gmail.com> wrote:> WHERE status IN (''new'', ''assigned'', ''reopened'') and keywords LIKE '' verified ''Lets try that for a while :). -- Cheers Koz --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core-unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
Oh no..that''s gonna fail as well when verified is in front..I guess
best bet is following as Norbert pointed in irc :
WHERE status IN (''new'', ''assigned'',
''reopened'') and keywords LIKE
''%verified%'' and keywords NOT LIKE
''%unverified%''
If that works..
On 7/20/07, Michael Koziarski <michael@koziarski.com>
wrote:>
> On 7/20/07, Pratik <pratiknaik@gmail.com> wrote:
> > WHERE status IN (''new'',
''assigned'', ''reopened'') and keywords LIKE
'' verified ''
>
> Lets try that for a while :).
>
> --
> Cheers
>
> Koz
>
> >
>
--
Cheers!
- Pratik
http://m.onkey.org
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Ruby on Rails: Core" group.
To post to this group, send email to rubyonrails-core@googlegroups.com
To unsubscribe from this group, send email to
rubyonrails-core-unsubscribe@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/rubyonrails-core?hl=en
-~----------~----~----~----~------~----~------~--~---
WHERE status IN (''new'', ''assigned'',
''reopened'')
AND keywords LIKE ''%verified%'' AND keywords NOT LIKE
''%unverified%''
Alternative? We could just remove all instances of
''unverified'' keyword. It
doesn''t make sense anyway.
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Ruby on Rails: Core" group.
To post to this group, send email to rubyonrails-core@googlegroups.com
To unsubscribe from this group, send email to
rubyonrails-core-unsubscribe@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/rubyonrails-core?hl=en
-~----------~----~----~----~------~----~------~--~---
On 7/20/07, Pratik <pratiknaik@gmail.com> wrote:> > Oh no..that''s gonna fail as well when verified is in front..I guess > best bet is following as Norbert pointed in irc : > > WHERE status IN (''new'', ''assigned'', ''reopened'') and keywords LIKE > ''%verified%'' and keywords NOT LIKE ''%unverified%''That''s what I had before, I think. If there are any other clashes with other keywords, just remove them. -- Cheers Koz --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core-unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
Here is the report with "unverified" keyword: http://dev.rubyonrails.org/query?status=new&status=assigned&status=reopened&keywords=%7Eunverified&order=priority Someone should go through these and remove the redundant keyword. All tickets are considered unverified until verified by the new formal patch review process. --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core-unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
Done. Koz, may be you can delete report#17. Shouldn't get close everything under http://dev.rubyonrails.org/report/11 ? On 7/20/07, Mislav Marohnić <mislav.marohnic@gmail.com> wrote:> Here is the report with "unverified" keyword: > http://dev.rubyonrails.org/query?status=new&status=assigned&status=reopened&keywords=%7Eunverified&order=priority > > Someone should go through these and remove the redundant keyword. All > tickets are considered unverified until verified by the new formal patch > review process. > > > > >-- Cheers! - Pratik http://m.onkey.org --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core-unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
Matthew Palmer
2007-Jul-20 01:50 UTC
Re: Verified tickets report resuscitated [was: http://dev.rubyonrails.org/ticket/8886]
On Fri, Jul 20, 2007 at 08:57:38AM +1000, Matthew Palmer wrote:> On Fri, Jul 20, 2007 at 10:35:32AM +1200, Michael Koziarski wrote: > > Could you guys please > > take some time to go through those patches and either: > > I''ll do a quick pass over them all to remove the keyword, I can''t guarantee > I''ll comment on them all, but I''ll see how I go...The list is clean from now back to #7300, so there''s 5 truly verified patches in the report now. It''s getting slower to review the further I go back as I''m checking that patches still apply and rebasing where I can. I could just go and check vote counts, though, if that would be preferred, and we can handle patch cleanliness later as we re-review tickets. What do others think would be best? - Matt -- A few minutes ago I attempted to give a flying fsck, but the best I could do was to watch it skitter across the floor. -- Anthony de Boer, ASR --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core-unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---