We''re inches away from pulling the trigger on RC2, which is the fast track (a few days, tops) to the final release. Please examine the latest from the branch and check if any of your pet blockers are still there. If so, shoot us a link to a ticket. So close now, so close. --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core-unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
On 27.12.2006, at 21.54, DHH wrote:> > We''re inches away from pulling the trigger on RC2, which is the fast > track (a few days, tops) to the final release. Please examine the > latest from the branch and check if any of your pet blockers are still > there. If so, shoot us a link to a ticket.I think this is one: http://dev.rubyonrails.org/ticket/6834 The bug was already fixed a while ago but I guess sneaked back in during some later commit. The bug is easy to spot and fix, but unfortunately there aren''t really tests for integration tests, so it needs a little manual testing. //jarkko -- Jarkko Laine http://jlaine.net http://dotherightthing.com http://www.railsecommerce.com http://odesign.fi
It would be nice if RC2 went out with this fix. http://dev.rubyonrails.org/ticket/6727 Thanks, Jonathan On Dec 27, 2006, at 12:54 PM, DHH wrote:> > We''re inches away from pulling the trigger on RC2, which is the fast > track (a few days, tops) to the final release. Please examine the > latest from the branch and check if any of your pet blockers are still > there. If so, shoot us a link to a ticket. > > So close now, so close. > > > >--~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core-unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
Really simple patch fixing a dynamic finder issue: http://dev.rubyonrails.org/ticket/6521 And a tiny documentation fix: http://dev.rubyonrails.org/ticket/6522 On Dec 27, 2006, at 1:54 PM, DHH wrote:> > We''re inches away from pulling the trigger on RC2, which is the fast > track (a few days, tops) to the final release. Please examine the > latest from the branch and check if any of your pet blockers are still > there. If so, shoot us a link to a ticket. > > So close now, so close.--~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core-unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
Any chance of 6618 or 6884? Both are pretty tiny and have tests. Thanks, Dan Powell dan@abakas.com On Dec 27, 2006, at 2:54 PM, DHH wrote:> > We''re inches away from pulling the trigger on RC2, which is the fast > track (a few days, tops) to the final release. Please examine the > latest from the branch and check if any of your pet blockers are still > there. If so, shoot us a link to a ticket. > > So close now, so close. > > > > >--~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core-unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
DHH wrote:> > We''re inches away from pulling the trigger on RC2, which is the fast > track (a few days, tops) to the final release. Please examine the > latest from the branch and check if any of your pet blockers are still > there. If so, shoot us a link to a ticket. > > So close now, so close. > > > > >http://dev.rubyonrails.org/ticket/6745 This ticket concerns the testing of partials returned by respond_to... format.js. I believe respond_to sets content type to js, and assert_select seems not to be able to deal with this (assuming anything returned with this content type must be RJS). So the only way to test this case (which is pretty common, I think) is to use assert_tag, which is not nice ... and deprecated. --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core-unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
http://dev.rubyonrails.org/ticket/6561 I''ve tried repeatedly to modify my code to *not* raise the error, but have been unsuccessful so far. I included a new patch as well which modified AR rather than AS. If it can be applied I''d be thrilled. V/r Anthony Eden On 12/27/06, Jonathan Younger <daikini@gmail.com> wrote:> > It would be nice if RC2 went out with this fix. > > http://dev.rubyonrails.org/ticket/6727 > > Thanks, > > Jonathan > > On Dec 27, 2006, at 12:54 PM, DHH wrote: > > > > > We''re inches away from pulling the trigger on RC2, which is the fast > > track (a few days, tops) to the final release. Please examine the > > latest from the branch and check if any of your pet blockers are still > > there. If so, shoot us a link to a ticket. > > > > So close now, so close. > > > > > > > > > > > >-- Cell: 808 782-5046 Current Location: Melbourne, FL --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core-unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
On 12/27/06, DHH <david.heinemeier@gmail.com> wrote:> > > We''re inches away from pulling the trigger on RC2, which is the fast > track (a few days, tops) to the final release. Please examine the > latest from the branch and check if any of your pet blockers are still > there. If so, shoot us a link to a ticket.http://dev.rubyonrails.org/ticket/6829 I''d love to see this RESTful routes test bug fixed. n. --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core-unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
Abdur-Rahman Advany
2006-Dec-27 21:26 UTC
Re: RC2 is imminent -- any last minute blockers?
I would like to see http://dev.rubyonrails.org/ticket/5050 fixed. Its really annoying but maybe a bit hard to fix.... I tried to call association.increment and association.decrement (after fetching it with reflection.name) inside the counter_cache after_create and before_destroy handlers but somehow they both don''t get called.... :( Nate Perry-Thistle wrote:> On 12/27/06, *DHH* <david.heinemeier@gmail.com > <mailto:david.heinemeier@gmail.com>> wrote: > > > We''re inches away from pulling the trigger on RC2, which is the fast > track (a few days, tops) to the final release. Please examine the > latest from the branch and check if any of your pet blockers are still > there. If so, shoot us a link to a ticket. > > > http://dev.rubyonrails.org/ticket/6829 > > I''d love to see this RESTful routes test bug fixed. > > n. > > > >--~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core-unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
Would be most happy to see fragment caching work with non-erb templates. http://dev.rubyonrails.org/ticket/6642 Tests are included. Thanks, Zsombor --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core-unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
Le 27 déc. 06 à 20:54, DHH a écrit :> We''re inches away from pulling the trigger on RC2, which is the fast > track (a few days, tops) to the final release. Please examine the > latest from the branch and check if any of your pet blockers are still > there. If so, shoot us a link to a ticket. > > So close now, so close.Hi, http://dev.rubyonrails.org/ticket/4668 is a big blocker to me. Jonathan Tron http://jonathan.tron.name --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core-unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
This would be nice: http://dev.rubyonrails.org/ticket/6380 -Jonathan. On 12/28/06, DHH <david.heinemeier@gmail.com> wrote:> > > We''re inches away from pulling the trigger on RC2, which is the fast > track (a few days, tops) to the final release. Please examine the > latest from the branch and check if any of your pet blockers are still > there. If so, shoot us a link to a ticket. > > So close now, so close. > > > > >--~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core-unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
> On 12/28/06, DHH <david.heinemeier@gmail.com> wrote: > We''re inches away from pulling the trigger on RC2, which is the fast > track (a few days, tops) to the final release. Please examine the > latest from the branch and check if any of your pet blockers are still > there. If so, shoot us a link to a ticket. >I would really appreciate http://dev.rubyonrails.org/ticket/4947 to be taken care of it''s been so long out -- Julian ''Julik'' Tarkhanov please send all personal mail to me at julik.nl --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core-unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
It would be great if we could get the changes from changesets 5604 and 5639 merged into the 1.2 branch. Mark -- Mark Van Holstyn mvanholstyn@gmail.com http://lotswholetime.com --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core-unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
DHH wrote:> > We''re inches away from pulling the trigger on RC2, which is the fast > track (a few days, tops) to the final release. Please examine the > latest from the branch and check if any of your pet blockers are still > there. If so, shoot us a link to a ticket. > > So close now, so close.It would be good if someone could take a look at ticket #4156 (http://dev.rubyonrails.org/ticket/4156). The change in revision 5622 (adding a Content-Length to all requests) has made WEBrick pretty much unusable for any request that starts with blank lines. Thanks, Phil --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core-unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
This also relates to the thread on "counter cache not working", but I would really like to see http://dev.rubyonrails.org/ticket/6896 (or something equivalent) included as soon as possible. We need it in order to make the better_nested_set plugin concurrency-safe. I tried overriding ActiveRecord::Base#update, but this broke before_update and related callbacks (at least the way I did it). Thanks for all the great work, Krishna --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core-unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
> This also relates to the thread on "counter cache not working", but I > would really like to see > http://dev.rubyonrails.org/ticket/6896 > (or something equivalent) included as soon as possible. We need it in > order to make the better_nested_set plugin concurrency-safe. I tried > overriding ActiveRecord::Base#update, but this broke before_update and > related callbacks (at least the way I did it).I''ve already commented in the other thread, we''re highly unlikely to make that change this close to release. See that thread for more info -- Cheers Koz --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core-unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
On Dec 27, 2006, at 1:54 PM, DHH wrote:> We''re inches away from pulling the trigger on RC2, which is the fast > track (a few days, tops) to the final release. Please examine the > latest from the branch and check if any of your pet blockers are still > there. If so, shoot us a link to a ticket.This patch fixes all but two unit test failures for the Sybase adapter (neither of which are critical). It only touches sybase_adapter.rb, plus a handful of test files, so it should have minimal impact. The patch also closes out #6878. http://dev.rubyonrails.org/ticket/6926 John -- "The Internet is not something you just dump something on. It''s not a big truck. It''s a series of tubes." --Senator Ted Stevens, R-AL John R. Sheets http://bark.metacasa.net --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core-unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---
How about applying the documentation patches before release? -- Thank you, Steven A Bristol stevenbristol@gmail.com On 1/4/07, John Sheets <metacasa@gmail.com> wrote:> > On Dec 27, 2006, at 1:54 PM, DHH wrote: > > We''re inches away from pulling the trigger on RC2, which is the fast > track (a few days, tops) to the final release. Please examine the > latest from the branch and check if any of your pet blockers are still > there. If so, shoot us a link to a ticket. > > > This patch fixes all but two unit test failures for the Sybase adapter > (neither of which are critical). It only touches sybase_adapter.rb, plus a > handful of test files, so it should have minimal impact. The patch also > closes out #6878. > > http://dev.rubyonrails.org/ticket/6926 > > John > > -- > "The Internet is not something you just dump something > on. It''s not a big truck. It''s a series of tubes." > --Senator Ted Stevens, R-AL > > John R. Sheets > http://bark.metacasa.net > > > > > >--~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com To unsubscribe from this group, send email to rubyonrails-core-unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en -~----------~----~----~----~------~----~------~--~---