Minor fix for rdmsrl
Signed-off-by: Liu Jinsong <jinsong.liu@intel.com>
diff -r d3ee3732acf3 xen/include/asm-x86/msr.h
--- a/xen/include/asm-x86/msr.h Thu Feb 28 08:05:15 2013 +0800
+++ b/xen/include/asm-x86/msr.h Thu Feb 28 08:15:17 2013 +0800
@@ -20,7 +20,7 @@
: "=a" (a__), "=d" (b__) \
: "c" (msr)); \
val = a__ | ((u64)b__<<32); \
-} while(0);
+} while(0)
#define wrmsr(msr,val1,val2) \
__asm__ __volatile__("wrmsr" \
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
>>> On 27.02.13 at 17:46, "Liu, Jinsong" <jinsong.liu@intel.com> wrote: > Minor fix for rdmsrl > > Signed-off-by: Liu Jinsong <jinsong.liu@intel.com>I applied this one, but could you clarify whether the stray semicolon caused any actual problem? I''m mainly asking to determine whether this needs backporting. Jan> --- a/xen/include/asm-x86/msr.h Thu Feb 28 08:05:15 2013 +0800 > +++ b/xen/include/asm-x86/msr.h Thu Feb 28 08:15:17 2013 +0800 > @@ -20,7 +20,7 @@ > : "=a" (a__), "=d" (b__) \ > : "c" (msr)); \ > val = a__ | ((u64)b__<<32); \ > -} while(0); > +} while(0) > > #define wrmsr(msr,val1,val2) \ > __asm__ __volatile__("wrmsr" \
Jan Beulich wrote:>>>> On 27.02.13 at 17:46, "Liu, Jinsong" <jinsong.liu@intel.com> >>>> wrote: Minor fix for rdmsrl >> >> Signed-off-by: Liu Jinsong <jinsong.liu@intel.com> > > I applied this one, but could you clarify whether the stray > semicolon caused any actual problem? I''m mainly asking to > determine whether this needs backporting. > > JanNo need backporting, just minor cleanup to drop unnecessary '';'' Thanks, Jinsong> >> --- a/xen/include/asm-x86/msr.h Thu Feb 28 08:05:15 2013 +0800 >> +++ b/xen/include/asm-x86/msr.h Thu Feb 28 08:15:17 2013 +0800 @@ >> -20,7 +20,7 @@ : "=a" (a__), "=d" (b__) \ >> : "c" (msr)); \ >> val = a__ | ((u64)b__<<32); \ >> -} while(0); >> +} while(0) >> >> #define wrmsr(msr,val1,val2) \ >> __asm__ __volatile__("wrmsr" \