Dario Faggioli
2013-Jan-30 14:31 UTC
[PATCH v2] xen: print "debug=y|n" during hypervisor startup
So that we can easily figure out whether or not we are running a debug build of Xen (e.g., via `xl dmesg''). Signed-off-by: Dario Faggioli <dario.faggioli@citrix.com> --- Changes from v1: * moved the #ifndef-ery around variable definition; * repositioned the "debug=%c" outside of the ''compiled-by'' section. diff --git a/xen/drivers/char/console.c b/xen/drivers/char/console.c --- a/xen/drivers/char/console.c +++ b/xen/drivers/char/console.c @@ -577,6 +577,11 @@ void __init console_init_preirq(void) { char *p; int sh; +#ifndef NDEBUG + char debug = ''y''; +#else + char debug = ''n''; +#endif serial_init_preirq(); @@ -608,10 +613,10 @@ void __init console_init_preirq(void) spin_lock(&console_lock); __putstr(xen_banner()); spin_unlock(&console_lock); - printk("Xen version %d.%d%s (%s@%s) (%s) %s\n", + printk("Xen version %d.%d%s (%s@%s) (%s) debug=%c %s\n", xen_major_version(), xen_minor_version(), xen_extra_version(), xen_compile_by(), xen_compile_domain(), - xen_compiler(), xen_compile_date()); + xen_compiler(), debug, xen_compile_date()); printk("Latest ChangeSet: %s\n", xen_changeset()); if ( opt_sync_console )
Konrad Rzeszutek Wilk
2013-Jan-30 21:38 UTC
Re: [PATCH v2] xen: print "debug=y|n" during hypervisor startup
On Wed, Jan 30, 2013 at 03:31:44PM +0100, Dario Faggioli wrote:> So that we can easily figure out whether or not we are running a > debug build of Xen (e.g., via `xl dmesg''). > > Signed-off-by: Dario Faggioli <dario.faggioli@citrix.com>Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>> --- > Changes from v1: > * moved the #ifndef-ery around variable definition; > * repositioned the "debug=%c" outside of the ''compiled-by'' section. > > diff --git a/xen/drivers/char/console.c b/xen/drivers/char/console.c > --- a/xen/drivers/char/console.c > +++ b/xen/drivers/char/console.c > @@ -577,6 +577,11 @@ void __init console_init_preirq(void) > { > char *p; > int sh; > +#ifndef NDEBUG > + char debug = ''y''; > +#else > + char debug = ''n''; > +#endif > > serial_init_preirq(); > > @@ -608,10 +613,10 @@ void __init console_init_preirq(void) > spin_lock(&console_lock); > __putstr(xen_banner()); > spin_unlock(&console_lock); > - printk("Xen version %d.%d%s (%s@%s) (%s) %s\n", > + printk("Xen version %d.%d%s (%s@%s) (%s) debug=%c %s\n", > xen_major_version(), xen_minor_version(), xen_extra_version(), > xen_compile_by(), xen_compile_domain(), > - xen_compiler(), xen_compile_date()); > + xen_compiler(), debug, xen_compile_date()); > printk("Latest ChangeSet: %s\n", xen_changeset()); > > if ( opt_sync_console ) > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > http://lists.xen.org/xen-devel >