Anthony PERARD
2012-Oct-05 14:49 UTC
[PATCH] libxl: Add a comment about NOGC usage with flexarray
Signed-off-by: Anthony PERARD <anthony.perard@citrix.com> --- tools/libxl/flexarray.h | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/tools/libxl/flexarray.h b/tools/libxl/flexarray.h index aade417..a1e8647 100644 --- a/tools/libxl/flexarray.h +++ b/tools/libxl/flexarray.h @@ -26,7 +26,13 @@ typedef struct flexarray { struct libxl__gc *gc; } flexarray_t; -_hidden flexarray_t *flexarray_make(struct libxl__gc *gc, int size, int autogrow); +/* + * NOGC can be used with flexarrays, but flexarray_free will need to be called + * to free the struct. The content of the flexarray will not be freed through + * flexarray_free. + */ +_hidden flexarray_t *flexarray_make(struct libxl__gc *gc_opt, + int size, int autogrow); _hidden void flexarray_free(flexarray_t *array); _hidden void flexarray_grow(flexarray_t *array, int extents); _hidden int flexarray_set(flexarray_t *array, unsigned int index, void *ptr); -- Anthony PERARD
Ian Jackson
2012-Oct-05 16:39 UTC
Re: [PATCH] libxl: Add a comment about NOGC usage with flexarray
Anthony PERARD writes ("[PATCH] libxl: Add a comment about NOGC usage with flexarray"):> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
Ian Campbell
2012-Oct-08 11:19 UTC
Re: [PATCH] libxl: Add a comment about NOGC usage with flexarray
On Fri, 2012-10-05 at 17:39 +0100, Ian Jackson wrote:> Anthony PERARD writes ("[PATCH] libxl: Add a comment about NOGC usage with flexarray"): > > Signed-off-by: Anthony PERARD <anthony.perard@citrix.com> > > Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>Applied, thanks.