All of the other "list" verbs are of the form "$noun-list".
For
example: "pci-list", "vcpu-list", "network-list",
"block-list", etc.
Additionally, many people have well trained muscle memory from years
of typing "xm li". "xl li" was ambiguous due to "xl
list-vm", thus
resulting in "command not implemented".
Finally, this command was missing from the xl man page.
Signed-off-by: Matt Wilson <msw@amazon.com>
Changes since v2:
* Document the command as showing only guests
Changes since v1:
* Add documentation
diff -r 32034d1914a6 -r a84d4165d5f8 docs/man/xl.pod.1
--- a/docs/man/xl.pod.1 Thu Jun 07 19:46:57 2012 +0100
+++ b/docs/man/xl.pod.1 Thu Jun 28 06:34:26 2012 +0000
@@ -617,6 +617,19 @@ different run state is appropriate. Pin
this, by ensuring certain VCPUs can only run on certain physical
CPUs.
+=item B<vm-list>
+
+Prints information about guests. This list excludes information about
+service or auxiliary domains such as dom0 and stubdoms.
+
+B<EXAMPLE>
+
+An example format for the list is as follows:
+
+UUID ID name
+59e1cf6c-6ab9-4879-90e7-adc8d1c63bf5 2 win
+50bc8f75-81d0-4d53-b2e6-95cb44e2682e 3 linux
+
=item B<vncviewer> [I<OPTIONS>] I<domain-id>
Attach to domain''s VNC server, forking a vncviewer process.
diff -r 32034d1914a6 -r a84d4165d5f8 tools/libxl/xl.h
--- a/tools/libxl/xl.h Thu Jun 07 19:46:57 2012 +0100
+++ b/tools/libxl/xl.h Thu Jun 28 06:34:26 2012 +0000
@@ -54,7 +54,7 @@ int main_destroy(int argc, char **argv);
int main_shutdown(int argc, char **argv);
int main_reboot(int argc, char **argv);
int main_list(int argc, char **argv);
-int main_list_vm(int argc, char **argv);
+int main_vm_list(int argc, char **argv);
int main_create(int argc, char **argv);
int main_config_update(int argc, char **argv);
int main_button_press(int argc, char **argv);
diff -r 32034d1914a6 -r a84d4165d5f8 tools/libxl/xl_cmdimpl.c
--- a/tools/libxl/xl_cmdimpl.c Thu Jun 07 19:46:57 2012 +0100
+++ b/tools/libxl/xl_cmdimpl.c Thu Jun 28 06:34:26 2012 +0000
@@ -3623,11 +3623,11 @@ int main_list(int argc, char **argv)
return 0;
}
-int main_list_vm(int argc, char **argv)
+int main_vm_list(int argc, char **argv)
{
int opt;
- if ((opt = def_getopt(argc, argv, "", "list-vm", 0)) !=
-1)
+ if ((opt = def_getopt(argc, argv, "", "vm-list", 0)) !=
-1)
return opt;
list_vm();
diff -r 32034d1914a6 -r a84d4165d5f8 tools/libxl/xl_cmdtable.c
--- a/tools/libxl/xl_cmdtable.c Thu Jun 07 19:46:57 2012 +0100
+++ b/tools/libxl/xl_cmdtable.c Thu Jun 28 06:34:26 2012 +0000
@@ -214,9 +214,9 @@ struct cmd_spec cmd_table[] = {
"Set the number of active VCPUs allowed for the domain",
"<Domain> <vCPUs>",
},
- { "list-vm",
- &main_list_vm, 0, 0,
- "List the VMs,without DOM0",
+ { "vm-list",
+ &main_vm_list, 0, 0,
+ "List guest domains, excluding dom0, stubdoms, etc.",
"",
},
{ "info",
Ian Jackson
2012-Jun-29 14:43 UTC
Re: [PATCH v3] xl: rename "list-vm" command to "vm-list"
Matt Wilson writes ("[Xen-devel] [PATCH v3] xl: rename "list-vm"
command to "vm-list""):> All of the other "list" verbs are of the form
"$noun-list". For
> example: "pci-list", "vcpu-list",
"network-list", "block-list", etc.
>
> Additionally, many people have well trained muscle memory from years
> of typing "xm li". "xl li" was ambiguous due to
"xl list-vm", thus
> resulting in "command not implemented".
>
> Finally, this command was missing from the xl man page.
>
> Signed-off-by: Matt Wilson <msw@amazon.com>
Thanks.
Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
Committed-by: Ian Jackson <ian.jackson@eu.citrix.com>