This only loosely coupled set of patches tries to consolidated various aspects for HPET related code. 1: disable before reboot or kexec 2: replace disabling of legacy broadcast 3: clear unwanted bits 4: use asm/hpet.h in HVM emulation code Signed-off-by: Jan Beulich <jbeulich@suse.com>
On 27/03/2012 11:44, "Jan Beulich" <JBeulich@suse.com> wrote:> This only loosely coupled set of patches tries to consolidated various > aspects for HPET related code. > > 1: disable before reboot or kexec > 2: replace disabling of legacy broadcast > 3: clear unwanted bits > 4: use asm/hpet.h in HVM emulation code > > Signed-off-by: Jan Beulich <jbeulich@suse.com>Whole series is Acked-by: Keir Fraser <keir@xen.org>> > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > http://lists.xen.org/xen-devel
>>> On 27.03.12 at 13:59, Keir Fraser <keir.xen@gmail.com> wrote: > On 27/03/2012 11:44, "Jan Beulich" <JBeulich@suse.com> wrote: > >> This only loosely coupled set of patches tries to consolidated various >> aspects for HPET related code. >> >> 1: disable before reboot or kexec >> 2: replace disabling of legacy broadcast >> 3: clear unwanted bits >> 4: use asm/hpet.h in HVM emulation code >> >> Signed-off-by: Jan Beulich <jbeulich@suse.com> > > Whole series is > Acked-by: Keir Fraser <keir@xen.org>Thanks, committed. However - any thoughts on how to deal with unknown bits set in the configuration registers? (I also just sent the same question to the Linux guys.) Jan
On 27/03/2012 14:27, "Jan Beulich" <JBeulich@suse.com> wrote:>>> 1: disable before reboot or kexec >>> 2: replace disabling of legacy broadcast >>> 3: clear unwanted bits >>> 4: use asm/hpet.h in HVM emulation code >>> >>> Signed-off-by: Jan Beulich <jbeulich@suse.com> >> >> Whole series is >> Acked-by: Keir Fraser <keir@xen.org> > > Thanks, committed. However - any thoughts on how to deal with > unknown bits set in the configuration registers? (I also just sent > the same question to the Linux guys.)Not really. Warn on them and zero them?
>>> On 27.03.12 at 17:39, Keir Fraser <keir@xen.org> wrote: > On 27/03/2012 14:27, "Jan Beulich" <JBeulich@suse.com> wrote: > >>>> 1: disable before reboot or kexec >>>> 2: replace disabling of legacy broadcast >>>> 3: clear unwanted bits >>>> 4: use asm/hpet.h in HVM emulation code >>>> >>>> Signed-off-by: Jan Beulich <jbeulich@suse.com> >>> >>> Whole series is >>> Acked-by: Keir Fraser <keir@xen.org> >> >> Thanks, committed. However - any thoughts on how to deal with >> unknown bits set in the configuration registers? (I also just sent >> the same question to the Linux guys.) > > Not really. Warn on them and zero them?Thomas Gleixner wants Linux to just warn - retaining the bits and clearing them is imo equally dangerous, so I''d be fine with clearing them in Xen to find out (at some point in the distant future, if ever) which approach is marginally better. Jan