Xen devel - Mar 2012 - [PATCH 07/07] HVM firmware passthrough: Xen control tools support

Xen control tools support for loading the firmware pass through
modules during domain construction. The modules are passed
in using the new xc_hvm_build_args structure. The modules
are read and loaded into the new domain address space behind
hvmloader. The base address for the module set is passed to
the hvmloader in ECX:EDX.

Signed-off-by: Ross Philipson <ross.philipson@citrix.com>



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

On Mon, 2012-03-19 at 22:04 +0000, Ross Philipson wrote:
> diff -r e87559f0de44 tools/libxc/xenguest.h
> --- a/tools/libxc/xenguest.h    Mon Mar 19 16:57:55 2012 -0400
> +++ b/tools/libxc/xenguest.h    Mon Mar 19 17:02:33 2012 -0400
> @@ -176,6 +176,8 @@ struct xc_hvm_build_args {
>      uint64_t mem_target;         /* Memory target in bytes. */
>      uint64_t mmio_size;          /* Size of the MMIO hole in bytes.
> */
>      const char *image_file_name; /* File name of the image to load.
> */
> +    const char **module_names;   /* List of HVM module files to load.
> */
> +    uint32_t module_count;       /* Count of HVM modules. */
>  };
Why files rather than pointers to data in memory? A pointer would be
easier if you wanted to construct a table on the fly and you could still
provide a helper function for the caller to load a file too.

Ian.

> -----Original Message-----
> From: Ian Campbell
> Sent: Wednesday, April 04, 2012 5:33 AM
> To: Ross Philipson
> Cc: xen-devel@lists.xensource.com
> Subject: Re: [Xen-devel] [PATCH 07/07] HVM firmware passthrough: Xen
> control tools support
> 
> On Mon, 2012-03-19 at 22:04 +0000, Ross Philipson wrote:
> > diff -r e87559f0de44 tools/libxc/xenguest.h
> > --- a/tools/libxc/xenguest.h    Mon Mar 19 16:57:55 2012 -0400
> > +++ b/tools/libxc/xenguest.h    Mon Mar 19 17:02:33 2012 -0400
> > @@ -176,6 +176,8 @@ struct xc_hvm_build_args {
> >      uint64_t mem_target;         /* Memory target in bytes. */
> >      uint64_t mmio_size;          /* Size of the MMIO hole in bytes.
> > */
> >      const char *image_file_name; /* File name of the image to load.
> > */
> > +    const char **module_names;   /* List of HVM module files to load.
> > */
> > +    uint32_t module_count;       /* Count of HVM modules. */
> >  };
> 
> Why files rather than pointers to data in memory? A pointer would be
> easier if you wanted to construct a table on the fly and you could still
> provide a helper function for the caller to load a file too.
> 
> Ian.
I only did files because the hvmloader image was passed in that way (so for
consistency). I am fine with passing in blobs and it fits better with what we
are discussing in the 00/07 thread.

Ross