# HG changeset patch # User Roger Pau Monne <roger.pau@entel.upc.edu> # Date 1329801384 -3600 # Node ID 0ab0491f2819fc8440da323d1bb0fa5534450b35 # Parent c2f0820e48ae9cf0735c5ef81e6a6796f3d42e5a autoconf: remove brctl check Remove brctl check since it''s usually only available to users with high privileges, but Xen should be buildable by regular users. Signed-off-by: Roger Pau Monne <roger.pau@entel.upc.edu> diff -r c2f0820e48ae -r 0ab0491f2819 tools/configure.ac --- a/tools/configure.ac Tue Feb 21 04:18:29 2012 +0100 +++ b/tools/configure.ac Tue Feb 21 06:16:24 2012 +0100 @@ -79,7 +79,6 @@ AC_PROG_LN_S AC_PROG_MAKE_SET AC_PROG_INSTALL AX_PATH_PROG_OR_FAIL([PERL], [perl]) -AX_PATH_PROG_OR_FAIL([BRCTL], [brctl]) AX_PATH_PROG_OR_FAIL([IP], [ip]) AX_PATH_PROG_OR_FAIL([BISON], [bison]) AX_PATH_PROG_OR_FAIL([FLEX], [flex])
flight 12007 xen-unstable real [real]
http://www.chiark.greenend.org.uk/~xensrcts/logs/12007/
Regressions :-(
Tests which did not succeed and are blocking,
including tests which could not be run:
build-i386-oldkern 4 xen-build fail REGR. vs. 12003
build-i386 4 xen-build fail REGR. vs. 12003
build-amd64 4 xen-build fail REGR. vs. 12003
build-amd64-oldkern 4 xen-build fail REGR. vs. 12003
Tests which did not succeed, but are not blocking:
test-amd64-amd64-xl-qemuu-winxpsp3 1 xen-build-check(1) blocked n/a
test-amd64-amd64-xl-qemuu-win7-amd64 1 xen-build-check(1) blocked n/a
test-i386-i386-xl-qemuu-winxpsp3 1 xen-build-check(1) blocked n/a
test-amd64-i386-qemuu-rhel6hvm-intel 1 xen-build-check(1) blocked n/a
test-amd64-amd64-xl-pcipt-intel 1 xen-build-check(1) blocked n/a
test-amd64-i386-rhel6hvm-amd 1 xen-build-check(1) blocked n/a
test-amd64-i386-rhel6hvm-intel 1 xen-build-check(1) blocked n/a
test-amd64-i386-qemuu-rhel6hvm-amd 1 xen-build-check(1) blocked n/a
test-amd64-i386-pv 1 xen-build-check(1) blocked n/a
test-i386-i386-xl 1 xen-build-check(1) blocked n/a
test-amd64-i386-xl 1 xen-build-check(1) blocked n/a
test-amd64-amd64-xl 1 xen-build-check(1) blocked n/a
test-amd64-amd64-xl-sedf 1 xen-build-check(1) blocked n/a
test-amd64-amd64-pair 1 xen-build-check(1) blocked n/a
test-amd64-i386-pair 1 xen-build-check(1) blocked n/a
test-amd64-amd64-pv 1 xen-build-check(1) blocked n/a
test-amd64-i386-xl-winxpsp3-vcpus1 1 xen-build-check(1) blocked n/a
test-amd64-i386-xend-winxpsp3 1 xen-build-check(1) blocked n/a
test-amd64-amd64-win 1 xen-build-check(1) blocked n/a
test-amd64-i386-xl-win7-amd64 1 xen-build-check(1) blocked n/a
test-amd64-i386-xl-win-vcpus1 1 xen-build-check(1) blocked n/a
test-amd64-amd64-xl-sedf-pin 1 xen-build-check(1) blocked n/a
test-i386-i386-pv 1 xen-build-check(1) blocked n/a
test-amd64-i386-xl-credit2 1 xen-build-check(1) blocked n/a
test-amd64-i386-xl-multivcpu 1 xen-build-check(1) blocked n/a
test-amd64-i386-win-vcpus1 1 xen-build-check(1) blocked n/a
test-amd64-amd64-xl-winxpsp3 1 xen-build-check(1) blocked n/a
test-i386-i386-xl-winxpsp3 1 xen-build-check(1) blocked n/a
test-amd64-i386-win 1 xen-build-check(1) blocked n/a
test-amd64-amd64-xl-win7-amd64 1 xen-build-check(1) blocked n/a
test-i386-i386-pair 1 xen-build-check(1) blocked n/a
test-amd64-amd64-xl-win 1 xen-build-check(1) blocked n/a
test-i386-i386-win 1 xen-build-check(1) blocked n/a
test-i386-i386-xl-win 1 xen-build-check(1) blocked n/a
version targeted for testing:
xen 8ee81ceda8c9
baseline version:
xen a88ba599add1
------------------------------------------------------------
People who touched revisions under test:
Bamvor Jian Zhang <bjzhang@suse.com>
George Dunlap <george.dunlap@eu.citrix.com>
Ian Jackson <ian.jackson@eu.citrix.com>
Jean Guyader <jean.guyader@eu.citrix.com>
Roger Pau Monne <roger.pau@entel.upc.edu>
------------------------------------------------------------
jobs:
build-amd64 fail
build-i386 fail
build-amd64-oldkern fail
build-i386-oldkern fail
build-amd64-pvops pass
build-i386-pvops pass
test-amd64-amd64-xl blocked
test-amd64-i386-xl blocked
test-i386-i386-xl blocked
test-amd64-i386-rhel6hvm-amd blocked
test-amd64-i386-qemuu-rhel6hvm-amd blocked
test-amd64-amd64-xl-qemuu-win7-amd64 blocked
test-amd64-amd64-xl-win7-amd64 blocked
test-amd64-i386-xl-win7-amd64 blocked
test-amd64-i386-xl-credit2 blocked
test-amd64-amd64-xl-pcipt-intel blocked
test-amd64-i386-rhel6hvm-intel blocked
test-amd64-i386-qemuu-rhel6hvm-intel blocked
test-amd64-i386-xl-multivcpu blocked
test-amd64-amd64-pair blocked
test-amd64-i386-pair blocked
test-i386-i386-pair blocked
test-amd64-amd64-xl-sedf-pin blocked
test-amd64-amd64-pv blocked
test-amd64-i386-pv blocked
test-i386-i386-pv blocked
test-amd64-amd64-xl-sedf blocked
test-amd64-i386-win-vcpus1 blocked
test-amd64-i386-xl-win-vcpus1 blocked
test-amd64-i386-xl-winxpsp3-vcpus1 blocked
test-amd64-amd64-win blocked
test-amd64-i386-win blocked
test-i386-i386-win blocked
test-amd64-amd64-xl-win blocked
test-i386-i386-xl-win blocked
test-amd64-amd64-xl-qemuu-winxpsp3 blocked
test-i386-i386-xl-qemuu-winxpsp3 blocked
test-amd64-i386-xend-winxpsp3 blocked
test-amd64-amd64-xl-winxpsp3 blocked
test-i386-i386-xl-winxpsp3 blocked
------------------------------------------------------------
sg-report-flight on woking.cam.xci-test.com
logs: /home/xc_osstest/logs
images: /home/xc_osstest/images
Logs, config files, etc. are available at
http://www.chiark.greenend.org.uk/~xensrcts/logs
Test harness code can be found at
http://xenbits.xensource.com/gitweb?p=osstest.git;a=summary
Not pushing.
------------------------------------------------------------
changeset: 24861:8ee81ceda8c9
tag: tip
user: Ian Jackson <ian.jackson@eu.citrix.com>
date: Wed Feb 22 01:55:04 2012 +0000
.gitignore: add autoconf-related files
Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
Committed-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
changeset: 24860:a19c6d90fd41
user: Ian Jackson <ian.jackson@eu.citrix.com>
date: Wed Feb 22 01:55:03 2012 +0000
build: add autoconf to replace custom checks in tools/check
Added autotools magic to replace custom check scripts. The previous
checks have been ported to autoconf, and some additional ones have
been added (plus the suggestions from running autoscan). Two files are
created as a result from executing configure script, config/Tools.mk
and config.h.
conf/Tools.mk is included by tools/Rules.mk, and contains most of the
options previously defined in .config, that can now be set passing
parameters or defining environment variables when executing configure
script.
config.h is only used by libxl/xl to detect yajl_version.h.
[ tools/config.sub and config.guess copied from
autotools-dev 20100122.1 from Debian squeeze i386,
which is GPLv2.
tools/configure generated using the included ./autogen.sh
which ran autoconf 2.67-2 from Debian squeeze i386. autoconf
is GPLv3+ but has a special exception for the autoconf output;
this exception applies to us and exempts us from complying
with GPLv3+ for configure, which is good as Xen is GPL2 only.
- Ian Jackson ]
Signed-off-by: Roger Pau Monne <roger.pau@entel.upc.edu>
Tested-by: Ian Jackson <ian.jackson@eu.citrix.com>
Committed-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
changeset: 24859:6a34a42a2b5d
user: Bamvor Jian Zhang <bjzhang@suse.com>
date: Tue Feb 21 18:01:04 2012 +0000
libxl: Export libxl_event.h
This fixes a compile error in libvirt.
Signed-off-by: Bamvor Jian Zhang <bjzhang@suse.com>
Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
Committed-by: Ian Jackson <ian.jackson@eu.citrix.com>
changeset: 24858:a88ba599add1
user: George Dunlap <george.dunlap@eu.citrix.com>
date: Tue Feb 21 17:45:59 2012 +0000
libxl: cleanup: Remove pointless ERRNOVAL
Just call LIBXL__LOG rather than passing a meaningless ERRNOVAL.
Signed-off-by: George Dunlap <george.dunlap@eu.citrix.com>
Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
Committed-by: Ian Jackson <ian.jackson@eu.citrix.com>
=======================================commit
128de2549c5f24e4a437b86bd2e46f023976d50a
Author: Jean Guyader <jean.guyader@eu.citrix.com>
Date: Mon Feb 20 16:21:47 2012 +0000
Intel GPU passthrough: Host bridge config space
Expose more host bridge config space value to make the driver happy
for all the different revisions of the device.
Signed-off-by: Jean Guyader <jean.guyader@eu.citrix.com>
2012/2/22 xen.org <ian.jackson@eu.citrix.com>:> flight 12007 xen-unstable real [real] > http://www.chiark.greenend.org.uk/~xensrcts/logs/12007/ > > Regressions :-( > > Tests which did not succeed and are blocking, > including tests which could not be run: > build-i386-oldkern 4 xen-build fail REGR. vs. 12003 > build-i386 4 xen-build fail REGR. vs. 12003 > build-amd64 4 xen-build fail REGR. vs. 12003 > build-amd64-oldkern 4 xen-build fail REGR. vs. 12003brctl is not installed, or the user that is trying to build Xen doesn't have permissions to run it. I've found this test quite useless, because you should be able to build Xen as a regular user, that doesn't have access to brctl, do you want me to send a patch that removes this check?> Tests which did not succeed, but are not blocking: > test-amd64-amd64-xl-qemuu-winxpsp3 1 xen-build-check(1) blocked n/a > test-amd64-amd64-xl-qemuu-win7-amd64 1 xen-build-check(1) blocked n/a > test-i386-i386-xl-qemuu-winxpsp3 1 xen-build-check(1) blocked n/a > test-amd64-i386-qemuu-rhel6hvm-intel 1 xen-build-check(1) blocked n/a > test-amd64-amd64-xl-pcipt-intel 1 xen-build-check(1) blocked n/a > test-amd64-i386-rhel6hvm-amd 1 xen-build-check(1) blocked n/a > test-amd64-i386-rhel6hvm-intel 1 xen-build-check(1) blocked n/a > test-amd64-i386-qemuu-rhel6hvm-amd 1 xen-build-check(1) blocked n/a > test-amd64-i386-pv 1 xen-build-check(1) blocked n/a > test-i386-i386-xl 1 xen-build-check(1) blocked n/a > test-amd64-i386-xl 1 xen-build-check(1) blocked n/a > test-amd64-amd64-xl 1 xen-build-check(1) blocked n/a > test-amd64-amd64-xl-sedf 1 xen-build-check(1) blocked n/a > test-amd64-amd64-pair 1 xen-build-check(1) blocked n/a > test-amd64-i386-pair 1 xen-build-check(1) blocked n/a > test-amd64-amd64-pv 1 xen-build-check(1) blocked n/a > test-amd64-i386-xl-winxpsp3-vcpus1 1 xen-build-check(1) blocked n/a > test-amd64-i386-xend-winxpsp3 1 xen-build-check(1) blocked n/a > test-amd64-amd64-win 1 xen-build-check(1) blocked n/a > test-amd64-i386-xl-win7-amd64 1 xen-build-check(1) blocked n/a > test-amd64-i386-xl-win-vcpus1 1 xen-build-check(1) blocked n/a > test-amd64-amd64-xl-sedf-pin 1 xen-build-check(1) blocked n/a > test-i386-i386-pv 1 xen-build-check(1) blocked n/a > test-amd64-i386-xl-credit2 1 xen-build-check(1) blocked n/a > test-amd64-i386-xl-multivcpu 1 xen-build-check(1) blocked n/a > test-amd64-i386-win-vcpus1 1 xen-build-check(1) blocked n/a > test-amd64-amd64-xl-winxpsp3 1 xen-build-check(1) blocked n/a > test-i386-i386-xl-winxpsp3 1 xen-build-check(1) blocked n/a > test-amd64-i386-win 1 xen-build-check(1) blocked n/a > test-amd64-amd64-xl-win7-amd64 1 xen-build-check(1) blocked n/a > test-i386-i386-pair 1 xen-build-check(1) blocked n/a > test-amd64-amd64-xl-win 1 xen-build-check(1) blocked n/a > test-i386-i386-win 1 xen-build-check(1) blocked n/a > test-i386-i386-xl-win 1 xen-build-check(1) blocked n/a > > version targeted for testing: > xen 8ee81ceda8c9 > baseline version: > xen a88ba599add1 > > ------------------------------------------------------------ > People who touched revisions under test: > Bamvor Jian Zhang <bjzhang@suse.com> > George Dunlap <george.dunlap@eu.citrix.com> > Ian Jackson <ian.jackson@eu.citrix.com> > Jean Guyader <jean.guyader@eu.citrix.com> > Roger Pau Monne <roger.pau@entel.upc.edu> > ------------------------------------------------------------ > > jobs: > build-amd64 fail > build-i386 fail > build-amd64-oldkern fail > build-i386-oldkern fail > build-amd64-pvops pass > build-i386-pvops pass > test-amd64-amd64-xl blocked > test-amd64-i386-xl blocked > test-i386-i386-xl blocked > test-amd64-i386-rhel6hvm-amd blocked > test-amd64-i386-qemuu-rhel6hvm-amd blocked > test-amd64-amd64-xl-qemuu-win7-amd64 blocked > test-amd64-amd64-xl-win7-amd64 blocked > test-amd64-i386-xl-win7-amd64 blocked > test-amd64-i386-xl-credit2 blocked > test-amd64-amd64-xl-pcipt-intel blocked > test-amd64-i386-rhel6hvm-intel blocked > test-amd64-i386-qemuu-rhel6hvm-intel blocked > test-amd64-i386-xl-multivcpu blocked > test-amd64-amd64-pair blocked > test-amd64-i386-pair blocked > test-i386-i386-pair blocked > test-amd64-amd64-xl-sedf-pin blocked > test-amd64-amd64-pv blocked > test-amd64-i386-pv blocked > test-i386-i386-pv blocked > test-amd64-amd64-xl-sedf blocked > test-amd64-i386-win-vcpus1 blocked > test-amd64-i386-xl-win-vcpus1 blocked > test-amd64-i386-xl-winxpsp3-vcpus1 blocked > test-amd64-amd64-win blocked > test-amd64-i386-win blocked > test-i386-i386-win blocked > test-amd64-amd64-xl-win blocked > test-i386-i386-xl-win blocked > test-amd64-amd64-xl-qemuu-winxpsp3 blocked > test-i386-i386-xl-qemuu-winxpsp3 blocked > test-amd64-i386-xend-winxpsp3 blocked > test-amd64-amd64-xl-winxpsp3 blocked > test-i386-i386-xl-winxpsp3 blocked > > > ------------------------------------------------------------ > sg-report-flight on woking.cam.xci-test.com > logs: /home/xc_osstest/logs > images: /home/xc_osstest/images > > Logs, config files, etc. are available at > http://www.chiark.greenend.org.uk/~xensrcts/logs > > Test harness code can be found at > http://xenbits.xensource.com/gitweb?p=osstest.git;a=summary > > > Not pushing. > > ------------------------------------------------------------ > changeset: 24861:8ee81ceda8c9 > tag: tip > user: Ian Jackson <ian.jackson@eu.citrix.com> > date: Wed Feb 22 01:55:04 2012 +0000 > > .gitignore: add autoconf-related files > > Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com> > Committed-by: Ian Jackson <Ian.Jackson@eu.citrix.com> > > > changeset: 24860:a19c6d90fd41 > user: Ian Jackson <ian.jackson@eu.citrix.com> > date: Wed Feb 22 01:55:03 2012 +0000 > > build: add autoconf to replace custom checks in tools/check > > Added autotools magic to replace custom check scripts. The previous > checks have been ported to autoconf, and some additional ones have > been added (plus the suggestions from running autoscan). Two files are > created as a result from executing configure script, config/Tools.mk > and config.h. > > conf/Tools.mk is included by tools/Rules.mk, and contains most of the > options previously defined in .config, that can now be set passing > parameters or defining environment variables when executing configure > script. > > config.h is only used by libxl/xl to detect yajl_version.h. > > [ tools/config.sub and config.guess copied from > autotools-dev 20100122.1 from Debian squeeze i386, > which is GPLv2. > > tools/configure generated using the included ./autogen.sh > which ran autoconf 2.67-2 from Debian squeeze i386. autoconf > is GPLv3+ but has a special exception for the autoconf output; > this exception applies to us and exempts us from complying > with GPLv3+ for configure, which is good as Xen is GPL2 only. > > - Ian Jackson ] > > Signed-off-by: Roger Pau Monne <roger.pau@entel.upc.edu> > Tested-by: Ian Jackson <ian.jackson@eu.citrix.com> > Committed-by: Ian Jackson <Ian.Jackson@eu.citrix.com> > > > changeset: 24859:6a34a42a2b5d > user: Bamvor Jian Zhang <bjzhang@suse.com> > date: Tue Feb 21 18:01:04 2012 +0000 > > libxl: Export libxl_event.h > > This fixes a compile error in libvirt. > > Signed-off-by: Bamvor Jian Zhang <bjzhang@suse.com> > Acked-by: Ian Jackson <ian.jackson@eu.citrix.com> > Committed-by: Ian Jackson <ian.jackson@eu.citrix.com> > > > changeset: 24858:a88ba599add1 > user: George Dunlap <george.dunlap@eu.citrix.com> > date: Tue Feb 21 17:45:59 2012 +0000 > > libxl: cleanup: Remove pointless ERRNOVAL > > Just call LIBXL__LOG rather than passing a meaningless ERRNOVAL. > > Signed-off-by: George Dunlap <george.dunlap@eu.citrix.com> > Acked-by: Ian Jackson <ian.jackson@eu.citrix.com> > Committed-by: Ian Jackson <ian.jackson@eu.citrix.com> > > > =======================================> commit 128de2549c5f24e4a437b86bd2e46f023976d50a > Author: Jean Guyader <jean.guyader@eu.citrix.com> > Date: Mon Feb 20 16:21:47 2012 +0000 > > Intel GPU passthrough: Host bridge config space > > Expose more host bridge config space value to make the driver happy > for all the different revisions of the device. > > Signed-off-by: Jean Guyader <jean.guyader@eu.citrix.com> > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > http://lists.xen.org/xen-devel_______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
On Wed, 2012-02-22 at 09:20 +0000, Roger Pau Monné wrote:> 2012/2/22 xen.org <ian.jackson@eu.citrix.com>: > > flight 12007 xen-unstable real [real] > > http://www.chiark.greenend.org.uk/~xensrcts/logs/12007/ > > > > Regressions :-( > > > > Tests which did not succeed and are blocking, > > including tests which could not be run: > > build-i386-oldkern 4 xen-build fail REGR. vs. 12003 > > build-i386 4 xen-build fail REGR. vs. 12003 > > build-amd64 4 xen-build fail REGR. vs. 12003 > > build-amd64-oldkern 4 xen-build fail REGR. vs. 12003 > > > brctl is not installed, or the user that is trying to build Xen > doesn't have permissions to run it. I've found this test quite > useless, because you should be able to build Xen as a regular user, > that doesn't have access to brctl, do you want me to send a patch that > removes this check?I build Xen on a machine which doesn't actually run Xen and therefore doesn't have brctl installed, I don't think this is unreasonable since brctl is a runtime not compile-time dependency. I think we should remove the test from configure -- although it does make me wonder (perhaps too late) if we shouldn't have kept the existing install time checks. Ian. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
2012/2/22 Ian Campbell <Ian.Campbell@citrix.com>:> On Wed, 2012-02-22 at 09:20 +0000, Roger Pau Monné wrote: >> 2012/2/22 xen.org <ian.jackson@eu.citrix.com>: >> > flight 12007 xen-unstable real [real] >> > http://www.chiark.greenend.org.uk/~xensrcts/logs/12007/ >> > >> > Regressions :-( >> > >> > Tests which did not succeed and are blocking, >> > including tests which could not be run: >> > build-i386-oldkern 4 xen-build fail REGR. vs. 12003 >> > build-i386 4 xen-build fail REGR. vs. 12003 >> > build-amd64 4 xen-build fail REGR. vs. 12003 >> > build-amd64-oldkern 4 xen-build fail REGR. vs. 12003 >> >> >> brctl is not installed, or the user that is trying to build Xen >> doesn't have permissions to run it. I've found this test quite >> useless, because you should be able to build Xen as a regular user, >> that doesn't have access to brctl, do you want me to send a patch that >> removes this check? > > I build Xen on a machine which doesn't actually run Xen and therefore > doesn't have brctl installed, I don't think this is unreasonable since > brctl is a runtime not compile-time dependency. > > I think we should remove the test from configure -- although it does > make me wonder (perhaps too late) if we shouldn't have kept the existing > install time checks.I've submitted a patch that should fix that. I'm afraid that removing the brctl/brconfig check will bring trouble, because this is used in hotplug scripts and errors on hotplug scripts are hard to spot right now for regular users.> Ian. > >_______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
On Wed, 2012-02-22 at 09:54 +0000, Ian Campbell wrote:> On Wed, 2012-02-22 at 09:20 +0000, Roger Pau Monné wrote: > > 2012/2/22 xen.org <ian.jackson@eu.citrix.com>: > > > flight 12007 xen-unstable real [real] > > > http://www.chiark.greenend.org.uk/~xensrcts/logs/12007/ > > > > > > Regressions :-( > > > > > > Tests which did not succeed and are blocking, > > > including tests which could not be run: > > > build-i386-oldkern 4 xen-build fail REGR. vs. 12003 > > > build-i386 4 xen-build fail REGR. vs. 12003 > > > build-amd64 4 xen-build fail REGR. vs. 12003 > > > build-amd64-oldkern 4 xen-build fail REGR. vs. 12003 > > > > > > brctl is not installed, or the user that is trying to build Xen > > doesn't have permissions to run it. I've found this test quite > > useless, because you should be able to build Xen as a regular user, > > that doesn't have access to brctl, do you want me to send a patch that > > removes this check? > > I build Xen on a machine which doesn't actually run Xen and therefore > doesn't have brctl installed, I don't think this is unreasonable since > brctl is a runtime not compile-time dependency.I also had to specify UDEVADM on the configure line (I suspect because it is not in $PATH for regular users). The first time I did so I gave the wrong path: $ UDEVADM=/usr/sbin/udevadm ./configure [...] checking for udevadm... /usr/sbin/udevadm ./configure: line 6484: /usr/sbin/udevadm: No such file or directory ./configure: line 6486: test: -lt: unary operator expected If we think this check should be kept then it needs to learn to check for things in paths other than $PATH and also have the error handling fixed. With this and removing the brctl check I was able to run configure successfully. Ian. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
On Wed, 2012-02-22 at 10:04 +0000, Roger Pau Monné wrote:> 2012/2/22 Ian Campbell <Ian.Campbell@citrix.com>: > > On Wed, 2012-02-22 at 09:20 +0000, Roger Pau Monné wrote: > >> 2012/2/22 xen.org <ian.jackson@eu.citrix.com>: > >> > flight 12007 xen-unstable real [real] > >> > http://www.chiark.greenend.org.uk/~xensrcts/logs/12007/ > >> > > >> > Regressions :-( > >> > > >> > Tests which did not succeed and are blocking, > >> > including tests which could not be run: > >> > build-i386-oldkern 4 xen-build fail REGR. vs. 12003 > >> > build-i386 4 xen-build fail REGR. vs. 12003 > >> > build-amd64 4 xen-build fail REGR. vs. 12003 > >> > build-amd64-oldkern 4 xen-build fail REGR. vs. 12003 > >> > >> > >> brctl is not installed, or the user that is trying to build Xen > >> doesn't have permissions to run it. I've found this test quite > >> useless, because you should be able to build Xen as a regular user, > >> that doesn't have access to brctl, do you want me to send a patch that > >> removes this check? > > > > I build Xen on a machine which doesn't actually run Xen and therefore > > doesn't have brctl installed, I don't think this is unreasonable since > > brctl is a runtime not compile-time dependency. > > > > I think we should remove the test from configure -- although it does > > make me wonder (perhaps too late) if we shouldn't have kept the existing > > install time checks. > > I've submitted a patch that should fix that. I'm afraid that removing > the brctl/brconfig check will bring trouble, because this is used in > hotplug scripts and errors on hotplug scripts are hard to spot right > now for regular users.This is why I am concerned that we have removed the install time as well as the development time checks... Perhaps we should move these new checks to a second configure script which can be run at install time and produces as its output just a pass or fail? Ian. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
2012/2/22 Ian Campbell <Ian.Campbell@citrix.com>:> On Wed, 2012-02-22 at 09:54 +0000, Ian Campbell wrote: >> On Wed, 2012-02-22 at 09:20 +0000, Roger Pau Monné wrote: >> > 2012/2/22 xen.org <ian.jackson@eu.citrix.com>: >> > > flight 12007 xen-unstable real [real] >> > > http://www.chiark.greenend.org.uk/~xensrcts/logs/12007/ >> > > >> > > Regressions :-( >> > > >> > > Tests which did not succeed and are blocking, >> > > including tests which could not be run: >> > > build-i386-oldkern 4 xen-build fail REGR. vs. 12003 >> > > build-i386 4 xen-build fail REGR. vs. 12003 >> > > build-amd64 4 xen-build fail REGR. vs. 12003 >> > > build-amd64-oldkern 4 xen-build fail REGR. vs. 12003 >> > >> > >> > brctl is not installed, or the user that is trying to build Xen >> > doesn't have permissions to run it. I've found this test quite >> > useless, because you should be able to build Xen as a regular user, >> > that doesn't have access to brctl, do you want me to send a patch that >> > removes this check? >> >> I build Xen on a machine which doesn't actually run Xen and therefore >> doesn't have brctl installed, I don't think this is unreasonable since >> brctl is a runtime not compile-time dependency. > > I also had to specify UDEVADM on the configure line (I suspect because > it is not in $PATH for regular users). The first time I did so I gave > the wrong path: > $ UDEVADM=/usr/sbin/udevadm ./configure > [...] > checking for udevadm... /usr/sbin/udevadm > ./configure: line 6484: /usr/sbin/udevadm: No such file or directory > ./configure: line 6486: test: -lt: unary operator expected > > If we think this check should be kept then it needs to learn to check > for things in paths other than $PATH and also have the error handling > fixed.It's the same as the brctl check I think, and I will also send a patch to remove this while I work on a way to create a simple install test also.> With this and removing the brctl check I was able to run configure > successfully. > > Ian. > >_______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
Roger Pau Monne writes ("[PATCH] autoconf: remove brctl
check"):> autoconf: remove brctl check
>
> Remove brctl check since it''s usually only available to users with
> high privileges, but Xen should be buildable by regular users.
Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
Committed-by: Ian Jackson <ian.jackson@eu.citrix.com>
Ian Campbell writes ("Re: [Xen-devel] [xen-unstable test] 12007:
regressions - FAIL"):> This is why I am concerned that we have removed the install time as well
> as the development time checks...
This is a legitimate concern but these checks should definitely not be
in the configure script, so I''ve applied Roger''s patches to
remove
them.
> Perhaps we should move these new checks to a second configure script
> which can be run at install time and produces as its output just a pass
> or fail?
Roger Pau Monn writes ("Re: [Xen-devel] [xen-unstable test] 12007:
regressions - FAIL"):> I''ve submitted a patch that should fix that. I''m afraid
that removing
> the brctl/brconfig check will bring trouble, because this is used in
> hotplug scripts and errors on hotplug scripts are hard to spot right
> now for regular users.
This should definitely be fixed.
I think the right answer is to add some checks in xencommons. Since
the purpose is to help the user diagnose problems, it''s fine for them
to be warnings rather than causing xencommons not to work at all.
And given that we only want to check for brctl and udev, and those are
pretty simple, I don''t think we need to use autoconf for that.
Ian.
--===============0813297164858802602=Content-Type: text/plain;
charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
--===============0813297164858802602==--
2012/2/22 Ian Jackson <Ian.Jackson@eu.citrix.com>:> Ian Campbell writes ("Re: [Xen-devel] [xen-unstable test] 12007: regressions - FAIL"): >> This is why I am concerned that we have removed the install time as well >> as the development time checks... > > This is a legitimate concern but these checks should definitely not be > in the configure script, so I've applied Roger's patches to remove > them. > >> Perhaps we should move these new checks to a second configure script >> which can be run at install time and produces as its output just a pass >> or fail? > > Roger Pau Monné writes ("Re: [Xen-devel] [xen-unstable test] 12007: regressions - FAIL"): >> I've submitted a patch that should fix that. I'm afraid that removing >> the brctl/brconfig check will bring trouble, because this is used in >> hotplug scripts and errors on hotplug scripts are hard to spot right >> now for regular users. > > This should definitely be fixed. > > I think the right answer is to add some checks in xencommons. Since > the purpose is to help the user diagnose problems, it's fine for them > to be warnings rather than causing xencommons not to work at all.I was going to create a new configure script to perform those checks, but maybe it's overkill. I will add some simple tests to xencommons.> And given that we only want to check for brctl and udev, and those are > pretty simple, I don't think we need to use autoconf for that. > > Ian._______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
This bit was missing, sorry: autoconf: clean brctl options Signed-off-by: Roger Pau Monne <roger.pau@entel.upc.edu> diff -r 31a50458bab3 tools/configure.ac --- a/tools/configure.ac Tue Feb 21 08:19:20 2012 +0100 +++ b/tools/configure.ac Tue Feb 21 08:46:04 2012 +0100 @@ -62,7 +62,6 @@ AX_SET_FLAGS AC_ARG_VAR([PYTHON], [Path to the Python parser]) AC_ARG_VAR([PERL], [Path to Perl parser]) -AC_ARG_VAR([BRCTL], [Path to brctl tool]) AC_ARG_VAR([IP], [Path to ip tool]) AC_ARG_VAR([BISON], [Path to Bison parser generator]) AC_ARG_VAR([FLEX], [Path to Flex lexical analyser generator])
Roger Pau Monné writes ("Re: [PATCH] autoconf: remove brctl
check"):> This bit was missing, sorry:
>
> autoconf: clean brctl options
>
> Signed-off-by: Roger Pau Monne <roger.pau@entel.upc.edu>
Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
Committed-by: Ian Jackson <ian.jackson@eu.citrix.com>
Let me cancel another doomed test run...
Ian.
2012/2/22 Ian Jackson <Ian.Jackson@eu.citrix.com>:> Roger Pau Monné writes ("Re: [PATCH] autoconf: remove brctl check"): >> This bit was missing, sorry: >> >> autoconf: clean brctl options >> >> Signed-off-by: Roger Pau Monne <roger.pau@entel.upc.edu> > > Acked-by: Ian Jackson <ian.jackson@eu.citrix.com> > Committed-by: Ian Jackson <ian.jackson@eu.citrix.com> > > Let me cancel another doomed test run...This is more of a cosmetic fix than anything, it should not block your tests.> Ian._______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
2012/2/22 Roger Pau Monné <roger.pau@entel.upc.edu>:> 2012/2/22 Ian Jackson <Ian.Jackson@eu.citrix.com>: >> Roger Pau Monné writes ("Re: [PATCH] autoconf: remove brctl check"): >>> This bit was missing, sorry: >>> >>> autoconf: clean brctl options >>> >>> Signed-off-by: Roger Pau Monne <roger.pau@entel.upc.edu> >> >> Acked-by: Ian Jackson <ian.jackson@eu.citrix.com> >> Committed-by: Ian Jackson <ian.jackson@eu.citrix.com> >> >> Let me cancel another doomed test run... > > This is more of a cosmetic fix than anything, it should not block your tests....and remember to execute ./autogen.sh on every configure.ac change, to update the script.> >> Ian._______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
Roger Pau Monné writes ("Re: [PATCH] autoconf: remove brctl
check"):> ...and remember to execute ./autogen.sh on every configure.ac change,
> to update the script.
Oops.
Ian.
# HG changeset patch
# User Ian Jackson <Ian.Jackson@eu.citrix.com>
# Date 1329920838 0
# Node ID 40785b4790470b5180ded4e89e8c8b7919adb87c
# Parent d370b93ba7543769702a25d7b9c99e5aa9adac6d
autoconf: Rerun autogen.sh
Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
diff -r d370b93ba754 -r 40785b479047 tools/configure
--- a/tools/configure Wed Feb 22 13:06:42 2012 +0000
+++ b/tools/configure Wed Feb 22 14:27:18 2012 +0000
@@ -611,10 +611,6 @@ glib_CFLAGS
PKG_CONFIG_LIBDIR
PKG_CONFIG_PATH
PKG_CONFIG
-VNCONFIG
-HOTPLUG
-UDEVINFO
-UDEVADM
PYTHONPATH
OCAMLBUILD
OCAMLDOC
@@ -642,7 +638,6 @@ CURL
FLEX
BISON
IP
-BRCTL
PERL
PYTHON
APPEND_LIB
@@ -744,7 +739,6 @@ APPEND_INCLUDES
APPEND_LIB
PYTHON
PERL
-BRCTL
IP
BISON
FLEX
@@ -1400,7 +1394,6 @@ Some influential environment variables:
APPEND_LIB List of library folders to append to LDFLAGS (without -L)
PYTHON Path to the Python parser
PERL Path to Perl parser
- BRCTL Path to brctl tool
IP Path to ip tool
BISON Path to Bison parser generator
FLEX Path to Flex lexical analyser generator
@@ -3858,8 +3851,6 @@ case $host_os in *\ *) host_os=`echo "$h
-
-
# pkg.m4 - Macros to locate and utilise pkg-config. -*- Autoconf -*-
# serial 1 (pkg-config-0.24)
#
@@ -4168,7 +4159,6 @@ LDFLAGS="$PREPEND_LDFLAGS $LDFLAGS $APPE
-
# Checks for programs.
{ $as_echo "$as_me:${as_lineno-$LINENO}: checking for a sed that does not
truncate output" >&5
$as_echo_n "checking for a sed that does not truncate output... "
>&6; }
@@ -4959,51 +4949,6 @@ if test x"${PERL}" == x"no"
then
as_fn_error $? "Unable to find perl, please install perl"
"$LINENO" 5
fi
-# Extract the first word of "brctl", so it can be a program name with
args.
-set dummy brctl; ac_word=$2
-{ $as_echo "$as_me:${as_lineno-$LINENO}: checking for $ac_word"
>&5
-$as_echo_n "checking for $ac_word... " >&6; }
-if test "${ac_cv_path_BRCTL+set}" = set; then :
- $as_echo_n "(cached) " >&6
-else
- case $BRCTL in
- [\\/]* | ?:[\\/]*)
- ac_cv_path_BRCTL="$BRCTL" # Let the user override the test with a
path.
- ;;
- *)
- as_save_IFS=$IFS; IFS=$PATH_SEPARATOR
-for as_dir in $PATH
-do
- IFS=$as_save_IFS
- test -z "$as_dir" && as_dir=.
- for ac_exec_ext in '''' $ac_executable_extensions; do
- if { test -f "$as_dir/$ac_word$ac_exec_ext" && $as_test_x
"$as_dir/$ac_word$ac_exec_ext"; }; then
- ac_cv_path_BRCTL="$as_dir/$ac_word$ac_exec_ext"
- $as_echo "$as_me:${as_lineno-$LINENO}: found
$as_dir/$ac_word$ac_exec_ext" >&5
- break 2
- fi
-done
- done
-IFS=$as_save_IFS
-
- test -z "$ac_cv_path_BRCTL" &&
ac_cv_path_BRCTL="no"
- ;;
-esac
-fi
-BRCTL=$ac_cv_path_BRCTL
-if test -n "$BRCTL"; then
- { $as_echo "$as_me:${as_lineno-$LINENO}: result: $BRCTL" >&5
-$as_echo "$BRCTL" >&6; }
-else
- { $as_echo "$as_me:${as_lineno-$LINENO}: result: no" >&5
-$as_echo "no" >&6; }
-fi
-
-
-if test x"${BRCTL}" == x"no"
-then
- as_fn_error $? "Unable to find brctl, please install brctl"
"$LINENO" 5
-fi
# Extract the first word of "ip", so it can be a program name with
args.
set dummy ip; ac_word=$2
{ $as_echo "$as_me:${as_lineno-$LINENO}: checking for $ac_word"
>&5
@@ -6440,196 +6385,6 @@ then
fi
if test "x$host_os" == "xlinux-gnu"
then
- # Extract the first word of "udevadm", so it can be a program
name with args.
-set dummy udevadm; ac_word=$2
-{ $as_echo "$as_me:${as_lineno-$LINENO}: checking for $ac_word"
>&5
-$as_echo_n "checking for $ac_word... " >&6; }
-if test "${ac_cv_path_UDEVADM+set}" = set; then :
- $as_echo_n "(cached) " >&6
-else
- case $UDEVADM in
- [\\/]* | ?:[\\/]*)
- ac_cv_path_UDEVADM="$UDEVADM" # Let the user override the test with
a path.
- ;;
- *)
- as_save_IFS=$IFS; IFS=$PATH_SEPARATOR
-for as_dir in $PATH
-do
- IFS=$as_save_IFS
- test -z "$as_dir" && as_dir=.
- for ac_exec_ext in '''' $ac_executable_extensions; do
- if { test -f "$as_dir/$ac_word$ac_exec_ext" && $as_test_x
"$as_dir/$ac_word$ac_exec_ext"; }; then
- ac_cv_path_UDEVADM="$as_dir/$ac_word$ac_exec_ext"
- $as_echo "$as_me:${as_lineno-$LINENO}: found
$as_dir/$ac_word$ac_exec_ext" >&5
- break 2
- fi
-done
- done
-IFS=$as_save_IFS
-
- test -z "$ac_cv_path_UDEVADM" &&
ac_cv_path_UDEVADM="no"
- ;;
-esac
-fi
-UDEVADM=$ac_cv_path_UDEVADM
-if test -n "$UDEVADM"; then
- { $as_echo "$as_me:${as_lineno-$LINENO}: result: $UDEVADM"
>&5
-$as_echo "$UDEVADM" >&6; }
-else
- { $as_echo "$as_me:${as_lineno-$LINENO}: result: no" >&5
-$as_echo "no" >&6; }
-fi
-
-
- if test x"${UDEVADM}" == x"no"
- then
- # Extract the first word of "udevinfo", so it can be a
program name with args.
-set dummy udevinfo; ac_word=$2
-{ $as_echo "$as_me:${as_lineno-$LINENO}: checking for $ac_word"
>&5
-$as_echo_n "checking for $ac_word... " >&6; }
-if test "${ac_cv_path_UDEVINFO+set}" = set; then :
- $as_echo_n "(cached) " >&6
-else
- case $UDEVINFO in
- [\\/]* | ?:[\\/]*)
- ac_cv_path_UDEVINFO="$UDEVINFO" # Let the user override the test
with a path.
- ;;
- *)
- as_save_IFS=$IFS; IFS=$PATH_SEPARATOR
-for as_dir in $PATH
-do
- IFS=$as_save_IFS
- test -z "$as_dir" && as_dir=.
- for ac_exec_ext in '''' $ac_executable_extensions; do
- if { test -f "$as_dir/$ac_word$ac_exec_ext" && $as_test_x
"$as_dir/$ac_word$ac_exec_ext"; }; then
- ac_cv_path_UDEVINFO="$as_dir/$ac_word$ac_exec_ext"
- $as_echo "$as_me:${as_lineno-$LINENO}: found
$as_dir/$ac_word$ac_exec_ext" >&5
- break 2
- fi
-done
- done
-IFS=$as_save_IFS
-
- test -z "$ac_cv_path_UDEVINFO" &&
ac_cv_path_UDEVINFO="no"
- ;;
-esac
-fi
-UDEVINFO=$ac_cv_path_UDEVINFO
-if test -n "$UDEVINFO"; then
- { $as_echo "$as_me:${as_lineno-$LINENO}: result: $UDEVINFO"
>&5
-$as_echo "$UDEVINFO" >&6; }
-else
- { $as_echo "$as_me:${as_lineno-$LINENO}: result: no" >&5
-$as_echo "no" >&6; }
-fi
-
-
- if test x"${UDEVINFO}" == x"no"
- then
- as_fn_error $? "Unable to find udevadm or udevinfo, please
install udev" "$LINENO" 5
- fi
- udevver=`${UDEVINFO} -V | awk ''{print $NF}''`
- else
- udevver=`${UDEVADM} info -V | awk ''{print $NF}''`
- fi
- if test ${udevver} -lt 59
- then
- # Extract the first word of "hotplug", so it can be a program
name with args.
-set dummy hotplug; ac_word=$2
-{ $as_echo "$as_me:${as_lineno-$LINENO}: checking for $ac_word"
>&5
-$as_echo_n "checking for $ac_word... " >&6; }
-if test "${ac_cv_path_HOTPLUG+set}" = set; then :
- $as_echo_n "(cached) " >&6
-else
- case $HOTPLUG in
- [\\/]* | ?:[\\/]*)
- ac_cv_path_HOTPLUG="$HOTPLUG" # Let the user override the test with
a path.
- ;;
- *)
- as_save_IFS=$IFS; IFS=$PATH_SEPARATOR
-for as_dir in $PATH
-do
- IFS=$as_save_IFS
- test -z "$as_dir" && as_dir=.
- for ac_exec_ext in '''' $ac_executable_extensions; do
- if { test -f "$as_dir/$ac_word$ac_exec_ext" && $as_test_x
"$as_dir/$ac_word$ac_exec_ext"; }; then
- ac_cv_path_HOTPLUG="$as_dir/$ac_word$ac_exec_ext"
- $as_echo "$as_me:${as_lineno-$LINENO}: found
$as_dir/$ac_word$ac_exec_ext" >&5
- break 2
- fi
-done
- done
-IFS=$as_save_IFS
-
- test -z "$ac_cv_path_HOTPLUG" &&
ac_cv_path_HOTPLUG="no"
- ;;
-esac
-fi
-HOTPLUG=$ac_cv_path_HOTPLUG
-if test -n "$HOTPLUG"; then
- { $as_echo "$as_me:${as_lineno-$LINENO}: result: $HOTPLUG"
>&5
-$as_echo "$HOTPLUG" >&6; }
-else
- { $as_echo "$as_me:${as_lineno-$LINENO}: result: no" >&5
-$as_echo "no" >&6; }
-fi
-
-
- if test x"${HOTPLUG}" == x"no"
- then
- as_fn_error $? "udev is too old, upgrade to version 59 or
later" "$LINENO" 5
- fi
- fi
-else
- # Extract the first word of "vnconfig", so it can be a program
name with args.
-set dummy vnconfig; ac_word=$2
-{ $as_echo "$as_me:${as_lineno-$LINENO}: checking for $ac_word"
>&5
-$as_echo_n "checking for $ac_word... " >&6; }
-if test "${ac_cv_path_VNCONFIG+set}" = set; then :
- $as_echo_n "(cached) " >&6
-else
- case $VNCONFIG in
- [\\/]* | ?:[\\/]*)
- ac_cv_path_VNCONFIG="$VNCONFIG" # Let the user override the test
with a path.
- ;;
- *)
- as_save_IFS=$IFS; IFS=$PATH_SEPARATOR
-for as_dir in $PATH
-do
- IFS=$as_save_IFS
- test -z "$as_dir" && as_dir=.
- for ac_exec_ext in '''' $ac_executable_extensions; do
- if { test -f "$as_dir/$ac_word$ac_exec_ext" && $as_test_x
"$as_dir/$ac_word$ac_exec_ext"; }; then
- ac_cv_path_VNCONFIG="$as_dir/$ac_word$ac_exec_ext"
- $as_echo "$as_me:${as_lineno-$LINENO}: found
$as_dir/$ac_word$ac_exec_ext" >&5
- break 2
- fi
-done
- done
-IFS=$as_save_IFS
-
- test -z "$ac_cv_path_VNCONFIG" &&
ac_cv_path_VNCONFIG="no"
- ;;
-esac
-fi
-VNCONFIG=$ac_cv_path_VNCONFIG
-if test -n "$VNCONFIG"; then
- { $as_echo "$as_me:${as_lineno-$LINENO}: result: $VNCONFIG"
>&5
-$as_echo "$VNCONFIG" >&6; }
-else
- { $as_echo "$as_me:${as_lineno-$LINENO}: result: no" >&5
-$as_echo "no" >&6; }
-fi
-
-
- if test x"${VNCONFIG}" == x"no"
- then
- as_fn_error $? "Not a Linux system and unable to find vnd"
"$LINENO" 5
- fi
-fi
-
-if test "x$host_os" == "xlinux-gnu"
-then
ac_fn_c_check_header_mongrel "$LINENO" "uuid/uuid.h"
"ac_cv_header_uuid_uuid_h" "$ac_includes_default"
if test "x$ac_cv_header_uuid_uuid_h" = x""yes; then :