Roger Pau Monne
2012-Jan-11 05:13 UTC
[PATCH v4 RESEND] build: add autoconf to replace custom checks in tools/check
Added autotools magic to replace custom check scripts. The previous checks have been ported to autoconf, and some additional ones have been added (plus the suggestions from running autoscan). Two files are created as a result from executing configure script, config/Tools.mk and config.h. conf/Tools.mk is included by tools/Rules.mk, and contains most of the options previously defined in .config, that can now be set passing parameters or defining environment variables when executing configure script. config.h is still not used anywhere, and is automatically created by autoheader, altough this migh change when we start to include this file. Just a first release, and since it''s my first autoconf script I guess there will be many things to polish here... Please review and comment. Changes since v3: * Copied config.guess and config.sub from automake 1.11. * Added a test to check for uuid.h on BSD and uuid/uuid.h on Linux. Changes since v2: * Changed order of config/Tools.mk include. * Added "-e" to autogen.sh shebang. * Added necessary files (config.*) and output from Autoheader and Autoconf. * Removed Autoconf from build dependencies and updated README. Changes since v1: * Moved autoconf stuff inside tools folder. * Add Makefile rules for cleaning. * Removed Automake dependency. * Create autogen.sh to automatically create configure script when building from source repository. * Cached values of options passed from command line. * Add necessary ignores to .hgignore. * Added Autoconf to the list of dependencies. * Changed hypen to underscore in XML2 and CURL variable names. * Added script to get version from xen/Makefile. * Set Ocaml tools to optional. * Added procedence of m4/ocaml.m4. Signed-off-by: Roger Pau Monne <roger.pau@entel.upc.edu> .hgignore | 6 + Config.mk | 30 - Makefile | 2 - README | 4 + autogen.sh | 9 + config/Tools.mk.in | 50 + configure | 2 + tools/Makefile | 3 +- tools/Rules.mk | 7 +- tools/blktap/drivers/Makefile | 2 +- tools/blktap/drivers/check_gcrypt | 14 - tools/check/Makefile | 26 - tools/check/README | 20 - tools/check/check_brctl | 13 - tools/check/check_crypto_lib | 11 - tools/check/check_curl | 13 - tools/check/check_iproute | 15 - tools/check/check_libaio_devel | 11 - tools/check/check_libaio_lib | 9 - tools/check/check_openssl_devel | 6 - tools/check/check_python | 13 - tools/check/check_python_devel | 17 - tools/check/check_python_xml | 12 - tools/check/check_udev | 22 - tools/check/check_uuid_devel | 7 - tools/check/check_x11_devel | 9 - tools/check/check_xgettext | 6 - tools/check/check_xml2 | 14 - tools/check/check_yajl_devel | 8 - tools/check/check_yajl_lib | 6 - tools/check/check_zlib_devel | 6 - tools/check/check_zlib_lib | 12 - tools/check/chk | 63 - tools/check/funcs.sh | 106 - tools/config.guess | 1522 +++++ tools/config.h.in | 468 + tools/config.sub | 1771 ++++++ tools/configure | 10204 ++++++++++++++++++++++++++++++++++++ tools/configure.ac | 191 + tools/debugger/gdbsx/xg/Makefile | 1 - tools/install.sh | 1 + tools/libfsimage/Makefile | 6 +- tools/libfsimage/check-libext2fs | 21 - tools/libxen/Makefile | 8 +- tools/m4/default_lib.m4 | 8 + tools/m4/disable_feature.m4 | 13 + tools/m4/enable_feature.m4 | 13 + tools/m4/ocaml.m4 | 241 + tools/m4/path_or_fail.m4 | 6 + tools/m4/python_devel.m4 | 18 + tools/m4/python_version.m4 | 12 + tools/m4/python_xml.m4 | 10 + tools/m4/set_cflags_ldflags.m4 | 20 + tools/m4/udev.m4 | 32 + tools/m4/uuid.m4 | 10 + version.sh | 5 + 56 files changed, 14633 insertions(+), 502 deletions(-) _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Ian Jackson
2012-Feb-13 17:56 UTC
Re: [PATCH v4 RESEND] build: add autoconf to replace custom checks in tools/check
Roger Pau Monne writes ("[Xen-devel] [PATCH v4 RESEND] build: add autoconf
to replace custom checks in tools/check"):> Added autotools magic to replace custom check scripts. The previous
> checks have been ported to autoconf, and some additional ones have
> been added (plus the suggestions from running autoscan). Two files are
> created as a result from executing configure script, config/Tools.mk
> and config.h.
Thanks for this work. I''m just replying to give a status update: I
haven''t forgotten this.
It depends on a new feature in the autotest machinery - which would
involve it automatically running "./configure" as well as just
"make".
I have a number of other test system changes which are queued up
beforehand, but this is on my list.
Last time you posted this there was an objection that autoconf 2.67
isn''t necessarily that widely available. Did you deliberately use any
2.67 features or can we have a less aggressive PREREQ ?
Also, of course, this patch has rotted slightly and no longer applies
to xen-unstable tip. When the test system is ready I''ll email again
and ask you to rebase.
Does anyone else have any comments ?
Thanks,
Ian.
Roger Pau Monné
2012-Feb-14 08:56 UTC
Re: [PATCH v4 RESEND] build: add autoconf to replace custom checks in tools/check
2012/2/13 Ian Jackson <Ian.Jackson@eu.citrix.com>:> Roger Pau Monne writes ("[Xen-devel] [PATCH v4 RESEND] build: add autoconf to replace custom checks in tools/check"): >> Added autotools magic to replace custom check scripts. The previous >> checks have been ported to autoconf, and some additional ones have >> been added (plus the suggestions from running autoscan). Two files are >> created as a result from executing configure script, config/Tools.mk >> and config.h. > > Thanks for this work. I'm just replying to give a status update: I > haven't forgotten this.No problem, I've been busy with other stuff too. Just as a side note, I haven't forgotten about the driver domain series too, and I will try to answer the questions/suggestions as soon as I can.> It depends on a new feature in the autotest machinery - which would > involve it automatically running "./configure" as well as just "make". > I have a number of other test system changes which are queued up > beforehand, but this is on my list. > > Last time you posted this there was an objection that autoconf 2.67 > isn't necessarily that widely available. Did you deliberately use any > 2.67 features or can we have a less aggressive PREREQ ?I don't think it needs autoconf 2.67 (or at least I'm not aware of using any specific macros that require > 2.67), but since autoconf should only be used by the developers, if someone has to generate a new configure with a previous version we could always try to downgrade the prereq and see if it works.> Also, of course, this patch has rotted slightly and no longer applies > to xen-unstable tip. When the test system is ready I'll email again > and ask you to rebase.I'm aware, since the yajl 2 series went in, this patch needs some adjustments. Just drop a line when you are ready and I will update it to match tip. Thanks, Roger.> Does anyone else have any comments ? > > Thanks, > Ian._______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Ian Jackson
2012-Feb-20 16:02 UTC
Re: [PATCH v4 RESEND] build: add autoconf to replace custom checks in tools/check
Roger Pau Monné writes ("Re: [Xen-devel] [PATCH v4 RESEND] build: add
autoconf to replace custom checks in tools/check"):> I''m aware, since the yajl 2 series went in, this patch needs some
> adjustments. Just drop a line when you are ready and I will update it
> to match tip.
If you could do that now, that would be great.
Thanks,
Ian.