Attached patch fix build error in latest xen-unstable.hg. Signed-off-by: Allen Kay <allen.m.kay@intel.com<mailto:allen.m.kay@intel.com>> _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
On Wed, 2012-01-04 at 21:57 +0000, Kay, Allen M wrote:> Attached patch fix build error in latest xen-unstable.hg.What is the specific build error? What version of yajl do you have and on which distro? Ian.> > > > Signed-off-by: Allen Kay <allen.m.kay@intel.com> > > > >
Ian Campbell wrote on 2012-01-05:> On Wed, 2012-01-04 at 21:57 +0000, Kay, Allen M wrote: >> Attached patch fix build error in latest xen-unstable.hg. > > What is the specific build error? > > What version of yajl do you have and on which distro? >I am not try to answer this for Allen, but I also met similar build error(it says yajl_gen_no_buf was not defined) in RHEL6.2 64bit with yajl 1.0.7-3. Jimmy
On Thu, 2012-01-05 at 15:00 +0000, Wei, Gang wrote:> Ian Campbell wrote on 2012-01-05: > > On Wed, 2012-01-04 at 21:57 +0000, Kay, Allen M wrote: > >> Attached patch fix build error in latest xen-unstable.hg. > > > > What is the specific build error? > > > > What version of yajl do you have and on which distro? > > > > I am not try to answer this for Allen, but I also met similar build error(it says yajl_gen_no_buf was not defined) in RHEL6.2 64bit with yajl 1.0.7-3.I use 1.0.8 so I guess this must be new there. Any patch which says "fix build error/warning/message" should, IMHO, always include a verbatim copy of the error message being fixed. Please can one of you resubmit with the changelog corrected in that manner? Eventually we could use autoconf to detect this stuff, although that does sound rather like overkill... Ian.
On Thu, Jan 05, 2012 at 03:05:21PM +0000, Ian Campbell wrote:> On Thu, 2012-01-05 at 15:00 +0000, Wei, Gang wrote: > > Ian Campbell wrote on 2012-01-05: > > > On Wed, 2012-01-04 at 21:57 +0000, Kay, Allen M wrote: > > >> Attached patch fix build error in latest xen-unstable.hg. > > > > > > What is the specific build error? > > > > > > What version of yajl do you have and on which distro? > > > > > > > I am not try to answer this for Allen, but I also met similar build error(it says yajl_gen_no_buf was not defined) in RHEL6.2 64bit with yajl 1.0.7-3. > > I use 1.0.8 so I guess this must be new there. > > Any patch which says "fix build error/warning/message" should, IMHO, > always include a verbatim copy of the error message being fixed. > > Please can one of you resubmit with the changelog corrected in that > manner?Yes please. You can also add ''Tested-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>''. Thanks.> > Eventually we could use autoconf to detect this stuff, although that > does sound rather like overkill... > > Ian. > > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel
Konrad Rzeszutek Wilk writes ("Re: [Xen-devel] [PATCH] fix build
error"):> On Thu, Jan 05, 2012 at 03:05:21PM +0000, Ian Campbell wrote:
> > Any patch which says "fix build error/warning/message"
should, IMHO,
> > always include a verbatim copy of the error message being fixed.
Yes.
> > Please can one of you resubmit with the changelog corrected in that
> > manner?
>
> Yes please. You can also add ''Tested-by: Konrad Rzeszutek Wilk
> <konrad.wilk@oracle.com>''. Thanks.
This doesn''t seem to have been forthcoming and it was all pretty
obvious following this thread so I''ve committed it now.
Next time it would definitely be nice if we could have a good commit
message and so forth.
> > Eventually we could use autoconf to detect this stuff, although that
> > does sound rather like overkill...
This kind of irritating API instability is exactly what autoconf is
good at.
Ian.