flight 10332 xen-unstable real [real]
http://www.chiark.greenend.org.uk/~xensrcts/logs/10332/
Regressions :-(
Tests which did not succeed and are blocking:
test-amd64-i386-xl-winxpsp3-vcpus1 4 xen-install fail REGR. vs. 10201
test-amd64-i386-xl-win7-amd64 4 xen-install fail REGR. vs. 10201
test-amd64-i386-xend-winxpsp3 4 xen-install fail REGR. vs. 10201
test-amd64-i386-pv 4 xen-install fail REGR. vs. 10201
test-amd64-i386-xl-credit2 4 xen-install fail REGR. vs. 10201
test-amd64-i386-xl-multivcpu 4 xen-install fail REGR. vs. 10201
test-amd64-i386-xl 4 xen-install fail REGR. vs. 10201
test-amd64-i386-pair 6 xen-install/dst_host fail REGR. vs. 10201
test-amd64-i386-pair 5 xen-install/src_host fail REGR. vs. 10201
build-i386 4 xen-build fail REGR. vs. 10201
build-i386-oldkern 4 xen-build fail REGR. vs. 10201
test-amd64-i386-rhel6hvm-intel 4 xen-install fail REGR. vs. 10201
test-amd64-i386-rhel6hvm-amd 4 xen-install fail REGR. vs. 10201
test-amd64-i386-win-vcpus1 4 xen-install fail REGR. vs. 10201
test-amd64-amd64-win 8 guest-saverestore fail REGR. vs. 10201
test-amd64-amd64-xl-win 8 guest-saverestore fail REGR. vs. 10201
test-amd64-i386-win 4 xen-install fail REGR. vs. 10201
test-amd64-i386-xl-win-vcpus1 4 xen-install fail REGR. vs. 10201
Tests which are failing intermittently (not blocking):
test-amd64-amd64-xl-sedf 13 guest-localmigrate.2 fail pass in 10317
test-amd64-amd64-xl-sedf 14 guest-localmigrate/x10 fail in 10317 pass in 10313
Tests which did not succeed, but are not blocking,
including regressions (tests previously passed) regarded as allowable:
test-amd64-amd64-xl-win7-amd64 7 windows-install fail never pass
test-i386-i386-xl-winxpsp3 1 xen-build-check(1) blocked n/a
test-amd64-amd64-xl-pcipt-intel 9 guest-start fail never pass
test-i386-i386-pv 1 xen-build-check(1) blocked n/a
test-i386-i386-xl 1 xen-build-check(1) blocked n/a
test-i386-i386-pair 1 xen-build-check(1) blocked n/a
test-amd64-amd64-xl-winxpsp3 7 windows-install fail never pass
test-i386-i386-win 1 xen-build-check(1) blocked n/a
test-i386-i386-xl-win 1 xen-build-check(1) blocked n/a
test-amd64-amd64-xl-sedf-pin 14 guest-localmigrate/x10 fail in 10317 blocked in
10201
version targeted for testing:
xen a4d7c27ec1f1
baseline version:
xen 62ff6a318c5d
------------------------------------------------------------
People who touched revisions under test:
Adin Scannell <adin@scannell.ca>
Andres Lagar-Cavilla <andres@lagarcavilla.org>
Anthony PERARD <anthony.perard@citrix.com>
Brendan Cully <brendan@cs.ubc.ca>
Daniel De Graaf <dgdegra@tycho.nsa.gov>
Ian Campbell <ian.campbell@citrix.com>
Ian Jackson <ian.jackson.citrix.com>
Ian Jackson <ian.jackson@eu.citrix.com>
Jan Beulich <jbeulich@novell.com>
Jan Beulich <jbeulich@suse.com>
Jean Guyader <jean.guyader@eu.citrix.com>
Jonathan Davies <jonathan.davies@citrix.com>
juergen.gross@ts.fujitsu.com
Keir Fraser <keir@xen.org>
Liu, Jinsong <jinsong.liu@intel.com>
Olaf Hering <olaf@aepfle.de>
Paul Durrant <paul.durrant@citrix.com>
Philipp Hahn <hahn@univention.de>
Shriram Rajagopalan <rshriram@cs.ubc.ca>
Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Tim Deegan <tim@xen.org>
Wei Wang2 <wei.wang2@amd.com>
------------------------------------------------------------
jobs:
build-amd64 pass
build-i386 fail
build-amd64-oldkern pass
build-i386-oldkern fail
build-amd64-pvops pass
build-i386-pvops pass
test-amd64-amd64-xl pass
test-amd64-i386-xl fail
test-i386-i386-xl blocked
test-amd64-i386-rhel6hvm-amd fail
test-amd64-amd64-xl-win7-amd64 fail
test-amd64-i386-xl-win7-amd64 fail
test-amd64-i386-xl-credit2 fail
test-amd64-amd64-xl-pcipt-intel fail
test-amd64-i386-rhel6hvm-intel fail
test-amd64-i386-xl-multivcpu fail
test-amd64-amd64-pair pass
test-amd64-i386-pair fail
test-i386-i386-pair blocked
test-amd64-amd64-xl-sedf-pin pass
test-amd64-amd64-pv pass
test-amd64-i386-pv fail
test-i386-i386-pv blocked
test-amd64-amd64-xl-sedf fail
test-amd64-i386-win-vcpus1 fail
test-amd64-i386-xl-win-vcpus1 fail
test-amd64-i386-xl-winxpsp3-vcpus1 fail
test-amd64-amd64-win fail
test-amd64-i386-win fail
test-i386-i386-win blocked
test-amd64-amd64-xl-win fail
test-i386-i386-xl-win blocked
test-amd64-i386-xend-winxpsp3 fail
test-amd64-amd64-xl-winxpsp3 fail
test-i386-i386-xl-winxpsp3 blocked
------------------------------------------------------------
sg-report-flight on woking.cam.xci-test.com
logs: /home/xc_osstest/logs
images: /home/xc_osstest/images
Logs, config files, etc. are available at
http://www.chiark.greenend.org.uk/~xensrcts/logs
Test harness code can be found at
http://xenbits.xensource.com/gitweb?p=osstest.git;a=summary
Not pushing.
(No revision log; it would be 1262 lines long.)
>>> On 05.12.11 at 05:11, xen.org <ian.jackson@eu.citrix.com> wrote: > build-i386 4 xen-build fail REGR. vs. 10201cc1: warnings being treated as errors label-pci.c: In function ''main'': label-pci.c:79: error: format ''%lx'' expects type ''long unsigned int *'', but argument 3 has type ''uint64_t *'' label-pci.c:79: error: format ''%lx'' expects type ''long unsigned int *'', but argument 4 has type ''uint64_t *'' label-pci.c:79: error: format ''%lx'' expects type ''long unsigned int *'', but argument 5 has type ''uint64_t *'' label-pci.c:85: error: format ''%lx'' expects type ''long unsigned int'', but argument 3 has type ''uint64_t'' label-pci.c:85: error: format ''%lx'' expects type ''long unsigned int'', but argument 4 has type ''uint64_t'' label-pci.c:95: error: format ''%lx'' expects type ''long unsigned int'', but argument 3 has type ''uint64_t'' label-pci.c:95: error: format ''%lx'' expects type ''long unsigned int'', but argument 4 has type ''uint64_t'' label-pci.c:108: error: format ''%ld'' expects type ''long int *'', but argument 3 has type ''uint64_t *'' label-pci.c:113: error: format ''%ld'' expects type ''long int'', but argument 3 has type ''uint64_t'' make[5]: *** [label-pci.o] Error 1 This is due to entirely non-portable code in tools/flask/utils/label-pci.c: If you use C99 types, you also need to use C99 format macros for calls to the printf and scanf function families. Jan
Daniel De Graaf
2011-Dec-05 11:29 UTC
[PATCH] flask: Fix 32-bit compilation of label-pci tool
The 32-bit tools need to support 64-bit addresses, so use the correct
printf/scanf formats.
Signed-off-by: Daniel De Graaf <dgdegra@tycho.nsa.gov>
---
tools/flask/utils/label-pci.c | 15 ++++++++-------
1 files changed, 8 insertions(+), 7 deletions(-)
diff --git a/tools/flask/utils/label-pci.c b/tools/flask/utils/label-pci.c
index 839ad61..ca53ea8 100644
--- a/tools/flask/utils/label-pci.c
+++ b/tools/flask/utils/label-pci.c
@@ -15,6 +15,7 @@
#include <sys/stat.h>
#include <string.h>
#include <unistd.h>
+#include <inttypes.h>
#include <libflask.h>
/* Pulled from linux/include/linux/ioport.h */
@@ -76,22 +77,22 @@ int main (int argCnt, char *argv[])
goto done;
}
- while (fscanf(f, "0x%lx 0x%lx 0x%lx\n", &start, &end,
&flags) == 3) {
+ while (fscanf(f, "0x%"PRIx64" 0x%"PRIx64"
0x%"PRIx64"\n", &start, &end, &flags) == 3) {
if (flags & IORESOURCE_IO) {
- // printf("Port %lx-%lx\n", start, end);
+ // printf("Port %"PRIx64"-%"PRIx64"\n", start,
end);
ret = flask_add_ioport(xch, start, end, argv[2]);
if (ret) {
- fprintf(stderr, "flask_add_ioport %lx-%lx failed: %d\n",
+ fprintf(stderr, "flask_add_ioport
%"PRIx64"-%"PRIx64" failed: %d\n",
start, end, ret);
err = 2;
}
} else if (flags & IORESOURCE_MEM) {
start >>= 12;
end >>= 12;
- // printf("IOMEM %lx-%lx\n", start, end);
+ // printf("IOMEM %"PRIx64"-%"PRIx64"\n",
start, end);
ret = flask_add_iomem(xch, start, end, argv[2]);
if (ret) {
- fprintf(stderr, "flask_add_iomem %lx-%lx failed: %d\n",
+ fprintf(stderr, "flask_add_iomem
%"PRIx64"-%"PRIx64" failed: %d\n",
start, end, ret);
err = 2;
}
@@ -105,11 +106,11 @@ int main (int argCnt, char *argv[])
if (!f)
goto done;
start = 0;
- fscanf(f, "%ld", &start);
+ fscanf(f, "%" PRIu64, &start);
if (start) {
ret = flask_add_pirq(xch, start, argv[2]);
if (ret) {
- fprintf(stderr, "flask_add_pirq %ld failed: %d\n",
+ fprintf(stderr, "flask_add_pirq %"PRIu64" failed: %d\n",
start, ret);
err = 2;
}
--
1.7.7.3
Daniel De Graaf
2011-Dec-05 11:34 UTC
[PATCH v2] flask: Fix 32-bit compilation of label-pci tool
The 32-bit tools need to support 64-bit addresses, so use the correct
printf/scanf formats.
Signed-off-by: Daniel De Graaf <dgdegra@tycho.nsa.gov>
---
tools/flask/utils/label-pci.c | 15 ++++++++-------
1 files changed, 8 insertions(+), 7 deletions(-)
diff --git a/tools/flask/utils/label-pci.c b/tools/flask/utils/label-pci.c
index 839ad61..009a733 100644
--- a/tools/flask/utils/label-pci.c
+++ b/tools/flask/utils/label-pci.c
@@ -15,6 +15,7 @@
#include <sys/stat.h>
#include <string.h>
#include <unistd.h>
+#include <inttypes.h>
#include <libflask.h>
/* Pulled from linux/include/linux/ioport.h */
@@ -76,22 +77,22 @@ int main (int argCnt, char *argv[])
goto done;
}
- while (fscanf(f, "0x%lx 0x%lx 0x%lx\n", &start, &end,
&flags) == 3) {
+ while (fscanf(f, "0x%"SCNx64" 0x%"SCNx64"
0x%"SCNx64"\n", &start, &end, &flags) == 3) {
if (flags & IORESOURCE_IO) {
- // printf("Port %lx-%lx\n", start, end);
+ // printf("Port %"PRIx64"-%"PRIx64"\n", start,
end);
ret = flask_add_ioport(xch, start, end, argv[2]);
if (ret) {
- fprintf(stderr, "flask_add_ioport %lx-%lx failed: %d\n",
+ fprintf(stderr, "flask_add_ioport
%"PRIx64"-%"PRIx64" failed: %d\n",
start, end, ret);
err = 2;
}
} else if (flags & IORESOURCE_MEM) {
start >>= 12;
end >>= 12;
- // printf("IOMEM %lx-%lx\n", start, end);
+ // printf("IOMEM %"PRIx64"-%"PRIx64"\n",
start, end);
ret = flask_add_iomem(xch, start, end, argv[2]);
if (ret) {
- fprintf(stderr, "flask_add_iomem %lx-%lx failed: %d\n",
+ fprintf(stderr, "flask_add_iomem
%"PRIx64"-%"PRIx64" failed: %d\n",
start, end, ret);
err = 2;
}
@@ -105,11 +106,11 @@ int main (int argCnt, char *argv[])
if (!f)
goto done;
start = 0;
- fscanf(f, "%ld", &start);
+ fscanf(f, "%" SCNu64, &start);
if (start) {
ret = flask_add_pirq(xch, start, argv[2]);
if (ret) {
- fprintf(stderr, "flask_add_pirq %ld failed: %d\n",
+ fprintf(stderr, "flask_add_pirq %"PRIu64" failed: %d\n",
start, ret);
err = 2;
}
--
1.7.7.3
Olaf Hering
2011-Dec-05 18:05 UTC
Re: [PATCH v2] flask: Fix 32-bit compilation of label-pci tool
On Mon, Dec 05, Daniel De Graaf wrote:> + fscanf(f, "%" SCNu64, &start);label-pci.c:108: error: ignoring return value of ''fscanf'', declared with attribute warn_unused_result This still leads to an error. Olaf
Daniel De Graaf
2011-Dec-05 18:45 UTC
[PATCH v3] flask: Fix 32-bit compilation of label-pci tool
The 32-bit tools need to support 64-bit addresses, so use the correct
printf/scanf formats. Also, some systems declare fscanf with attribute
warn_unused_result, so check the result instead of relying on the value
of start being unmodified across a failed call.
Signed-off-by: Daniel De Graaf <dgdegra@tycho.nsa.gov>
---
tools/flask/utils/label-pci.c | 17 +++++++++--------
1 files changed, 9 insertions(+), 8 deletions(-)
diff --git a/tools/flask/utils/label-pci.c b/tools/flask/utils/label-pci.c
index 839ad61..da0cb61 100644
--- a/tools/flask/utils/label-pci.c
+++ b/tools/flask/utils/label-pci.c
@@ -15,6 +15,7 @@
#include <sys/stat.h>
#include <string.h>
#include <unistd.h>
+#include <inttypes.h>
#include <libflask.h>
/* Pulled from linux/include/linux/ioport.h */
@@ -76,22 +77,22 @@ int main (int argCnt, char *argv[])
goto done;
}
- while (fscanf(f, "0x%lx 0x%lx 0x%lx\n", &start, &end,
&flags) == 3) {
+ while (fscanf(f, "0x%"SCNx64" 0x%"SCNx64"
0x%"SCNx64"\n", &start, &end, &flags) == 3) {
if (flags & IORESOURCE_IO) {
- // printf("Port %lx-%lx\n", start, end);
+ // printf("Port %"PRIx64"-%"PRIx64"\n", start,
end);
ret = flask_add_ioport(xch, start, end, argv[2]);
if (ret) {
- fprintf(stderr, "flask_add_ioport %lx-%lx failed: %d\n",
+ fprintf(stderr, "flask_add_ioport
%"PRIx64"-%"PRIx64" failed: %d\n",
start, end, ret);
err = 2;
}
} else if (flags & IORESOURCE_MEM) {
start >>= 12;
end >>= 12;
- // printf("IOMEM %lx-%lx\n", start, end);
+ // printf("IOMEM %"PRIx64"-%"PRIx64"\n",
start, end);
ret = flask_add_iomem(xch, start, end, argv[2]);
if (ret) {
- fprintf(stderr, "flask_add_iomem %lx-%lx failed: %d\n",
+ fprintf(stderr, "flask_add_iomem
%"PRIx64"-%"PRIx64" failed: %d\n",
start, end, ret);
err = 2;
}
@@ -104,12 +105,12 @@ int main (int argCnt, char *argv[])
f = fopen(buf, "r");
if (!f)
goto done;
- start = 0;
- fscanf(f, "%ld", &start);
+ if (fscanf(f, "%" SCNu64, &start) != 1)
+ start = 0;
if (start) {
ret = flask_add_pirq(xch, start, argv[2]);
if (ret) {
- fprintf(stderr, "flask_add_pirq %ld failed: %d\n",
+ fprintf(stderr, "flask_add_pirq %"PRIu64" failed: %d\n",
start, ret);
err = 2;
}
--
1.7.7.3