Despite this array living in an __init function, having such be an
automatic variable is rather inefficient in terms of generated code.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
--- a/xen/drivers/passthrough/amd/iommu_detect.c
+++ b/xen/drivers/passthrough/amd/iommu_detect.c
@@ -66,7 +66,7 @@ void __init get_iommu_features(struct am
{
u32 low, high;
int i = 0 ;
- char * feature_str[] = {
+ static const char *__initdata feature_str[] = {
"- Prefetch Pages Command",
"- Peripheral Page Service Request",
"- X2APIC Supported",
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
On Thursday 01 December 2011 12:56:36 Jan Beulich wrote:> Despite this array living in an __init function, having such be an > automatic variable is rather inefficient in terms of generated code. > > Signed-off-by: Jan Beulich <jbeulich@suse.com> > > --- a/xen/drivers/passthrough/amd/iommu_detect.c > +++ b/xen/drivers/passthrough/amd/iommu_detect.c > @@ -66,7 +66,7 @@ void __init get_iommu_features(struct am > { > u32 low, high; > int i = 0 ; > - char * feature_str[] = { > + static const char *__initdata feature_str[] = { > "- Prefetch Pages Command", > "- Peripheral Page Service Request", > "- X2APIC Supported",Acked, thanks, Wei