Hello, I''d like to give back to the community by sharing my Puppet modules. They are FreeBSD but I am helping I just finished putting all of them up at Github <http://github.com/eshao/puppet>, and would like some advice. 1) Would someone be kind enough to go through my code and comment on: a) Code quality -- How can I improve? Is it quality enough to merit releasing to the public (in a beta form)? b) Documentation quality -- Which parts are the most confusing? c) Security -- Did I expose myself to any vulnerabilities given the information currently released? Do I need to redact any additional information? 2) Assuming the quality is high enough, how do I market it? a) Add a link on Wiki -- I assume I don''t have the necessary permissions to do so myself and am not sure which pages need to be updated, so if someone could do this for me, it''d be appreciated. b) ??? -- Anything else I need to do? And, of course, patches are welcome. Thanks, Edwin --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Puppet Users" group. To post to this group, send email to puppet-users@googlegroups.com To unsubscribe from this group, send email to puppet-users+unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/puppet-users?hl=en -~----------~----~----~----~------~----~------~--~---
Le dimanche 15 novembre 2009 à 07:51 -0800, Edwin Shao a écrit :> Hello, > > I''d like to give back to the community by sharing my Puppet modules. > They are FreeBSD but I am helping I just finished putting all of them > up at Github <http://github.com/eshao/puppet>, and would like some > advice. > > 1) Would someone be kind enough to go through my code and comment on: > a) Code quality -- How can I improve? Is it quality enough to merit > releasing to the public (in a beta form)? > b) Documentation quality -- Which parts are the most confusing? > c) Security -- Did I expose myself to any vulnerabilities given the > information currently released? Do I need to redact any additional > information? > > 2) Assuming the quality is high enough, how do I market it? > a) Add a link on Wiki -- I assume I don''t have the necessary > permissions to do so myself and am not sure which pages need to be > updated, so if someone could do this for me, it''d be appreciated. > b) ??? -- Anything else I need to do?Nice set of modules ! For the documentation question, the wiki has an answer : http://www.reductivelabs.com/trac/puppet/wiki/PuppetManifestDocumentation I don''t see any sensible data leaking, but you may remove your mail address from tagmail.conf to avoid spam ;) Regards, Nico.
Thanks for the feedback.> For the documentation question, the wiki has an answer :http://www.reductivelabs.com/trac/puppet/wiki/PuppetManifestDocumentationI don''t want to document every single module, as I think most of them are self-explanatory. Just the major points of confusion. Do you have any suggestions on which modules need the documentation the most?> I don''t see any sensible data leaking, but you may remove your mailaddress from tagmail.conf to avoid spam ;) Will do. 2009/11/16 Nicolas Szalay <nszalay@qualigaz.com>> Le dimanche 15 novembre 2009 à 07:51 -0800, Edwin Shao a écrit : > > Hello, > > > > I''d like to give back to the community by sharing my Puppet modules. > > They are FreeBSD but I am helping I just finished putting all of them > > up at Github <http://github.com/eshao/puppet>, and would like some > > advice. > > > > 1) Would someone be kind enough to go through my code and comment on: > > a) Code quality -- How can I improve? Is it quality enough to merit > > releasing to the public (in a beta form)? > > b) Documentation quality -- Which parts are the most confusing? > > c) Security -- Did I expose myself to any vulnerabilities given the > > information currently released? Do I need to redact any additional > > information? > > > > 2) Assuming the quality is high enough, how do I market it? > > a) Add a link on Wiki -- I assume I don''t have the necessary > > permissions to do so myself and am not sure which pages need to be > > updated, so if someone could do this for me, it''d be appreciated. > > b) ??? -- Anything else I need to do? > > Nice set of modules ! > > For the documentation question, the wiki has an answer : > http://www.reductivelabs.com/trac/puppet/wiki/PuppetManifestDocumentation > > I don''t see any sensible data leaking, but you may remove your mail > address from tagmail.conf to avoid spam ;) > > Regards, > > Nico. >--~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Puppet Users" group. To post to this group, send email to puppet-users@googlegroups.com To unsubscribe from this group, send email to puppet-users+unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/puppet-users?hl=en -~----------~----~----~----~------~----~------~--~---
Hi Edwin,> a) Add a link on Wiki -- I assume I don''t have the necessary > permissions to do so myself and am not sure which pages need to be > updated, so if someone could do this for me, it''d be appreciated.Its great to hear that you want to contribute your modules. I have just added a PuppetModules link to the sidebar. All that you need is an account to edit the wiki. You can create a link to your gitrepo there. regards, Dan On Mon, Nov 16, 2009 at 2:43 AM, Edwin Shao <eshao@ring0.org> wrote:> Thanks for the feedback. > > > > For the documentation question, the wiki has an answer :http://www.reductivelabs.com/trac/puppet/wiki/PuppetManifestDocumentation > I don''t want to document every single module, as I think most of them are > self-explanatory. Just the major points of confusion. Do you have any > suggestions on which modules need the documentation the most? > > > > I don''t see any sensible data leaking, but you may remove your mail > address from tagmail.conf to avoid spam ;) > Will do. > > > > 2009/11/16 Nicolas Szalay <nszalay@qualigaz.com> > > Le dimanche 15 novembre 2009 à 07:51 -0800, Edwin Shao a écrit : >> > Hello, >> > >> > I''d like to give back to the community by sharing my Puppet modules. >> > They are FreeBSD but I am helping I just finished putting all of them >> > up at Github <http://github.com/eshao/puppet>, and would like some >> > advice. >> > >> > 1) Would someone be kind enough to go through my code and comment on: >> > a) Code quality -- How can I improve? Is it quality enough to merit >> > releasing to the public (in a beta form)? >> > b) Documentation quality -- Which parts are the most confusing? >> > c) Security -- Did I expose myself to any vulnerabilities given the >> > information currently released? Do I need to redact any additional >> > information? >> > >> > 2) Assuming the quality is high enough, how do I market it? >> > a) Add a link on Wiki -- I assume I don''t have the necessary >> > permissions to do so myself and am not sure which pages need to be >> > updated, so if someone could do this for me, it''d be appreciated. >> > b) ??? -- Anything else I need to do? >> >> Nice set of modules ! >> >> For the documentation question, the wiki has an answer : >> http://www.reductivelabs.com/trac/puppet/wiki/PuppetManifestDocumentation >> >> I don''t see any sensible data leaking, but you may remove your mail >> address from tagmail.conf to avoid spam ;) >> >> Regards, >> >> Nico. >> > > > > >--~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Puppet Users" group. To post to this group, send email to puppet-users@googlegroups.com To unsubscribe from this group, send email to puppet-users+unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/puppet-users?hl=en -~----------~----~----~----~------~----~------~--~---
Thanks, are there any other pages on the Wiki I need to update, or is that it? Besides the Wiki, are there any other websites I should be listing/marketing my modules/configurations on? - Edwin On Mon, Nov 16, 2009 at 8:25 PM, Dan Bode <dan@reductivelabs.com> wrote:> Hi Edwin, > > > > a) Add a link on Wiki -- I assume I don''t have the necessary > > permissions to do so myself and am not sure which pages need to be > > updated, so if someone could do this for me, it''d be appreciated. > > Its great to hear that you want to contribute your modules. I have just > added a PuppetModules link to the sidebar. All that you need is an account > to edit the wiki. > > You can create a link to your gitrepo there. > > regards, > > Dan > > > > On Mon, Nov 16, 2009 at 2:43 AM, Edwin Shao <eshao@ring0.org> wrote: > >> Thanks for the feedback. >> >> >> > For the documentation question, the wiki has an answer :http://www.reductivelabs.com/trac/puppet/wiki/PuppetManifestDocumentation >> I don''t want to document every single module, as I think most of them are >> self-explanatory. Just the major points of confusion. Do you have any >> suggestions on which modules need the documentation the most? >> >> >> > I don''t see any sensible data leaking, but you may remove your mail >> address from tagmail.conf to avoid spam ;) >> Will do. >> >> >> >> 2009/11/16 Nicolas Szalay <nszalay@qualigaz.com> >> >> Le dimanche 15 novembre 2009 à 07:51 -0800, Edwin Shao a écrit : >>> > Hello, >>> > >>> > I''d like to give back to the community by sharing my Puppet modules. >>> > They are FreeBSD but I am helping I just finished putting all of them >>> > up at Github <http://github.com/eshao/puppet>, and would like some >>> > advice. >>> > >>> > 1) Would someone be kind enough to go through my code and comment on: >>> > a) Code quality -- How can I improve? Is it quality enough to merit >>> > releasing to the public (in a beta form)? >>> > b) Documentation quality -- Which parts are the most confusing? >>> > c) Security -- Did I expose myself to any vulnerabilities given the >>> > information currently released? Do I need to redact any additional >>> > information? >>> > >>> > 2) Assuming the quality is high enough, how do I market it? >>> > a) Add a link on Wiki -- I assume I don''t have the necessary >>> > permissions to do so myself and am not sure which pages need to be >>> > updated, so if someone could do this for me, it''d be appreciated. >>> > b) ??? -- Anything else I need to do? >>> >>> Nice set of modules ! >>> >>> For the documentation question, the wiki has an answer : >>> http://www.reductivelabs.com/trac/puppet/wiki/PuppetManifestDocumentation >>> >>> I don''t see any sensible data leaking, but you may remove your mail >>> address from tagmail.conf to avoid spam ;) >>> >>> Regards, >>> >>> Nico. >>> >> >> >> >> > > > >--~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Puppet Users" group. To post to this group, send email to puppet-users@googlegroups.com To unsubscribe from this group, send email to puppet-users+unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/puppet-users?hl=en -~----------~----~----~----~------~----~------~--~---