Hi all, I''ve just pushed the second to last fix I''m planning for 0.24.4 (the last one will be #1138[1]), which is a disabling of http keep-alive to fix #1010. Given the destructive nature of #1010, I''d like to get this release out ASAP. Please test as soon as you can and let me know if there are issues. Here''s the changelog so far: Disabling http keep-alive as a means of preventing #1010. There is now a constant in Puppet::Network::HttpPool that will disable or enable this feature, but note that we determined that it can cause corruption, especially in file serving (but it''s client-side corruption). Applying patch by Ryan McBride to fix OpenBSD package matching. The actual problem was caused by the fix to #1001. Found all instances of methods where split() is used without any local variables and added a local variable -- see http://snurl.com/21zf8. My own testing showed that this caused memory growth to level off at a reasonable level. Note that the link above says the problem is only with class methods, but my own testing showed that it''s any method that meets these criteria. This is not a functional change, but should hopefully be the last nail in the coffin of #1131. Found an array that leaked pretty quickly between reparsing files, thanks to work by Adam Jacob and Arjuna Christenson (the finding, not the leak). I''m going to act like this fixes #1131, at least for now, but I doubt it does, since that shows general memory growth over time, whereas the leak here should go away as soon as files are reparsed (because the parser is holding the reference to the leaking array). Fixed #1147: Cached nodes are correctly considered out of date if the node facts have been updated (thus causing node facts to again be available in manifests, for those cases where they were not). Fixed #1137: The certificate name is correctly being added to the facts hash. Fixed #1136: Verbose and Debug no longer clobber each other. Hopefully *finally* fixed the "already being managed" problem (#1036). The problem only cropped up if there was a failure when trying to manage the system -- this would cause the setting-based resources not to get cleaned up. 1 - http://reductivelabs.com/trac/puppet/ticket/1138 -- Health is merely the slowest possible rate at which one can die. --------------------------------------------------------------------- Luke Kanies | http://reductivelabs.com | http://madstop.com --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Puppet Users" group. To post to this group, send email to puppet-users@googlegroups.com To unsubscribe from this group, send email to puppet-users-unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/puppet-users?hl=en -~----------~----~----~----~------~----~------~--~---
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Luke Kanies wrote: | Hi all, | | I''ve just pushed the second to last fix I''m planning for 0.24.4 (the | last one will be #1138[1]), which is a disabling of http keep-alive to | fix #1010. | Man pages? Regards James - -- James Turnbull (james@lovedthanlost.net) - -- Author of: - - Pulling Strings with Puppet (http://www.amazon.com/gp/product/1590599780/) - - Pro Nagios 2.0 (http://www.amazon.com/gp/product/1590596099/) - - Hardening Linux (http://www.amazon.com/gp/product/1590594444/) -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (Darwin) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFH6BDz9hTGvAxC30ARAlDLAKCRDE284taBmPlrxBWYhaUrU3y2ugCfVQjw WMR1u7e0C/Po7XwVjKhIJxo=VhRK -----END PGP SIGNATURE----- --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Puppet Users" group. To post to this group, send email to puppet-users@googlegroups.com To unsubscribe from this group, send email to puppet-users-unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/puppet-users?hl=en -~----------~----~----~----~------~----~------~--~---
On Mar 24, 2008, at 3:37 PM, James Turnbull wrote:> Luke Kanies wrote: > | Hi all, > | > | I''ve just pushed the second to last fix I''m planning for 0.24.4 (the > | last one will be #1138[1]), which is a disabling of http keep- > alive to > | fix #1010. > | > Man pages?Hmm, your commit (5a3195941375645f1e0949b02bbfe5bd29816767) is in the 0.24.x, but you''re right that the man pages aren''t there. What am I missing? -- There are no such things as applied sciences, only applications of science. -- Louis Pasteur --------------------------------------------------------------------- Luke Kanies | http://reductivelabs.com | http://madstop.com --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Puppet Users" group. To post to this group, send email to puppet-users@googlegroups.com To unsubscribe from this group, send email to puppet-users-unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/puppet-users?hl=en -~----------~----~----~----~------~----~------~--~---
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Luke Kanies wrote: | On Mar 24, 2008, at 3:37 PM, James Turnbull wrote: | |> Luke Kanies wrote: |> | Hi all, |> | |> | I''ve just pushed the second to last fix I''m planning for 0.24.4 (the |> | last one will be #1138[1]), which is a disabling of http keep- |> alive to |> | fix #1010. |> | |> Man pages? | | | Hmm, your commit (5a3195941375645f1e0949b02bbfe5bd29816767) is in the | 0.24.x, but you''re right that the man pages aren''t there. I added the pages in two commits: the creation logic: e5b16b26fff6b8b358975d27d46a274407891a69 the man pages and install logic: 5a3195941375645f1e0949b02bbfe5bd29816767 I just checked the diff and they are all in the latter commit. James - -- James Turnbull (james@lovedthanlost.net) - -- Author of: - - Pulling Strings with Puppet (http://www.amazon.com/gp/product/1590599780/) - - Pro Nagios 2.0 (http://www.amazon.com/gp/product/1590596099/) - - Hardening Linux (http://www.amazon.com/gp/product/1590594444/) -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (Darwin) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFH6BNv9hTGvAxC30ARAprgAKCsXJ4f2JLXFcdMl2PkdjJniHeEKgCglYpx JIStIANiem/qJ4VFRCDpcmw=SHqF -----END PGP SIGNATURE----- --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Puppet Users" group. To post to this group, send email to puppet-users@googlegroups.com To unsubscribe from this group, send email to puppet-users-unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/puppet-users?hl=en -~----------~----~----~----~------~----~------~--~---
On Mar 24, 2008, at 3:47 PM, James Turnbull wrote:> I added the pages in two commits: > > the creation logic: e5b16b26fff6b8b358975d27d46a274407891a69 > the man pages and install logic: > 5a3195941375645f1e0949b02bbfe5bd29816767 > > I just checked the diff and they are all in the latter commit.Duh, sorry; they''re all there. I just didn''t look in the subdirectory because I''m apparently blind and stupid. -- Work is not always required. There is such a thing as sacred idleness. -- George MacDonald --------------------------------------------------------------------- Luke Kanies | http://reductivelabs.com | http://madstop.com --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Puppet Users" group. To post to this group, send email to puppet-users@googlegroups.com To unsubscribe from this group, send email to puppet-users-unsubscribe@googlegroups.com For more options, visit this group at http://groups.google.com/group/puppet-users?hl=en -~----------~----~----~----~------~----~------~--~---