Vorbis dev - Mar 2008 - Souffleur project patches

Dear all,

    It's been a while since I have started to look at the code for
Souffleur that was dropped a couple of years ago by its former
maintainer. I have now a few patches that I would like to be committed
to the trunk of this project if approved.

    I am sorry if the modifications are not aligned with the project's
main purpose but I had no one to talk to about its main goal.
Modifications to the GUI were made and due to that, probably the project
functionality.

    Here is are the patches for each file and what they do so far:

        -> GPlayer.py.diff

                Changes the default playbin video sink to autovideosink
with textoverlay.
                This change was done because GStreamer does not support
all kinds of subtitles yet and I do not expect to be dependent on
GStreamer subtitle support development

        -> MediaInfo.py.diff

                Fixed broken import message

        -> souffleur.glade.diff

                A general GUI cleanup to make it look simpler

        -> Souffleur.py.diff

                Adapted the code to use new GPlayer.py functionality
                Added a gobject.source_remove for update polling
callback when video stream is paused
                Added a new column to the subtitles ListStore to display
subtitle number

    Please beware that I am not an experienced programmer and this is my
first contribution to an opensource project.
    Critiques are more then welcome! :-)

Thank you,

Mesquita
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
http://lists.xiph.org/pipermail/vorbis-dev/attachments/20080326/af987cb6/attachment-0001.htm
-------------- next part --------------
A non-text attachment was scrubbed...
Name: GPlayer.py.diff
Type: text/x-patch
Size: 1497 bytes
Desc: not available
Url :
http://lists.xiph.org/pipermail/vorbis-dev/attachments/20080326/af987cb6/attachment-0004.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: MediaInfo.py.diff
Type: text/x-patch
Size: 295 bytes
Desc: not available
Url :
http://lists.xiph.org/pipermail/vorbis-dev/attachments/20080326/af987cb6/attachment-0005.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: souffleur.glade.diff
Type: text/x-patch
Size: 61861 bytes
Desc: not available
Url :
http://lists.xiph.org/pipermail/vorbis-dev/attachments/20080326/af987cb6/attachment-0006.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Souffleur.py.diff
Type: text/x-patch
Size: 7993 bytes
Desc: not available
Url :
http://lists.xiph.org/pipermail/vorbis-dev/attachments/20080326/af987cb6/attachment-0007.bin

On 26/03/2008, Jo?o Mesquita <jmesquita at contactnet.com.br>
wrote:
>
Hola!
>      I am sorry if the modifications are not aligned with the project's
main
> purpose but I had no one to talk to about its main goal.
It was a Summer of Code project 2 years ago, and the student
disappeared partway through the project :-( I was the mentor for that
project, I still feel sad to see code go unloved.

So, I'm really glad that you've found this project and are working on it
:-)
>      Here is are the patches for each file and what they do so far:
...
>      Please beware that I am not an experienced programmer and this is my
> first contribution to an opensource project.
>      Critiques are more then welcome! :-)
They seem like good patches. I haven't tried to run it, but it
definitely looks like the patches do what you said they do :-) Thanks
for the clear explanations for each patch, that is exactly the kind of
detail that should go with every code change.

So, I've committed them, along with your explanations, in changesets
14636-14639. Keep up the good work :-)

cheers,

Conrad.