Vorbis dev - Aug 2000 - libao patch: Endian-ness fix

[Oops.  Sent this to the wrong list.]

Kenneth already appears to have committed a byte order fix for the WAV output
driver.  Attached is a patch to fix byte order in the OSS and ALSA drivers.  The
other output drivers seem to just use the native byte order (which libvorbisfile
uses).

As I do not have anything but Linux systems on Intel hardware at my disposal, I
would really appreciate it if someone could test ogg123 on a big endian system
(after applying this patch) with OSS or ALSA.  I still have no idea if this code
works on anything but x86 Linux w/ OSS, ESD, and ALSA.

[Note: This patch also fixes some compiler warnings.]

-- 

Stan Seibert


<HR NOSHADE>
<UL>
<LI>application/octet-stream attachment: endian.patch
</UL>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: endian.patch
Type: application/octet-stream
Size: 4708 bytes
Desc: not available
Url :
http://lists.xiph.org/pipermail/vorbis-dev/attachments/20000807/23670523/endian-0001.obj

>Kenneth already appears to have committed a byte order fix for the WAV
output
>driver.  
That was me, actually - I rewrote most of the wav writing code because it
was a) broken on x86 and other 32bit/LE systems, and b) much more broken on
everything else.
>Attached is a patch to fix byte order in the OSS and ALSA drivers.  The
>other output drivers seem to just use the native byte order (which
libvorbisfile
>uses).
Nope. Vorbisfile returns data with the specified endianness - ogg123
requests it as little endian. The patch may or may not be wrong (I don't
know enough about how OSS (or ALSA) works to know) - but if it is correct
then a similar change is needed in ogg123 - otherwise it will definately be
broken.
>[Note: This patch also fixes some compiler warnings.]
Seperate these out, and I'll commit them for you.

Michael

--- >8 ----
List archives:  http://www.xiph.org/archives/
Ogg project homepage: http://www.xiph.org/ogg/