Hi folks, I'd like to remind people with write access on the CVS mainline not to put any tools/libs/patches into the main build that are not portable... I'm getting not-very-pretty flames from NetBSD folks because libao fails to *configure* under NetBSD (let alone build), thus breaking building the build for the entire CVS mainline. Specifically:>checking size of int... (cached) 4 >checking size of long... (cached) 4 >i386-unknown-netbsd1.4.2A is not currently supported by libao >configure: error: ./configure failed for vorbis-tools/libao >xanthine:/gb/src/vorbis$Aborting the entire build becuase a single tool doesn't work is not good. Actually, since we're on the subject, the core CVS module for Vorbis is getting big and sprawling. I'm thinking it may be time to start spinning off the tools and plugins into other CVS modules in order to compartmentalize maintainance of this kind of woe. Monty Monty --- >8 ---- List archives: http://www.xiph.org/archives/ Ogg project homepage: http://www.xiph.org/ogg/
> I'd like to remind people with write access on the CVS mainline not to put any > tools/libs/patches into the main build that are not portable... I'm getting > not-very-pretty flames from NetBSD folks because libao fails to *configure* > under NetBSD (let alone build), thus breaking building the build for the > entire CVS mainline.Oops. Sorry about that. I've attached a patch (I'm the guilty author of the code, but I don't have CVS access) that should fix the libao configure script to never die like that. libao still won't get compiled unless the user uncomments that dir tree in the Makefile.in> Actually, since we're on the subject, the core CVS module for Vorbis is > getting big and sprawling. I'm thinking it may be time to start spinning off > the tools and plugins into other CVS modules in order to compartmentalize > maintainance of this kind of woe.Sounds good. I really don't want to take down the tree again. :) Here's the patch: Index: vorbis-tools/libao/configure ==================================================================RCS file: /usr/local/cvsroot/vorbis/vorbis-tools/libao/configure,v retrieving revision 1.1 diff -u -r1.1 configure --- vorbis-tools/libao/configure 2000/07/22 01:57:05 1.1 +++ vorbis-tools/libao/configure 2000/07/28 14:40:40 @@ -1291,15 +1291,15 @@ esac if test -z "$SIZE16"; then - { echo "configure: error: No 16 bit type found on this platform!" 1>&2; exit 1; } + echo "configure: warning: No 16 bit type found on this platform!" 1>&2 fi if test -z "$SIZE32"; then - { echo "configure: error: No 32 bit type found on this platform!" 1>&2; exit 1; } + echo "configure: warning: No 32 bit type found on this platform!" 1>&2 fi case $host in - *-*-linux*|*-openbsd*|*-freebsd*) + *-*-linux*|*-openbsd*|*-freebsd*|*-netbsd*) LIBAO_OBJS="$LIBAO_OBJS ao_oss.o" LIBAO_FLAGS="$LIBAO_FLAGS -DAO_COMPILE_OSS -DAO_DEFAULT=AO_OSS";; *-irix*) @@ -1310,7 +1310,7 @@ LIBAO_OBJS="$LIBAO_OBJS ao_solaris.o" LIBAO_FLAGS="$LIBAO_FLAGS -DAO_COMPILE_SOLARIS -DAO_DEFAULT=AO_SOLARIS";; - *) echo "$host is not currently supported by libao"; exit 1;; + *) echo "configure: warning: Native sound driver not supported for this operating system." 1>&2;; esac Index: vorbis-tools/libao/configure.in ==================================================================RCS file: /usr/local/cvsroot/vorbis/vorbis-tools/libao/configure.in,v retrieving revision 1.1 diff -u -r1.1 configure.in --- vorbis-tools/libao/configure.in 2000/07/22 01:57:05 1.1 +++ vorbis-tools/libao/configure.in 2000/07/28 14:40:40 @@ -85,17 +85,17 @@ esac if test -z "$SIZE16"; then - AC_MSG_ERROR(No 16 bit type found on this platform!) + AC_MSG_WARN(No 16 bit type found on this platform!) fi if test -z "$SIZE32"; then - AC_MSG_ERROR(No 32 bit type found on this platform!) + AC_MSG_WARN(No 32 bit type found on this platform!) fi dnl --- Figure out which ao_* files to compile --- dnl Operating System Specific Files case $host in - *-*-linux*|*-openbsd*|*-freebsd*) + *-*-linux*|*-openbsd*|*-freebsd*|*-netbsd*) LIBAO_OBJS="$LIBAO_OBJS ao_oss.o" LIBAO_FLAGS="$LIBAO_FLAGS -DAO_COMPILE_OSS -DAO_DEFAULT=AO_OSS";; *-irix*) @@ -106,7 +106,7 @@ LIBAO_OBJS="$LIBAO_OBJS ao_solaris.o" LIBAO_FLAGS="$LIBAO_FLAGS -DAO_COMPILE_SOLARIS -DAO_DEFAULT=AO_SOLARIS";; - *) echo "$host is not currently supported by libao"; exit 1;; + *) AC_MSG_WARN(Native sound driver not supported by libao for this operating system.);; esac dnl ESounD --- >8 ---- List archives: http://www.xiph.org/archives/ Ogg project homepage: http://www.xiph.org/ogg/
Hello,>Actually, since we're on the subject, the core CVS module for Vorbis is >getting big and sprawling. I'm thinking it may be time to start spinning off >the tools and plugins into other CVS modules in order to compartmentalize >maintainance of this kind of woeMaybe we should put the plugins all in _one_ directory? vorbis/plugins: kmpg/ xmms/ winampe/ tools/ etc.. This makes it clear that they do not belong to the mainline. I think at least until vorbis 1.0 (including 1.0) the plugins should stay _in_ vorbis. After 1.0 (when everything is stable for a longer time) remove the plugins/put them in a seperate module. regards, Martin --- >8 ---- List archives: http://www.xiph.org/archives/ Ogg project homepage: http://www.xiph.org/ogg/
On Thu, Jul 27, 2000 at 08:50:29PM -0700, Monty wrote:> > Hi folks, > > I'd like to remind people with write access on the CVS mainline not to put any > tools/libs/patches into the main build that are not portable... I'm getting > not-very-pretty flames from NetBSD folks because libao fails to *configure* > under NetBSD (let alone build), thus breaking building the build for the > entire CVS mainline. > > Specifically: > > >checking size of int... (cached) 4 > >checking size of long... (cached) 4 > >i386-unknown-netbsd1.4.2A is not currently supported by libao > >configure: error: ./configure failed for vorbis-tools/libao > >xanthine:/gb/src/vorbis$ > > Aborting the entire build becuase a single tool doesn't work is not good.I'm committing a little modification for netbsd specifically, but since I have no experience with autoconf and m4, a general solution will have to wait until my guess-and-check work pays off... Could the NetBSD folks try out the latest commit?> Actually, since we're on the subject, the core CVS module for Vorbis is > getting big and sprawling. I'm thinking it may be time to start spinning off > the tools and plugins into other CVS modules in order to compartmentalize > maintainance of this kind of woe.Agreed. But then we must make sure that Vorbis is installed in a standard place. And I really want a shared library... could any suggested modifications to the _interface_ be done soon, but as wrappers around the old functions until they are actually implemented? Or perhaps a versioning header, even pre-1.0, is in order. Kenneth __________________________________________________ Do You Yahoo!? Talk to your friends online with Yahoo! Messenger. http://im.yahoo.com --- >8 ---- List archives: http://www.xiph.org/archives/ Ogg project homepage: http://www.xiph.org/ogg/