Hi all! What is the right way to report bugs in libopus? I couldn't find any publicly available bugtracker. Anyway, the problem I need to report is that some source files in libopus are missing copyright headers. This breaks license check script that we use in chromium to validate licenses for third-party dependencies. Specifically the following files don't have copyright header: ./src/opus_compare.c ./src/mlp_data.c ./celt/tests/test_unit_dft.c ./celt/tests/test_unit_mathops.c ./celt/tests/test_unit_entropy.c ./celt/tests/test_unit_types.c ./celt/tests/test_unit_rotation.c ./celt/tests/test_unit_laplace.c ./celt/tests/test_unit_mdct.c ./celt/tests/test_unit_cwrs32.c ./autogen.sh ./win32/config.h ./tests/run_vectors.sh ./doc/build_draft.sh ./doc/build_oggdraft.sh Thanks! -- Sergey Ulanov
Hi, I just checked in licenses for the files you listed below. Also, I can't help but notice the mlp_data.c file which is only in master. You're aware that this is a development branch and that we sometimes (though not that often) break things, right? Jean-Marc On 12-10-18 09:22 PM, Sergey Ulanov wrote:> Hi all! > What is the right way to report bugs in libopus? I couldn't find any > publicly available bugtracker. > Anyway, the problem I need to report is that some source files in > libopus are missing copyright headers. This breaks license check > script that we use in chromium to validate licenses for third-party > dependencies. Specifically the following files don't have copyright > header: > > ./src/opus_compare.c > ./src/mlp_data.c > ./celt/tests/test_unit_dft.c > ./celt/tests/test_unit_mathops.c > ./celt/tests/test_unit_entropy.c > ./celt/tests/test_unit_types.c > ./celt/tests/test_unit_rotation.c > ./celt/tests/test_unit_laplace.c > ./celt/tests/test_unit_mdct.c > ./celt/tests/test_unit_cwrs32.c > ./autogen.sh > ./win32/config.h > ./tests/run_vectors.sh > ./doc/build_draft.sh > ./doc/build_oggdraft.sh > > Thanks! > > -- > Sergey Ulanov > _______________________________________________ > opus mailing list > opus at xiph.org > http://lists.xiph.org/mailman/listinfo/opus > > >
Sergey, I've pushed a version of your OPUS_EXPORT fix to the opus repo. Can you please test your build against git://git.xiph.org/opus.git at 1.0.x and verify your issues have been resolved? I'd like to release what we have there as 1.0.2 in a few days. BTW, the WORDS_BIGENDIAN define in chromium's opus.gyp is wrong. This has no effect because the opus code doesn't use the symbol, but since x86 and arm-android are little endian, it definitely shouldn't unconditional. I suggest removing it. Also, the opus.h wrapper in http://src.chromium.org/svn/trunk/third_party/opus/opus.h seems to be redundant. If USE_SYSTEM_OPUS isn't defined, opus.gyp only exports -Isrc/include to dependencies, and if it _is_ defined, it exports whatever pkg-config returns for the system include path. In neither case will this header be picked up; I suggest just removing the file. -r