Nouveau - Nov 2012 - Fix for vblank on nvc0

The vblank on nvc0 was not working correctly and would freeze X, I managed
to track it down and fix it with some help from m.b.lankhorst, see
https://bugs.freedesktop.org/show_bug.cgi?id=56692 for details.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20121106/27ceb48e/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: nvc0_vblank_fix.patch
Type: application/octet-stream
Size: 1647 bytes
Desc: not available
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20121106/27ceb48e/attachment.obj>

Op 06-11-12 15:48, Kelly Doran schreef:
> The vblank on nvc0 was not working correctly and would freeze X, I managed
> to track it down and fix it with some help from m.b.lankhorst, see
> https://bugs.freedesktop.org/show_bug.cgi?id=56692 for details.
>
Reviewed-by: Maarten Lankhorst <maarten.lankhorst at canonical.com>

I recommended the bar flush since nvd0 does as well, and there might be a small
race
otherwise.

Can this still get in before final 3.7 release?

~Maarten

I had Sven test this patch... he said it works.  I think chipset
number test was executing code that we thought was only either 0x50 or
0xc0, but was actually more specific with things like 0x92.

On Sun, Nov 11, 2012 at 2:25 PM, Maarten Lankhorst
<maarten.lankhorst at canonical.com> wrote:
> Op 11-11-12 19:35, Marcin Slusarz schreef:
>> On Sun, Nov 11, 2012 at 07:26:17PM +0100, Marcin Slusarz wrote:
>>> On Tue, Nov 06, 2012 at 07:30:00PM +0100, Maarten Lankhorst wrote:
>>>>
>>>> Op 06-11-12 15:48, Kelly Doran schreef:
>>>>> The vblank on nvc0 was not working correctly and would
freeze X, I managed
>>>>> to track it down and fix it with some help from
m.b.lankhorst, see
>>>>> https://bugs.freedesktop.org/show_bug.cgi?id=56692 for
details.
>>>>>
>>>> Reviewed-by: Maarten Lankhorst <maarten.lankhorst at
canonical.com>
>>>>
>>>> I recommended the bar flush since nvd0 does as well, and there
might be a small race
>>>> otherwise.
>>>>
>>>> Can this still get in before final 3.7 release?
>>> This patch breaks vblank here (nv92) completely.
> Does removing the bar flush help?
>
> ~Maarte
-------------- next part --------------
A non-text attachment was scrubbed...
Name: vblank-fix1.patch
Type: application/octet-stream
Size: 1474 bytes
Desc: not available
URL:
<http://lists.freedesktop.org/archives/nouveau/attachments/20121112/827f06ae/attachment.obj>

Op 12-11-12 22:30, Kelly Doran schreef:
> I had Sven test this patch... he said it works.  I think chipset
> number test was executing code that we thought was only either 0x50 or
> 0xc0, but was actually more specific with things like 0x92.
>
Oh right vblank is busted anyway... needs to be nv_device(priv-)>card_type ==
NV_50 to work.

Your patch is the correct fix.

~Maarten