Jeff Bailey
2006-Dec-20 03:49 UTC
[klibc] Patch to klibc to work with headers from make install_headers
Hi! Now that there are usable userspace headers, we should use the data from those. In this case, the workaround in usr/include/sys/types.h was missing some header definitions. Rather than adding the definitions, I figured that the most correct thing to do was to just use them from the kernel. Build tested on i386 and x86_64. Signed-Off-By: Jeff Bailey <jbailey at ubuntu.com> -- Jeff Bailey - http://www.raspberryginger.com/jbailey/ -------------- next part -------------- A non-text attachment was scrubbed... Name: klibc-userspace-headers.patch Type: application/octet-stream Size: 4590 bytes Desc: not available Url : http://www.zytor.com/pipermail/klibc/attachments/20061219/150a7fc2/attachment.obj
Colin Watson
2006-Dec-21 03:25 UTC
[klibc] Patch to klibc to work with headers from make install_headers
On Tue, Dec 19, 2006 at 10:49:30PM -0500, Jeff Bailey wrote:> Hi! Now that there are usable userspace headers, we should use the > data from those. In this case, the workaround in > usr/include/sys/types.h was missing some header definitions. Rather > than adding the definitions, I figured that the most correct thing to > do was to just use them from the kernel.FYI, this broke fstype on Ubuntu because klibc's internal usr/include/sys/types.h has "typedef __kernel_loff_t off_t;" (sic) whereas <linux/types.h> has "typedef __kernel_off_t off_t;", and usr/klibc/SYSCALLS.def uses off_t for a bunch of syscalls with 32/64-bit alternatives where the kernel uses loff_t for the 64-bit version. Changing these all to loff_t might work, since that's what the kernel was doing anyway, but in the meantime I just backed out the patch from Ubuntu. Cheers, -- Colin Watson [cjwatson at ubuntu.com]
H. Peter Anvin
2007-Jan-16 03:56 UTC
[klibc] Patch to klibc to work with headers from make install_headers
Jeff Bailey wrote:> Hi! Now that there are usable userspace headers, we should use the > data from those. In this case, the workaround in > usr/include/sys/types.h was missing some header definitions. Rather > than adding the definitions, I figured that the most correct thing to > do was to just use them from the kernel. > > Build tested on i386 and x86_64. > > Signed-Off-By: Jeff Bailey <jbailey at ubuntu.com>By the way, Jeff -- sorry for the huge delay in getting back to you on this -- what is actually missing? -hpa