openssh bugs - Aug 2012 - [Bug 2039] New: Give proper credits for ECDSA patch

https://bugzilla.mindrot.org/show_bug.cgi?id=2039

          Priority: P5
            Bug ID: 2039
          Assignee: unassigned-bugs at mindrot.org
           Summary: Give proper credits for ECDSA patch
          Severity: normal
    Classification: Unclassified
                OS: All
          Reporter: ondrej at sury.org
          Hardware: All
            Status: NEW
           Version: 6.1p1
         Component: Documentation
           Product: Portable OpenSSH

Hi,

ChangeLog for 6.1p1 says:

   - djm at cvs.openbsd.org 2012/05/23 03:28:28
     [dns.c dns.h key.c key.h ssh-keygen.c]
     add support for RFC6594 SSHFP DNS records for ECDSA key types.
     patch from bugzilla-m67 AT nulld.me in bz#1978; ok + tweak markus@

while the patch from the bug report was created by me - Ond?ej Sur?
<ondrej at sury.org> - with contributions from Ond?ej Caletka and Daniel
Black, as you can confirm from the original source of the patch:
https://git.nic.cz/redmine/projects/ietf/repository/revisions/master/changes/ssh-sshfp-ecdsa.patch

Please fix in next release, thank you,
Ond?ej Sur?

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2039

Darren Tucker <dtucker at zip.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dtucker at zip.com.au
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #1 from Darren Tucker <dtucker at zip.com.au> ---
we can't retroactively change the commit message and that's what's
in
the ChangeLog, so I added a line following acknowledging the original
authorship.  Hope that's sufficient, it should be here:
http://anoncvs.mindrot.org/index.cgi/openssh/ChangeLog?r1=1.6109&r2=1.6110
once the anoncvs mirror catches up.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2039

Ond?ej Sur? <ondrej at sury.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |---

--- Comment #2 from Ond?ej Sur? <ondrej at sury.org> ---
The solution is ok with me, but just a small nit - you (or CVS) got my
name wrong in the patch.  The Latin-2 characters (?) are OK, but the
'?' in Sur? got mangled somehow to non-UTF-8 character (\303).


+     (Original authors Ond\305\231ej Sur\303,  Ond\305\231ej Caletka
and Daniel Black)                                                       

should be

+     (Original authors Ond\305\231ej Sur\303\275, Ond\305\231ej
Caletka and Daniel Black)

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2039

Darren Tucker <dtucker at zip.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Darren Tucker <dtucker at zip.com.au> ---
(In reply to comment #2)
> The solution is ok with me, but just a small nit - you (or CVS) got
> my name wrong in the patch.  The Latin-2 characters (?) are OK, but
> the '?' in Sur? got mangled somehow to non-UTF-8 character (\303).
Sorry about that, fixed (I think, od -ba shows the octal characters
above).

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2039

--- Comment #4 from Ond?ej Sur? <ondrej at sury.org> ---
LGTM, thank you very much!

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2039

Daniel Black <daniel.black at ovee.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |daniel.black at ovee.com.au

--- Comment #5 from Daniel Black <daniel.black at ovee.com.au> ---
thanks Darren and Ond?ej.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2039

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #6 from Damien Miller <djm at mindrot.org> ---
Set all RESOLVED bugs to CLOSED with release of OpenSSH 7.1

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.