Lustre devel - Jan 2007 - [Bug 11226] cleanup compiler waringins

Please don''t reply to lustre-devel. Instead, comment in Bugzilla by
using the following link:
https://bugzilla.lustre.org/show_bug.cgi?id=11226

           What    |Removed                     |Added
----------------------------------------------------------------------------
Attachment #8918 is|0                           |1
           obsolete|                            |


Created an attachment (id=9323)
Please don''t reply to lustre-devel. Instead, comment in Bugzilla by
using the following link:
 --> (https://bugzilla.lustre.org/attachment.cgi?id=9323&action=view)
update to last b1_4 and integrate adilger notes.

Please don''t reply to lustre-devel. Instead, comment in Bugzilla by
using the following link:
https://bugzilla.lustre.org/show_bug.cgi?id=11226

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #9323|review?(adilger@clusterfs.co|review+
               Flag|m)                          |


(From update of attachment 9323)
>@@ -1868,10 +1868,10 @@ int ll_obd_statfs(struct inode *inode, v
>         char *buf = NULL;
>         struct obd_ioctl_data *data = NULL;
>         __u32 type, index;
>-        int len, rc;
>+        int len = 0, rc;
> 
>         if (!inode || !(sbi = ll_i2sbi(inode)))
>-                GOTO(out_statfs, rc = -EINVAL);
>+                RETURN(-EINVAL);
> 
>         rc = obd_ioctl_getdata(&buf, &len, arg);
>         if (rc)
Fine.
>@@ -237,7 +237,7 @@ int qos_prep_create(struct lov_obd *lov,
>          * We can only get here if lsm_stripe_count was originally > 1.
>          */
>         if (!newea) {
>-                CERROR("can''t lstripe objid
"LPX64": have %u want %u, rc %d\n",
>+                CERROR("can''t lstripe objid
"LPX64": have "LPSZ" want %u, rc %d\n",
>                        lsm->lsm_object_id, set->set_count,
>                        lsm->lsm_stripe_count, rc);
I don''t understand this - set_count is an int?
>@@ -2735,3 +2734,4 @@ MODULE_LICENSE("GPL");
> 
> module_init(mds_init);
> module_exit(mds_exit);
>+
Don''t do this.
>@@ -365,7 +365,7 @@ int mds_init_ucred(struct lvfs_ucred *uc
> 
>         LASSERT(body != NULL); /* previously verified & swabbed by
caller */
> 
>-#if CRAY_XT3
>+#ifdef CRAY_XT3
>         if (req->rq_uid != LNET_UID_ANY) {
>                 /* Non-root local cluster client */
>                 LASSERT (req->rq_uid != 0);
>@@ -388,7 +388,7 @@ int mds_init_ucred(struct lvfs_ucred *uc
>                 return rc;
>         }
> 
>-#if CRAY_XT3
>+#ifdef CRAY_XT3
>         if (ucred->luc_uce)
>                 ucred->luc_fsgid = ucred->luc_uce->ue_primary;
> #endif
>@@ -2299,7 +2299,7 @@ int mds_reint_rec(struct mds_update_reco
>         int rc;
>         ENTRY;
> 
>-#if CRAY_XT3
>+#ifdef CRAY_XT3
>         if (req->rq_uid != LNET_UID_ANY) {
>                 /* non-root local cluster client
>                  * NB root''s creds are believed... */
>@@ -2324,7 +2324,7 @@ int mds_reint_rec(struct mds_update_reco
>         /* checked by unpacker */
>         LASSERT(rec->ur_opcode < REINT_MAX &&
reinters[rec->ur_opcode] != NULL);
> 
>-#if CRAY_XT3
>+#ifdef CRAY_XT3
>         if (rec->ur_uc.luc_uce)
>                 rec->ur_uc.luc_fsgid =
rec->ur_uc.luc_uce->ue_primary;
> #endif
Done already.

Please land to b1_4 and verify that the same changes exist in b1_5.