shadow@clusterfs.com
2006-Dec-28 14:54 UTC
[Lustre-devel] [Bug 11271] patches for patchless client at b1_5 branch
Please don''t reply to lustre-devel. Instead, comment in Bugzilla by using the following link: https://bugzilla.lustre.org/show_bug.cgi?id=11271 Created an attachment (id=9236) Please don''t reply to lustre-devel. Instead, comment in Bugzilla by using the following link: --> (https://bugzilla.lustre.org/attachment.cgi?id=9236&action=view) aio fixes don`t assign .aio_[read|write] and implement generic_file_[read|write] simular do_sync_[read|write] with direct call generic_file_aio_[read|write]. fix using panic_notifier_list at 2.6.19.
adilger@clusterfs.com
2006-Dec-29 02:20 UTC
[Lustre-devel] [Bug 11271] patches for patchless client at b1_5 branch
Please don''t reply to lustre-devel. Instead, comment in Bugzilla by using the following link: https://bugzilla.lustre.org/show_bug.cgi?id=11271 What |Removed |Added ---------------------------------------------------------------------------- Attachment #9236|review?(adilger@clusterfs.co|review+ Flag|m) | (From update of attachment 9236)>diff -u -p -r1.20.2.47 lustre-lnet.m4 >--- lnet/autoconf/lustre-lnet.m4 11 Dec 2006 11:18:13 -0000 1.20.2.47 >+++ lnet/autoconf/lustre-lnet.m4 28 Dec 2006 21:41:58 -0000 >@@ -1071,6 +1071,25 @@ LB_LINUX_TRY_COMPILE([ > ]) > ]) > >+#2.6.19 API change >+#panic_notifier_list use atomic_notifier operations >+# >+AC_DEFUN([LN_ATOMIC_PANIC_NOTIFIER], >+[AC_MSG_CHECKING([panic_notifier_list is atomic]) >+LB_LINUX_TRY_COMPILE([ >+ #include <linux/notifier.h> >+ #include <linux/kernel.h> >+],[ >+ struct atomic_notifier_head panic_notifier_list; >+],[ >+ AC_MSG_RESULT(yes) >+ AC_DEFINE(HAVE_ATOMIC_PANIC_NOTIFIER, 1, >+ [panic_notifier_list is atomic_notifier_head]) >+],[ >+ AC_MSG_RESULT(NO) >+]) >+])In fact, we don''t really need this at all. The panic notifier code has been disabled for ages (under non-existent #ifdef LNET_DUMP_ON_PANIC) because it causes more problems at node panic than it solves these days (since we changed to binary debug logs). I would just remove all of the *panic_notifier code entirely. Looks good otherwise.
green@clusterfs.com
2006-Dec-29 11:24 UTC
[Lustre-devel] [Bug 11271] patches for patchless client at b1_5 branch
Please don''t reply to lustre-devel. Instead, comment in Bugzilla by using the following link: https://bugzilla.lustre.org/show_bug.cgi?id=11271 What |Removed |Added ---------------------------------------------------------------------------- Attachment #9236|review?(green@clusterfs.com)| Flag| | (From update of attachment 9236) Looks good. Though or the future, you mmight want to only include "aio fixes" in patch named "aio fixes". And put warning fixes and other such stuff to other patches with other appripriate names. Please land to b1_5