shadow@clusterfs.com
2006-Dec-28 12:54 UTC
[Lustre-devel] [Bug 10668] output console messages from liblustre
Please don''t reply to lustre-devel. Instead, comment in Bugzilla by using the following link: https://bugzilla.lustre.org/show_bug.cgi?id=10668 What |Removed |Added ---------------------------------------------------------------------------- Attachment #8811 is|0 |1 obsolete| | Created an attachment (id=9235) Please don''t reply to lustre-devel. Instead, comment in Bugzilla by using the following link: --> (https://bugzilla.lustre.org/attachment.cgi?id=9235&action=view) add Lustre or LustreError to console messages updated version aginst b1_4_sles10.
green@clusterfs.com
2006-Dec-28 13:01 UTC
[Lustre-devel] [Bug 10668] output console messages from liblustre
Please don''t reply to lustre-devel. Instead, comment in Bugzilla by using the following link: https://bugzilla.lustre.org/show_bug.cgi?id=10668 What |Removed |Added ---------------------------------------------------------------------------- Attachment #9235|review?(green@clusterfs.com)|review+ Flag| | (From update of attachment 9235)>- nob = snprintf(buf, sizeof(buf), "%u-%s:(%s:%d:%s()): ", >+ if ((mask & D_EMERG) != 0) { >+ prefix = "LustreError"; >+ } else if ((mask & D_ERROR) != 0) { >+ prefix = "LustreError"; >+ }Better variant of this code is if (mask & (D_EMERG|D_ERROR) != 0) prefix = "LustreError"; Otherwise is good, please land.
pbojanic@clusterfs.com
2006-Dec-31 11:19 UTC
[Lustre-devel] [Bug 10668] output console messages from liblustre
Please don''t reply to lustre-devel. Instead, comment in Bugzilla by using the following link: https://bugzilla.lustre.org/show_bug.cgi?id=10668 What |Removed |Added ---------------------------------------------------------------------------- Status Whiteboard|2006-09-28: CFS provided |2006-12-31: patch completed, |patch; Cray have made some |inspected, and approved; |slight changes to this patch|requires confirmation of |but confirms that it solves |landing on b1_4 and b1_5 |the issue; CFS to land fix | Comment Tags: Status Change 2006-12-31: patch completed, inspected, and approved; requires confirmation of landing on b1_4 and b1_5