Scott Seago
2008-Dec-05 20:19 UTC
[Ovirt-devel] [PATCH] fix for bug 464282: delete permissions
Delete permissions now works -- had a conditional statement wrong in the
controller action.
Signed-off-by: Scott Seago <sseago at redhat.com>
---
src/app/controllers/permission_controller.rb | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/app/controllers/permission_controller.rb
b/src/app/controllers/permission_controller.rb
index 5d3646d..813d9d9 100644
--- a/src/app/controllers/permission_controller.rb
+++ b/src/app/controllers/permission_controller.rb
@@ -102,7 +102,7 @@ class PermissionController < ApplicationController
Permission.transaction do
permissions = Permission.find(:all, :conditions => "id in
(#{permission_ids.join(', ')})")
permissions.each do |permission|
- permission.destroy unless permission.is_primary?
+ permission.destroy if permission.is_primary?
end
end
render :json => { :object => "permission", :success =>
true,
--
1.6.0.4
Jason Guiditta
2008-Dec-17 19:13 UTC
[Ovirt-devel] [PATCH] fix for bug 464282: delete permissions
On Fri, 2008-12-05 at 20:19 +0000, Scott Seago wrote:> Delete permissions now works -- had a conditional statement wrong in the controller action. > > Signed-off-by: Scott Seago <sseago at redhat.com> > --- > src/app/controllers/permission_controller.rb | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/src/app/controllers/permission_controller.rb b/src/app/controllers/permission_controller.rb > index 5d3646d..813d9d9 100644 > --- a/src/app/controllers/permission_controller.rb > +++ b/src/app/controllers/permission_controller.rb > @@ -102,7 +102,7 @@ class PermissionController < ApplicationController > Permission.transaction do > permissions = Permission.find(:all, :conditions => "id in (#{permission_ids.join(', ')})") > permissions.each do |permission| > - permission.destroy unless permission.is_primary? > + permission.destroy if permission.is_primary? > end > end > render :json => { :object => "permission", :success => true,ACK, this works for me.