Ovirt devel - Jul 2008 - SVG support

I keep getting the message 'SVG not supported by this browser' when I
run with the latest Firefox from F-9 (firefox-3.0.1-1.fc9.x86_64)

Besides not having pretty graphs, other parts of the UI also fail
miserably when jquery-svg turns itself off - for example, when I look at
the hosts in my default pool, clicking on a host name has no effect, and
I get an error 'svg is undefined' in my JS console; I assume that's
a
cascading failure from jquery-svg turning itself off.

What's worse, it seems that the jquery-svg check whether SVG is
supported in the browser is busted. If I apply the patch at the bottom
of this mail, I do get pretty graphs, and clicking on hosts does show
the details.

What are others doing ? Am I the only one who is affected by this ?
There's also a new release of jquery-svg - a quick try didn't seem to
fix the issue, but I am not sure if that's just because my way of
'updating' (unzip in public/javascripts/jquery-svg) broke something
else.

BTW, when you reload the OVirt WUI, there's a long list of JS errors
flowing by in the console ... they really need to be fixed.

David

diff --git a/wui/src/app/views/layouts/redux.rhtml
b/wui/src/app/views/layouts/redux.rhtml
index 924f300..bcabe91 100644
--- a/wui/src/app/views/layouts/redux.rhtml
+++ b/wui/src/app/views/layouts/redux.rhtml
@@ -23,7 +23,7 @@
   <%= javascript_include_tag "flexigrid.js" -%>
   <%= javascript_include_tag "facebox.js" -%>
   <%= javascript_include_tag "jquery.timers.js" -%>
-  <%= javascript_include_tag "jquery-svg/jquery.svg.pack.js"
-%>
+  <%= javascript_include_tag "jquery-svg/jquery.svg.js" -%>
   <!--%= javascript_include_tag "jquery-svg/jquery.svgfilter.js"
-%-->
   <%= javascript_include_tag "jquery-svg/jquery.svggraph.js"
-%>
   <!--%= javascript_include_tag "jquery.ui-1.5b4/ui.core.js"
-%>
diff --git a/wui/src/public/javascripts/jquery-svg/jquery.svg.js
b/wui/src/public/javascripts/jquery-svg/jquery.svg.js
index dea8794..8dc7768 100644
--- a/wui/src/public/javascripts/jquery-svg/jquery.svg.js
+++ b/wui/src/public/javascripts/jquery-svg/jquery.svg.js
@@ -45,7 +45,7 @@ $.extend(SVGManager.prototype, {
                                '" height="' +
container.clientHeight + '" src="blank.svg"/>';
                        this._settings[id] = [container, loadURL, settings,
onLoad];
                }
-               else if
(document.implementation.hasFeature("http://www.w3.org/TR/SVG11/feature#SVG","1.1")
||
+               else if (true ||
document.implementation.hasFeature("http://www.w3.org/TR/SVG11/feature#SVG","1.1")
||
                               
document.implementation.hasFeature("org.w3c.svg", "1.1")) {
                        svg = document.createElementNS(this.svgNS,
'svg');
                        svg.setAttribute('version', '1.1');

On Wed, 2008-07-30 at 17:41 -0700, David Lutterkort
wrote:
> I keep getting the message 'SVG not supported by this browser' when
I
> run with the latest Firefox from F-9 (firefox-3.0.1-1.fc9.x86_64)
David, this seems to be an issue with the plugin in FF3 x64 only (I hit
it too).  Since graph implementation is very much in flux, I have not
been looking into a good fix.  However, you can comment out all calls in
the rhtml files to 'load_widget*'.  This will not make the graphs work
for you, but it will make the reset of the app work and get rid of most
of the js errors you hit.  Should we stay with svg, I would ditch this
plugin and generate the svg serverside, but as that may or may not be
the case, it has not been touched yet.

-j
> David