Chris Lalancette
2008-Jun-06 09:33 UTC
[Ovirt-devel] [PATCH/RFC]: Taskomatic exception cleanup
Attached is a rather large patch that cleans up taskomatic exception handling. It's quite nice in that it removes a lot of code, and moves almost all exception handling code to the top-level, where it really belongs. This will also give us backtraces and good exception messages when things fail. The only real downside to this patch is that I've only lightly tested it so far, and it is a pretty big patch for right now. If people are very against this patch, I can probably come up with something smaller (but not as nice) for the time being. Comments? Signed-off-by: Chris Lalancette <clalance at redhat.com> -------------- next part -------------- A non-text attachment was scrubbed... Name: taskomatic-large-exception-cleanup.patch Type: text/x-patch Size: 21306 bytes Desc: not available URL: <http://listman.redhat.com/archives/ovirt-devel/attachments/20080606/90be5459/attachment.bin>
Chris Lalancette wrote:> Attached is a rather large patch that cleans up taskomatic exception handling. > It's quite nice in that it removes a lot of code, and moves almost all exception > handling code to the top-level, where it really belongs. This will also give us > backtraces and good exception messages when things fail. The only real downside > to this patch is that I've only lightly tested it so far, and it is a pretty big > patch for right now. If people are very against this patch, I can probably come > up with something smaller (but not as nice) for the time being. Comments?Upon careful reading, I say this is a low risk/high benefit change: + no change in functionality, just moves the code out of exception blocks + very useful for debugging issues So 1/2 ACK - 2nd half when I actually test it :)