Jeff Barczewski
2006-Jun-02 18:03 UTC
[Masterview-devel] Masterview-devel post from dlewis@glaivestone.com requires approval
I agree. The better we can name things, the better off we are in the long run. It will be more intuitive to others and to us when we revisit code we haven''t looked at for a long time. Well worth the time to get it right. Sure beats having to refactor it later too. I am fine with app_settings.rb or settings.rb, but of the two I probably like settings.rb slightly better.> > From: "Deb Lewis" <dlewis at glaivestone.com> > > To: "masterview-devel" <masterview-devel at rubyforge.org > > > Date: Fri, 2 Jun 2006 08:09:23 -0700 > > > Subject: RE: Masterview init rework - one more try > >> didn''t see your aaasample-config (did it get committed?) > > oops, nope. it''s out there now (with LF''s) > > Another possible tweak: not sure if I like the file name > config/masterview/init.rb - kind of implies more than what''s intended. This > file really shouldn''t be doing much more than setting values in the config > instance it''s given, it''s not really intended as a general "write > initialization logic" - if you want to do additional app initialization to > leverage MV once it''s installed, that probably does properly belong in your > environment.rb (where it''s run when your own app has been initialized and > installed, which isn''t the case at the point when the plugin init is being > run) > > So maybe config/masterview/settings.rb or > config/masterview/app_settings.rb (?config/masterview/config.rb?!) would be > a better name to express the intended scope of what goes in this file. > > philosophy rant: this might seem like nit-picking, but names *REALLY* do > matter. Getting the names right early on makes a huge, huge difference in > the comprehensibility of the software, both for the developers and the > users. Affects how you talk about and think about what''s going on. I find > up-front investment in fussing to get names and concepts right always has > huge payoff over the long-term lifetime of the system. > > If you''re lazy or get it wrong, it''ll hurt your brain every single time > forever after when you have to stop and think "lessee, X... oh yeah, > that means Y" > > </rant> > > ~ Deb > > > ---------- Forwarded message ---------- > From: masterview-devel-request at rubyforge.org > To: > Date: > Subject: confirm fab40cb4519b52036e143d3fdf9a66cecde7f4cd > If you reply to this message, keeping the Subject: header intact, > Mailman will discard the held message. Do this if the message is > spam. If you reply to this message and include an Approved: header > with the list password in it, the message will be approved for posting > to the list. The Approved: header can also appear in the first line > of the body of the reply. > > >-------------- next part -------------- An HTML attachment was scrubbed... URL: http://rubyforge.org/pipermail/masterview-devel/attachments/20060602/c4d99e1e/attachment-0001.htm