Deb Lewis
2006-Sep-23 01:04 UTC
[Masterview-devel] Proposed change to default directive attribute formula
I''ve got a one-liner change to modify the default directive attribute name derived from a class name so that std. camel casing can be used on directive class names. Ex. rename Image_tag to ImageTag and still get directive mv:image_tag Existing directive class names with underscore-lowercase names are fine, but can be changed to follow normal ruby class naming convention as convenient. Any objection? I think this is actually more consistent with general Rails name mapping conventions, e.g., std mapping between class names and file names. Only problem would be if someone was actually using a mixed-case directive attribute (like... say, the TestDirective unit test fixture you had in example test case that I had to fix!); don''t think that''s likely if people were following the lowercase-plus-underscore convention of the builtin directives. You can always explictly specify :attribute_name in metadata decl to override default value. ~ Deb
Deb Lewis
2006-Sep-23 21:16 UTC
[Masterview-devel] Proposed change to default directive attributeformula
>> one-liner change to modify the default directive attribute name >> derived from a class name so that std. camel casing can be used on >> directive class names.Had intended to hold off on submitting this until you''d had a chance to point out any flaws in my justification that this won''t introduce any compat problems, but accidently committed the updated test case along with some other unrelated changes, so just went ahead and committed this. Todo: change class names in masterview/directives which used underscores back to normal ruby CamelCase naming convention. ~ Deb
Jeff Barczewski
2006-Sep-24 14:45 UTC
[Masterview-devel] Proposed change to default directive attributeformula
On 9/23/06, Deb Lewis <djlewis at acm.org> wrote:> >> one-liner change to modify the default directive attribute name > >> derived from a class name so that std. camel casing can be used on > >> directive class names. > > Had intended to hold off on submitting this until you''d had a chance to > point out any flaws in my justification that this won''t introduce any compatSeems like a good update to me. The more consistency the better.