Deb Lewis
2006-Oct-29 16:37 UTC
[Masterview-devel] Well I hit a problem with doctype and am debugging
Maybe a combo strategy - I don''t like blindly patching libraries we''re using, but it would also be good to make this as simple as possible. Maybe a config switch with default computed based on our understanding of broken/fixed versions of rexml. ~ Deb _____ From: Jeff Barczewski [mailto:jeff.barczewski at gmail.com] Sent: Saturday, October 28, 2006 5:49 PM To: djlewis at acm.org Subject: Re: Well I hit a problem with doctype and am debugging It is a problem in the sax2parser of rexml. I found that they aren''t handling doctype declarations properly. They have some code in there but it is broken. And of course their test cases are missing the appropriate test or they would have caught it. I will work up a patch and test case for them and send it in. Not sure what to do about our code since most people will have the broken code until it gets fixed in ruby mainlib or they manually upgrade which most won''t. I guess we''ll have to include the patched rexml file in our distro so that people can get at doctypes properly. I guess that is the nice thing about Ruby that we can hotfix things if we have to. Should we wrap a configuration switch around this or simply check the rexml version assuming that once I get him the fix it will be in his next release? (and only require it if version is not high enough) Boy something so simple turns into something bigger. Oh well at least I know what is wrong now and how to fix. yeah, the Cardinals suprised us all this time. Detroit wasn''t playing its best though, without their errors we wouldn''t have won. It was pretty exciting to watch. Later, Jeff -------------- next part -------------- An HTML attachment was scrubbed... URL: http://rubyforge.org/pipermail/masterview-devel/attachments/20061029/b84e4d89/attachment.html