Hello, On sekmadienis 02 Gegu?? 2010 02:49:23 Praveen A wrote:> +libdbusmenu-qt (0.3.2-2) unstable; urgency=low > + > + [ Praveen Arimbrathodiyil ] > + * VCS links changed to packaging VCS > + * Main Section changed to libs > + * Redundant ''Section'' field removed from binary package > + * Removed CMakeLists.txt from docs > + * libdbusmenu-qt-devs.dirs and libdbusmenu-qt2.dirs removed (redundant) > + * libdbusmenu-qt2.install - soname is embedded instead of lib*.so.* wild > card + * Changed Maintainer to Debian Krap Maintainers > + * Moved Praveen Arimbrathodiyil to Uploaders > + * Removed post* as they are redundant (dh_makeshlibs will take care of > this) + * Removed debian/shlibs.local and added dh_makeshlibs override > + * debian/rules, debian/watch - example boilerplates removed > + * debhelper dependency increased to 7.4.12 for qmake support > + * qt4-qmake dependency droppedNo, you don''t need to start -2 revision for these changes because -1 has never been officially uploaded to Debian. This also means that you don''t need to document changes in the changelog until initial release is uploaded to Debian archive. So basically, you can just drop this -2 entry completely. Please remove 0.3.2-1 tag as well since it is invalid and does not point to official upload. We set changelog entry distribution field to UNRELEASED until the package is actually uploaded to Debian archive. I suggest you follow this path too. Read more at http://wiki.debian.org/PkgKde/DchUse UNRELEASED still is called changelog heuristic. In your case, debian/changelog should look the following until packaging is still in development: libdbusmenu-qt (0.3.2-1) UNRELEASED; urgency=low * Initial release. (Closes: #579677) -- Praveen Arimbrathodiyil (A proud GNU user) <pravi.a at gmail.com> Mon, 26 Apr 2010 19:15:31 +0530> + > +override_dh_makeshlibs: > + dh_makeshlibs -V ''libdbusmenu-qt2 (>=0.3.2)'' > + dpkg-shlibdeps debian/tmp/usr/lib/*What is that dpkg-shlibdeps command for? -- Modestas Vainius <modestas at vainius.eu> -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 198 bytes Desc: This is a digitally signed message part. URL: <http://lists.alioth.debian.org/pipermail/pkg-kde-talk/attachments/20100502/5872681e/attachment.pgp>
2010/5/3 Modestas Vainius <modestas at vainius.eu>:> No, you don''t need to start -2 revision for these changes because -1 has never > been officially uploaded to Debian. This also means that you don''t need to > document changes in the changelog until initial release is uploaded to Debian > archive. So basically, you can just drop this -2 entry completely. Please > remove 0.3.2-1 tag as well since it is invalid and does not point to official > upload.OK. Made these changes.> We set changelog entry distribution field to UNRELEASED until the package is > actually uploaded to Debian archive. I suggest you follow this path too. Read > more at http://wiki.debian.org/PkgKde/DchUse UNRELEASED still is called > changelog heuristic. > > In your case, debian/changelog should look the following until packaging is > still in development: > > libdbusmenu-qt (0.3.2-1) UNRELEASED; urgency=low > > ?* Initial release. (Closes: #579677) > > ?-- Praveen Arimbrathodiyil (A proud GNU user) <pravi.a at gmail.com> ?Mon, 26 > Apr 2010 19:15:31 +0530 > >> + >> +override_dh_makeshlibs: >> + ? ? dh_makeshlibs -V ''libdbusmenu-qt2 (>=0.3.2)'' >> + ? ? dpkg-shlibdeps debian/tmp/usr/lib/* > > What is that dpkg-shlibdeps command for? >lintian was complaining about so files (I don''t remember the exact warning, but it is not coming now - may be one of the intermediate versions with incomplete changes) and when looking at the docs I saw this, "If you have multiple binary packages, you will need to call dpkg-shlibdeps on each one which contains compiled libraries or binaries." http://www.debian.org/doc/debian-policy/ch-sharedlibs.html But it seems redundant, now removed. -- ???????? ??????????????????? <GPLv2> I know my rights; I want my phone call! <DRM> What use is a phone call, if you are unable to speak? (as seen on /.)
Hello, On pirmadienis 03 Gegu?? 2010 16:28:31 Praveen A wrote:> 2010/5/3 Modestas Vainius <modestas at vainius.eu>: > > No, you don''t need to start -2 revision for these changes because -1 has > > never been officially uploaded to Debian. This also means that you don''t > > need to document changes in the changelog until initial release is > > uploaded to Debian archive. So basically, you can just drop this -2 > > entry completely. Please remove 0.3.2-1 tag as well since it is invalid > > and does not point to official upload. > > OK. Made these changes.Fine. Now the last nitpicks: 1) I overlooked that the package uses cmake (don''t know why I initially thought it used qmake). debhelper (>= 7.3) is enough for this (Build-Depends). 2) I suggest you reconsider not using "(A proud GNU user)" in Uploaders field and changelog trailer. Now it may look cool somewhat but you may get tired of this eventually. It is rather unusual as well. If I were you I would just keep your full name and email like Debian Policy 5.6.2 recommends. Btw, this is not a blocker for sponsoring, it is your choice eventually. Finally feel free to `dch -r -D unstable`, build source package, upload it to mentors or alioth and give me an URL to .dsc which I will sponsor. -- Modestas Vainius <modestas at vainius.eu> -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 198 bytes Desc: This is a digitally signed message part. URL: <http://lists.alioth.debian.org/pipermail/pkg-kde-talk/attachments/20100503/adf5f0a6/attachment.pgp>
Hello, On pirmadienis 03 Gegu?? 2010 20:42:47 Modestas Vainius wrote:> Hello, > > On pirmadienis 03 Gegu?? 2010 16:28:31 Praveen A wrote: > > 2010/5/3 Modestas Vainius <modestas at vainius.eu>: > > > No, you don''t need to start -2 revision for these changes because -1 > > > has never been officially uploaded to Debian. This also means that you > > > don''t need to document changes in the changelog until initial release > > > is uploaded to Debian archive. So basically, you can just drop this -2 > > > entry completely. Please remove 0.3.2-1 tag as well since it is > > > invalid and does not point to official upload. > > > > OK. Made these changes. > > Fine. Now the last nitpicks: > > 1) I overlooked that the package uses cmake (don''t know why I initially > thought it used qmake). debhelper (>= 7.3) is enough for this > (Build-Depends). > > 2) I suggest you reconsider not using "(A proud GNU user)" in Uploaders > field and changelog trailer. Now it may look cool somewhat but you may get > tired of this eventually. It is rather unusual as well. If I were you I > would just keep your full name and email like Debian Policy 5.6.2 > recommends. Btw, this is not a blocker for sponsoring, it is your choice > eventually.And... 3) dbusmenu-qt public headers include Qt headers therefore add libqt4-dev to Depends of the -dev package. -- Modestas Vainius <modestas at vainius.eu> -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 198 bytes Desc: This is a digitally signed message part. URL: <http://lists.alioth.debian.org/pipermail/pkg-kde-talk/attachments/20100503/b131138d/attachment.pgp>
2010/5/3 Modestas Vainius <modestas at vainius.eu>:> 1) I overlooked that the package uses cmake (don''t know why I initially > thought it used qmake). debhelper (>= 7.3) is enough for this (Build-Depends).cmake removed from build depends, but it also requires qmake (it was failing in pbuilder). Build is failing with pbuilder as it cannot find cmake. Should I add it again? Also libqt4-dev is added as dependency for -dev package.> 2) I suggest you reconsider not using "(A proud GNU user)" in Uploaders field > and changelog trailer. Now it may look cool somewhat but you may get tired of > this eventually. It is rather unusual as well. If I were you I would just keep > your full name and email like Debian Policy 5.6.2 recommends. Btw, this is not > a blocker for sponsoring, it is your choice eventually.OK. Removed "(A proud GNU user)". I was trying to get dpkg-buildpackage to use my gpg keys. Now I have to run debsign -k0xE0C010D0 (DEBSIGN_KEYID variable seems to not make any effect), but that is Ok.> Finally feel free to `dch -r -D unstable`, build source package, upload it to > mentors or alioth and give me an URL to .dsc which I will sponsor.It is uploaded to mentors. http://mentors.debian.net/debian/pool/main/l/libdbusmenu-qt/libdbusmenu-qt_0.3.2-1.dsc - Praveen -- ???????? ??????????????????? <GPLv2> I know my rights; I want my phone call! <DRM> What use is a phone call, if you are unable to speak? (as seen on /.)