I''ve noticed sup strips X-Foo: from mails during editing (or indeed, any header that isn''t recognized in mbox.rb). I think it would be better to just ignore and pass them on (as they are officially okay in emails whereas random unknown non "X-" headers are not). What do people think? (I use X-Tags: for blogging, myself. I also used to have a joke X-Windows: header.) I''ve pushed a change to fix it to Gitorious: http://gitorious.org/projects/sup/repos/decklins-clone/commits/aa1b6846c33b44dfd723ad9657448e45e7a2a143 (I moved up the special-case X- stuff so this doesn''t interfere with it. Might not actually be necessary.) William, for future patch submissions, is it cool to just say "hey, I commited something", and then you can pull it if desired? Or should I attach the patch here for discussion? -- things change. decklin at red-bean.com
Reformatted excerpts from Decklin Foster''s message of 2008-10-26:> I''ve noticed sup strips X-Foo: from mails during editing (or indeed, > any header that isn''t recognized in mbox.rb). I think it would be > better to just ignore and pass them on (as they are officially okay in > emails whereas random unknown non "X-" headers are not). What do > people think?That''s fine with me. The ignore headers stuff was just there to try and speed up mbox reading (and it seemed to make a difference at the time, though in retrospect I wonder).> I''ve pushed a change to fix it to Gitorious:Merged into next. Thanks!> William, for future patch submissions, is it cool to just say "hey, I > commited something", and then you can pull it if desired? Or should I > attach the patch here for discussion?No, that''s fine. Posting patches here is fine too, but no one really reads them except for me, so... whatever''s easiest for you. Official Gitorious merge requests also work. -- William <wmorgan-sup at masanjin.net>
Excerpts from William Morgan''s message of Mon Oct 27 22:15:23 -0400 2008:> No, that''s fine. Posting patches here is fine too, but no one really > reads them except for me, so... whatever''s easiest for you. Official > Gitorious merge requests also work.I''ve been known to read patches posted here in the past, and even apply them locally if it was something I really wanted and I didn''t want to wait for it to make it to next. I don''t think I''m alone, although there probably aren''t many of us. Just, y''know, to debate the irrelevant point. -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 197 bytes Desc: not available URL: <http://rubyforge.org/pipermail/sup-talk/attachments/20081031/c6a80f5b/attachment-0001.bin>