Author: jrdioko-guest
Date: 2011-07-23 05:52:46 +0000 (Sat, 23 Jul 2011)
New Revision: 16971
Modified:
bin/tracker_service.py
Log:
Change "Introduction" link at
http://security-tracker.debian.org/tracker/data/report
Changed "view=markup" to "view=co" which looks cleaner. It
also looks like something
besides changing this file needs to be done to update the live website. First
commit,
please correct me if I do anything wrong.
Modified: bin/tracker_service.py
==================================================================---
bin/tracker_service.py 2011-07-23 03:07:06 UTC (rev 16970)
+++ bin/tracker_service.py 2011-07-23 05:52:46 UTC (rev 16971)
@@ -513,7 +513,7 @@
P("""Helping out: We welcome people who wish to
join us in tracking
issues. The process is designed to be easy to learn and participate,
please read our """,
-
A("http://svn.debian.org/viewvc/secure-testing/doc/narrative_introduction?view=markup",
+
A("http://svn.debian.org/viewvc/secure-testing/doc/narrative_introduction?view=co",
"Introduction"),
""" to get familiar with how things work. Join
us on
our mailing list, and on IRC and request to be added to the Alioth
""",
Johnathan Ritzi wrote:> Author: jrdioko-guest > Date: 2011-07-23 05:52:46 +0000 (Sat, 23 Jul 2011) > New Revision: 16971 > > Modified: > bin/tracker_service.py > Log: > Change "Introduction" link at http://security-tracker.debian.org/tracker/data/report > > Changed "view=markup" to "view=co" which looks cleaner. It also looks like something > besides changing this file needs to be done to update the live website. First commit, > please correct me if I do anything wrong.Changes to the tracker code itself need to be vetted and approved before being synced live. The preferable way to do this is to send a patch to the security-tracker ml before commiting anything; although this particular change is so minor, that probably isn''t such a necessity. Best wishes, Mike
Understood. That would be something good to mention in that Introduction document for new members as well. On Fri, Jul 22, 2011 at 11:01 PM, Michael Gilbert < michael.s.gilbert at gmail.com> wrote:> Johnathan Ritzi wrote: > > > Author: jrdioko-guest > > Date: 2011-07-23 05:52:46 +0000 (Sat, 23 Jul 2011) > > New Revision: 16971 > > > > Modified: > > bin/tracker_service.py > > Log: > > Change "Introduction" link at > http://security-tracker.debian.org/tracker/data/report > > > > Changed "view=markup" to "view=co" which looks cleaner. It also looks > like something > > besides changing this file needs to be done to update the live website. > First commit, > > please correct me if I do anything wrong. > > Changes to the tracker code itself need to be vetted and approved > before being synced live. The preferable way to do this is to send a > patch to the security-tracker ml before commiting anything; although > this particular change is so minor, that probably isn''t such a > necessity. > > Best wishes, > Mike > > _______________________________________________ > Secure-testing-commits mailing list > Secure-testing-commits at lists.alioth.debian.org > > http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/secure-testing-commits >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.alioth.debian.org/pipermail/secure-testing-commits/attachments/20110722/d76bba84/attachment.html>
Johnathan Ritzi wrote:> Understood. That would be something good to mention in that Introduction > document for new members as well.Feel free to add that since you have commit access now. Best wishes, Mike
How''s this? Index: doc/narrative_introduction ==================================================================--- doc/narrative_introduction (revision 16973) +++ doc/narrative_introduction (working copy) @@ -441,9 +441,16 @@ There is a script running, which automatically commits them to DSA/list. In some cases it needs manual fixups. -Checking your changes ---------------------- +Checking in your changes +------------------------ +After thoroughly researching each issue and editing the relevant files, +commit your changes. Peer review is done via the mailing list and IRC +notifications (see "Automatic Issue Updates" above). However, changes to +the tracker website itself (e.g. the files in bin/) should be vetted and +approved before being committed. The preferred way to do this is to send +a patch to the debian-security-tracker at lists.debian.org mailing list. + Commits are checked for syntax errors before they are actually committed, and you''ll receive an error and your commit is aborted if it is in error. To check your changes yourself beforehand, use "make check-syntax" from On Fri, Jul 22, 2011 at 11:10 PM, Michael Gilbert < michael.s.gilbert at gmail.com> wrote:> Johnathan Ritzi wrote: > > > Understood. That would be something good to mention in that Introduction > > document for new members as well. > > Feel free to add that since you have commit access now. > > Best wishes, > Mike > > _______________________________________________ > Secure-testing-commits mailing list > Secure-testing-commits at lists.alioth.debian.org > > http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/secure-testing-commits >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.alioth.debian.org/pipermail/secure-testing-commits/attachments/20110723/a930b0ea/attachment.html>
Johnathan Ritzi wrote:> How''s this? > > Index: doc/narrative_introduction > ==================================================================> --- doc/narrative_introduction (revision 16973) > +++ doc/narrative_introduction (working copy) > @@ -441,9 +441,16 @@ > There is a script running, which automatically commits them to DSA/list. > In some cases it needs manual fixups. > > -Checking your changes > ---------------------- > +Checking in your changes > +------------------------ > > +After thoroughly researching each issue and editing the relevant files, > +commit your changes. Peer review is done via the mailing list and IRC > +notifications (see "Automatic Issue Updates" above). However, changes to > +the tracker website itself (e.g. the files in bin/) should be vetted and > +approved before being committed. The preferred way to do this is to send > +a patch to the debian-security-tracker at lists.debian.org mailing list. > + > Commits are checked for syntax errors before they are actually committed, > and you''ll receive an error and your commit is aborted if it is in error. > To check your changes yourself beforehand, use "make check-syntax" fromYou may want to mention what "thoroughly" means; i.e. summarize [0] as currently mentioned in the "processing todo entries" section now. You can go ahead with the commits as you get them done, and we''ll fix them up if we see issues. Best wishes, Mike