Please see patched fixevents.rb and events.rb. I only fixed EVT_MENU_RANGE. There may be other events that are also incorrect. Roy _______________________________________________ wxruby-users mailing list wxruby-users@rubyforge.org http://rubyforge.org/mailman/listinfo/wxruby-users
Roy Sutton wrote:> Please see patched fixevents.rb and events.rb. I only fixed > EVT_MENU_RANGE. There may be other events that are also incorrect.I''m not happy with this whole system. First, with magic numbers (1, 3, 3) as flags meaning certain kinds of events. Honestly, I haven''t even looked at this code enough to really understand what it''s doing. I''ve added a TODO note to eventually try to clean it up. But I applied your patch. It looks good enough to me that if you say it''s a step in the right direction, I believe you. Thanks, Kevin
I 100% agree with you that it would be nice to refactor this. I was about to send a message to the list for help on this one until I discovered the stuff hiding there. There is duplicated code #IF 0''ed out in a couple other places, too. I think this is something to maybe tackle later, though. Kevin Smith wrote:> I''m not happy with this whole system. First, with magic numbers (1, 3, > 3) as flags meaning certain kinds of events. Honestly, I haven''t even > looked at this code enough to really understand what it''s doing. I''ve > added a TODO note to eventually try to clean it up.