Linux Ethernet Bridging - Nov 2011 - [Bridge] [PATCH] bridge: master device stuck in no-carrier state forever when in user-stp mode

An embedded and charset-unspecified text was scrubbed...
Name: not available
URL:
<http://lists.linuxfoundation.org/pipermail/bridge/attachments/20111125/3ccdda09/attachment.ksh>

From: Vitalii Demianets <vitas at nppfactor.kiev.ua>
Date: Fri, 25 Nov 2011 12:16:37 +0200
> When in user-stp mode, bridge master do not follow state of its slaves, so 
> after the following sequence of events it can stuck forever in no-carrier 
> state:
> 1) turn stp off
> 2) put all slaves down - master device will follow their state and also go
in
> no-carrier state
> 3) turn stp on with bridge-stp script returning 0 (go to the user-stp mode)
> Now bridge master won't follow slaves' state and will never reach
running
> state.
> 
> This patch solves the problem by making user-stp and kernel-stp behavior 
> similar regarding master following slaves' states.
> 
> Signed-off-by: Vitalii Demianets <vitas at nppfactor.kiev.ua>
Stephen, please review this patch, thanks.

On Fri, 25 Nov 2011 12:16:37 +0200
Vitalii Demianets <vitas at nppfactor.kiev.ua> wrote:
> When in user-stp mode, bridge master do not follow state of its slaves, so 
> after the following sequence of events it can stuck forever in no-carrier 
> state:
> 1) turn stp off
> 2) put all slaves down - master device will follow their state and also go
in
> no-carrier state
> 3) turn stp on with bridge-stp script returning 0 (go to the user-stp mode)
> Now bridge master won't follow slaves' state and will never reach
running
> state.
> 
> This patch solves the problem by making user-stp and kernel-stp behavior 
> similar regarding master following slaves' states.
> 
> Signed-off-by: Vitalii Demianets <vitas at nppfactor.kiev.ua>
This method works fine. David please apply to -net.

Acked-by: Stephen Hemminger <shemminger at vyatta.com>