Bill Pemberton
2011-Mar-30 18:45 UTC
[Bridge] [PATCH] bridge: provide return value in br_stp_recalculate_bridge_id
fix warning net/bridge/br_stp_if.c:216:3: warning: ?return? with no value, in
function returning non-void
This warning was introduced when br_stp_recalculate_bridge_id was
changed to return true/false by commit
edf947f10074fea27fdb1730524dca59355a1c40
Signed-off-by: Bill Pemberton <wfp5p at virginia.edu>
---
net/bridge/br_stp_if.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/bridge/br_stp_if.c b/net/bridge/br_stp_if.c
index 5593f5a..9b61d09 100644
--- a/net/bridge/br_stp_if.c
+++ b/net/bridge/br_stp_if.c
@@ -213,7 +213,7 @@ bool br_stp_recalculate_bridge_id(struct net_bridge *br)
/* user has chosen a value so keep it */
if (br->flags & BR_SET_MAC_ADDR)
- return;
+ return false;
list_for_each_entry(p, &br->port_list, list) {
if (addr == br_mac_zero ||
--
1.7.4