Linux Ethernet Bridging - Jul 2009 - [Bridge] [patch 0/2] a few bridge code cleanups

Hi,

here is a few bridge cleanups - code alignment
and conditional compilation for structure members.

Please review. Hope I didn't miss anything.
Anyway if it breaks someone patch queue --
just drop this series then.

Cyrill

An embedded and charset-unspecified text was scrubbed...
Name: net-br-br_nf_ops-cleanup
Url:
http://lists.linux-foundation.org/pipermail/bridge/attachments/20090704/22138920/attachment.txt

An embedded and charset-unspecified text was scrubbed...
Name: net-br-x-tables-ifconfig
Url:
http://lists.linux-foundation.org/pipermail/bridge/attachments/20090704/5a0b9998/attachment.txt

On Sat, 04 Jul 2009 10:11:57 +0400
Cyrill Gorcunov <gorcunov at openvz.org> wrote:
> No functional change -- just for easier reading.
> 
> Signed-off-by: Cyrill Gorcunov <gorcunov at openvz.org>
> ---
>  net/bridge/br_netfilter.c |   96
++++++++++++++++++++++++++--------------------
>  1 file changed, 56 insertions(+), 40 deletions(-)
> 

Acked-by: Stephen Hemminger <shemminger at vyatta.com>

--

On Sat, 04 Jul 2009 10:11:58 +0400
Cyrill Gorcunov <gorcunov at openvz.org> wrote:
> In case if kernel was compiled without ebtables support
> there is no need to keep ebt_table pointers in netns_xt
> structure.
> 
> Make it config dependent.
> 
> Signed-off-by: Cyrill Gorcunov <gorcunov at openvz.org>
> ---
> 
> Probably GCC will authomatically shrink the structure
> if the members are not in use. Please review.
> 
>  include/net/netns/x_tables.h |    3 +++
>  1 file changed, 3 insertions(+)
> 
> Index: linux-2.6.git/include/net/netns/x_tables.h
> ====================================================================>
--- linux-2.6.git.orig/include/net/netns/x_tables.h
> +++ linux-2.6.git/include/net/netns/x_tables.h
> @@ -8,8 +8,11 @@ struct ebt_table;
>  
>  struct netns_xt {
>  	struct list_head tables[NFPROTO_NUMPROTO];
> +#if defined(CONFIG_BRIDGE_NF_EBTABLES) || \
> +    defined(CONFIG_BRIDGE_NF_EBTABLES_MODULE)
>  	struct ebt_table *broute_table;
>  	struct ebt_table *frame_filter;
>  	struct ebt_table *frame_nat;
> +#endif
>  };
>  #endif
> 
> --
> To unsubscribe from this list: send the line "unsubscribe netdev"
in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
Acked-by: Stephen Hemminger <shemminger at vyatta.com>

--

[Stephen Hemminger - Thu, Jul 09, 2009 at 12:55:00PM -0700]
| On Sat, 04 Jul 2009 10:11:57 +0400
| Cyrill Gorcunov <gorcunov at openvz.org> wrote:
| 
| > No functional change -- just for easier reading.
| > 
| > Signed-off-by: Cyrill Gorcunov <gorcunov at openvz.org>
| > ---
| >  net/bridge/br_netfilter.c |   96
++++++++++++++++++++++++++--------------------
| >  1 file changed, 56 insertions(+), 40 deletions(-)
| > 
| 
| 
| Acked-by: Stephen Hemminger <shemminger at vyatta.com>
| 
| -- 
| 

Thanks for review Stephen. Will you pick them up?

	-- Cyrill