Ironruby core - Aug 2011 - Workitem #6244 - request for code review

Hi, i fixed workitem #6244 (
https://github.com/enricosada/IronLanguages/commit/c9d8339441e21a90216b9b51cffd23f5225d0174),
i added ''%N'' option to time.strftime.

I added also the test to strftime mspec. I dont think i need to change
ironruby-tags-19, because the new test should pass now.

This is my first commit to ironruby, wiki say i need to ask to ml for code
review before pull request. There is other i need to do?
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://rubyforge.org/pipermail/ironruby-core/attachments/20110801/52b0cc59/attachment.html>

Thanks! Looks good. Submit a pull request and I''ll merge it in.

You can submit a pull request along with sending it to the mailing list for code
review; it''s a good way to keep track of open reviews.

~js

On Aug 1, 2011, at 9:17 AM, Enrico Sada wrote:
> Hi, i fixed workitem #6244
(https://github.com/enricosada/IronLanguages/commit/c9d8339441e21a90216b9b51cffd23f5225d0174),
i added ''%N'' option to time.strftime.
> 
> I added also the test to strftime mspec. I dont think i need to change
ironruby-tags-19, because the new test should pass now.
> 
> This is my first commit to ironruby, wiki say i need to ask to ml for code
review before pull request. There is other i need to do?
> 
> _______________________________________________
> Ironruby-core mailing list
> Ironruby-core at rubyforge.org
> http://rubyforge.org/mailman/listinfo/ironruby-core

-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://rubyforge.org/pipermail/ironruby-core/attachments/20110801/1fd729f5/attachment-0001.html>

On a related note, we should come up with a better way to keep our copy of
RubySpec in sync with the "truth":
https://github.com/rubyspec/rubyspec/. Volunteers welcome.

On Aug 1, 2011, at 11:00 AM, Jimmy Schementi wrote:
> Thanks! Looks good. Submit a pull request and I''ll merge it in.
> 
> You can submit a pull request along with sending it to the mailing list for
code review; it''s a good way to keep track of open reviews.
> 
> ~js
> 
> On Aug 1, 2011, at 9:17 AM, Enrico Sada wrote:
>> Hi, i fixed workitem #6244
(https://github.com/enricosada/IronLanguages/commit/c9d8339441e21a90216b9b51cffd23f5225d0174),
i added ''%N'' option to time.strftime.
>> 
>> I added also the test to strftime mspec. I dont think i need to change
ironruby-tags-19, because the new test should pass now.
>> 
>> This is my first commit to ironruby, wiki say i need to ask to ml for
code review before pull request. There is other i need to do?
>> 
>> _______________________________________________
>> Ironruby-core mailing list
>> Ironruby-core at rubyforge.org
>> http://rubyforge.org/mailman/listinfo/ironruby-core
> 
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://rubyforge.org/pipermail/ironruby-core/attachments/20110801/11f8e113/attachment.html>