tfpt review "/shelveset:config;REDMOND\sborde" Comment : Change RbConfig::CONFIG["arch"] to "universal-dotnet2.0" (or "universal-dotnet4.0" on .NET 4) Also changed RbConfig::CONFIG["host_os"] to be based on RUBY_PLATFORM so that it will be mswin32 on Windows and linux on Linux. Removed some config values that are not present in JRuby -------------- next part -------------- A non-text attachment was scrubbed... Name: config.diff Type: application/octet-stream Size: 6196 bytes Desc: config.diff URL: <http://rubyforge.org/pipermail/ironruby-core/attachments/20100311/cefdb483/attachment.obj>
Looks good. As part of MQ, we should look deeply at the compilation based variables and see if they can be removed or picked up from the arguments to csc. JD -----Original Message----- From: Shri Borde Sent: Thursday, March 11, 2010 11:36 AM To: IronRuby External Code Reviewers Cc: ironruby-core at rubyforge.org Subject: FYI Code Review: config tfpt review "/shelveset:config;REDMOND\sborde" Comment : Change RbConfig::CONFIG["arch"] to "universal-dotnet2.0" (or "universal-dotnet4.0" on .NET 4) Also changed RbConfig::CONFIG["host_os"] to be based on RUBY_PLATFORM so that it will be mswin32 on Windows and linux on Linux. Removed some config values that are not present in JRuby
I still have misgivings about RUBY_PLATFORM identifying the underlying OS, when in reality, the platform that Ruby is running on is the CLR. Based on this change, I will update my patch for Ruby Gems and resubmit to that team. -- Will Green http://hotgazpacho.org/ On Thu, Mar 11, 2010 at 2:53 PM, Jim Deville <jdeville at microsoft.com> wrote:> Looks good. As part of MQ, we should look deeply at the compilation based > variables and see if they can be removed or picked up from the arguments to > csc. > > JD > > > -----Original Message----- > From: Shri Borde > Sent: Thursday, March 11, 2010 11:36 AM > To: IronRuby External Code Reviewers > Cc: ironruby-core at rubyforge.org > Subject: FYI Code Review: config > > tfpt review "/shelveset:config;REDMOND\sborde" > Comment : > Change RbConfig::CONFIG["arch"] to "universal-dotnet2.0" (or > "universal-dotnet4.0" on .NET 4) > Also changed RbConfig::CONFIG["host_os"] to be based on RUBY_PLATFORM so > that it will be mswin32 on Windows and linux on Linux. > Removed some config values that are not present in JRuby > > > _______________________________________________ > Ironruby-core mailing list > Ironruby-core at rubyforge.org > http://rubyforge.org/mailman/listinfo/ironruby-core >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://rubyforge.org/pipermail/ironruby-core/attachments/20100311/a6ed45c6/attachment.html>
+1000 on cleaning up RbConfig. Perhaps a bost-build step that writes out rbconfig.rb? What is MQ? -- Will Green http://hotgazpacho.org/ On Thu, Mar 11, 2010 at 2:53 PM, Jim Deville <jdeville at microsoft.com> wrote:> Looks good. As part of MQ, we should look deeply at the compilation based > variables and see if they can be removed or picked up from the arguments to > csc. > > JD > > > -----Original Message----- > From: Shri Borde > Sent: Thursday, March 11, 2010 11:36 AM > To: IronRuby External Code Reviewers > Cc: ironruby-core at rubyforge.org > Subject: FYI Code Review: config > > tfpt review "/shelveset:config;REDMOND\sborde" > Comment : > Change RbConfig::CONFIG["arch"] to "universal-dotnet2.0" (or > "universal-dotnet4.0" on .NET 4) > Also changed RbConfig::CONFIG["host_os"] to be based on RUBY_PLATFORM so > that it will be mswin32 on Windows and linux on Linux. > Removed some config values that are not present in JRuby > > > _______________________________________________ > Ironruby-core mailing list > Ironruby-core at rubyforge.org > http://rubyforge.org/mailman/listinfo/ironruby-core >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://rubyforge.org/pipermail/ironruby-core/attachments/20100311/c87967fb/attachment.html>
MQ stands for quality milestone. It?s a period teams often use to pay of engineering debt. We will be doing some of that after IronRuby 1.0 ships. From: ironruby-core-bounces at rubyforge.org [mailto:ironruby-core-bounces at rubyforge.org] On Behalf Of Will Green Sent: Thursday, March 11, 2010 7:11 PM To: ironruby-core Subject: Re: [Ironruby-core] FYI Code Review: config +1000 on cleaning up RbConfig. Perhaps a bost-build step that writes out rbconfig.rb? What is MQ? -- Will Green http://hotgazpacho.org/ On Thu, Mar 11, 2010 at 2:53 PM, Jim Deville <jdeville at microsoft.com<mailto:jdeville at microsoft.com>> wrote: Looks good. As part of MQ, we should look deeply at the compilation based variables and see if they can be removed or picked up from the arguments to csc. JD -----Original Message----- From: Shri Borde Sent: Thursday, March 11, 2010 11:36 AM To: IronRuby External Code Reviewers Cc: ironruby-core at rubyforge.org<mailto:ironruby-core at rubyforge.org> Subject: FYI Code Review: config tfpt review "/shelveset:config;REDMOND\sborde" Comment : Change RbConfig::CONFIG["arch"] to "universal-dotnet2.0" (or "universal-dotnet4.0" on .NET 4) Also changed RbConfig::CONFIG["host_os"] to be based on RUBY_PLATFORM so that it will be mswin32 on Windows and linux on Linux. Removed some config values that are not present in JRuby _______________________________________________ Ironruby-core mailing list Ironruby-core at rubyforge.org<mailto:Ironruby-core at rubyforge.org> http://rubyforge.org/mailman/listinfo/ironruby-core -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://rubyforge.org/pipermail/ironruby-core/attachments/20100312/a09df8c5/attachment-0001.html>
Watch out for leaking Microsoft-speak ;) Sorry about that. JD From: ironruby-core-bounces at rubyforge.org [mailto:ironruby-core-bounces at rubyforge.org] On Behalf Of Shri Borde Sent: Friday, March 12, 2010 9:58 AM To: ironruby-core at rubyforge.org Subject: Re: [Ironruby-core] FYI Code Review: config MQ stands for quality milestone. It?s a period teams often use to pay of engineering debt. We will be doing some of that after IronRuby 1.0 ships. From: ironruby-core-bounces at rubyforge.org [mailto:ironruby-core-bounces at rubyforge.org] On Behalf Of Will Green Sent: Thursday, March 11, 2010 7:11 PM To: ironruby-core Subject: Re: [Ironruby-core] FYI Code Review: config +1000 on cleaning up RbConfig. Perhaps a bost-build step that writes out rbconfig.rb? What is MQ? -- Will Green http://hotgazpacho.org/ On Thu, Mar 11, 2010 at 2:53 PM, Jim Deville <jdeville at microsoft.com<mailto:jdeville at microsoft.com>> wrote: Looks good. As part of MQ, we should look deeply at the compilation based variables and see if they can be removed or picked up from the arguments to csc. JD -----Original Message----- From: Shri Borde Sent: Thursday, March 11, 2010 11:36 AM To: IronRuby External Code Reviewers Cc: ironruby-core at rubyforge.org<mailto:ironruby-core at rubyforge.org> Subject: FYI Code Review: config tfpt review "/shelveset:config;REDMOND\sborde" Comment : Change RbConfig::CONFIG["arch"] to "universal-dotnet2.0" (or "universal-dotnet4.0" on .NET 4) Also changed RbConfig::CONFIG["host_os"] to be based on RUBY_PLATFORM so that it will be mswin32 on Windows and linux on Linux. Removed some config values that are not present in JRuby _______________________________________________ Ironruby-core mailing list Ironruby-core at rubyforge.org<mailto:Ironruby-core at rubyforge.org> http://rubyforge.org/mailman/listinfo/ironruby-core -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://rubyforge.org/pipermail/ironruby-core/attachments/20100312/20c031b5/attachment.html>