Ironruby core - Mar 2010 - Code Review: MiscStrings

tfpt review "/shelveset:MiscStrings;REDMOND\tomat"

A simple DLR Console Shell change:
The version printed by the console host now recognizes Mono correctly.

Ruby changes:
Ignores UTF8 BOM in 1.8 mode unless $KCODE is SJIS or EUC.
Fixes http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=3913
Fixes -d and --version options.
Fixes a bug in StringScanner: scan doesn''t copy the original string and
[] uses the current value.
Makes MutableString.GetSlice out-of-range tolerant (needed by StringScanner#[]
fix).
Improves performance of repeated Regex.Match called on the same input string.

Tomas




-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://rubyforge.org/pipermail/ironruby-core/attachments/20100302/31c0e6c1/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: MiscStrings.diff
Type: application/octet-stream
Size: 75458 bytes
Desc: MiscStrings.diff
URL:
<http://rubyforge.org/pipermail/ironruby-core/attachments/20100302/31c0e6c1/attachment-0001.obj>

Ruby tests are fine.

JD

_____________________________________________
From: Dino Viehland
Sent: Wednesday, March 03, 2010 11:29 AM
To: Tomas Matousek; IronRuby External Code Reviewers; Rowan Code Reviewers
Cc: ironruby-core at rubyforge.org
Subject: RE: Code Review: MiscStrings


DLR change looks fine.

      _____________________________________________
      From: Tomas Matousek
      Sent: Monday, March 01, 2010 6:30 PM
      To: IronRuby External Code Reviewers; Rowan Code Reviewers
      Cc: ironruby-core at rubyforge.org
      Subject: Code Review: MiscStrings


        tfpt review "/shelveset:MiscStrings;REDMOND\tomat"

      A simple DLR Console Shell change:
      The version printed by the console host now recognizes Mono correctly.

      Ruby changes:
      Ignores UTF8 BOM in 1.8 mode unless $KCODE is SJIS or EUC.
      Fixes http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=3913
      Fixes -d and --version options.
      Fixes a bug in StringScanner: scan doesn''t copy the original
string and [] uses the current value.
      Makes MutableString.GetSlice out-of-range tolerant (needed by
StringScanner#[] fix).
      Improves performance of repeated Regex.Match called on the same input
string.

      Tomas


       << File: MiscStrings.diff >>

-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://rubyforge.org/pipermail/ironruby-core/attachments/20100304/e6b28a7c/attachment.html>