Ironruby core - Jan 2010 - Code Review: Dir4

tfpt review "/shelveset:Dir4;REDMOND\tomat"
  Comment  : 
  DLR, Python:
  -	Adds more file system APIs to PAL. Obsoletes virtual methods GetFiles and
GetDirectories in favor of GetFileSystemEntries.
  
  Ruby:
  -	Fixes some Dir specs, adds support for Unicode file/directory names. 
  -	Changes Dir and File methods to use PAL for file system operations. Adds Dir
tests exercising a custom virtual file system.
  -	Fixes encoding of file paths. This might fix some of the reported
System::Text::DecoderFallbackException issues
(http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=2931)
  -	Fixes issues with -v command line option.
  -	Fixes bugs in methods using MutableString.GetByteArray.
  -	Fixes MutableString#inspect and dump to handle strings with incomplete UTF16
characters.
  -	Fixes bugs in glob.

Tomas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Dir4.diff
Type: application/octet-stream
Size: 133345 bytes
Desc: Dir4.diff
URL:
<http://rubyforge.org/pipermail/ironruby-core/attachments/20100106/804319bc/attachment-0001.obj>

I know I''m late on this, but test looks good too.

JD

-----Original Message-----
From: Dino Viehland 
Sent: Wednesday, January 06, 2010 10:56 AM
To: Tomas Matousek; IronRuby External Code Reviewers; Rowan Code Reviewers
Cc: ironruby-core at rubyforge.org
Subject: RE: Code Review: Dir4

Python/DLR/Silverlight looks good
> -----Original Message-----
> From: Tomas Matousek
> Sent: Wednesday, January 06, 2010 10:46 AM
> To: IronRuby External Code Reviewers; Rowan Code Reviewers
> Cc: ironruby-core at rubyforge.org
> Subject: Code Review: Dir4
> 
>   tfpt review "/shelveset:Dir4;REDMOND\tomat"
>   Comment  :
>   DLR, Python:
>   -	Adds more file system APIs to PAL. Obsoletes virtual methods GetFiles
> and GetDirectories in favor of GetFileSystemEntries.
> 
>   Ruby:
>   -	Fixes some Dir specs, adds support for Unicode file/directory names.
>   -	Changes Dir and File methods to use PAL for file system operations.
Adds
> Dir tests exercising a custom virtual file system.
>   -	Fixes encoding of file paths. This might fix some of the reported
> System::Text::DecoderFallbackException issues
> (http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=2931)
>   -	Fixes issues with -v command line option.
>   -	Fixes bugs in methods using MutableString.GetByteArray.
>   -	Fixes MutableString#inspect and dump to handle strings with incomplete
> UTF16 characters.
>   -	Fixes bugs in glob.
> 
> Tomas