Shri Borde
2009-Nov-03 21:37 UTC
[Ironruby-core] Review: Fixes for double formatting on non-English culture
tfpt review /shelveset:cul;sborde Comment : Ivan''s build machine uses a Dutch-Belgium culture, where comma is used for the decimal point instead of a period. Need to use CultureInfo.Invariant to parse a float/double out of a string. -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://rubyforge.org/pipermail/ironruby-core/attachments/20091103/cdfff342/attachment-0001.html> -------------- next part -------------- A non-text attachment was scrubbed... Name: cul.diff Type: application/octet-stream Size: 6262 bytes Desc: cul.diff URL: <http://rubyforge.org/pipermail/ironruby-core/attachments/20091103/cdfff342/attachment-0001.obj>
Tomas Matousek
2009-Nov-03 22:27 UTC
[Ironruby-core] Review: Fixes for double formatting on non-English culture
Looks good. Tomas From: Shri Borde Sent: Tuesday, November 03, 2009 1:37 PM To: IronRuby External Code Reviewers; ironruby-core at rubyforge.org Subject: Review: Fixes for double formatting on non-English culture tfpt review /shelveset:cul;sborde Comment : Ivan''s build machine uses a Dutch-Belgium culture, where comma is used for the decimal point instead of a period. Need to use CultureInfo.Invariant to parse a float/double out of a string. -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://rubyforge.org/pipermail/ironruby-core/attachments/20091103/8ae45508/attachment.html>